fix(terminal): simplify REST endpoints to use instance_id only

The frontend router navigates to /instances/:instanceId/terminal without
project_id or repo_id. The backend terminal REST endpoints were requiring
these path params, causing 404s.

- Simplify _get_terminal_instance to validate by instance_id only
- Update all REST routes from /projects/{pid}/repositories/{rid}/instances/{iid}/terminal/*
  to /instances/{instance_id}/terminal/*
- Update frontend API client to match new paths
- Update useTerminalSessions hook to take instanceId only
- Update TerminalPage to use simplified hook
- Update tests to match new paths

Fixes: 404 on GET /projects/repositories/instances/{id}/terminal/sessions

apps/web/src/api/terminal.ts

@@ -25,62 +25,52 @@ export interface TerminalSessionCreateResponse {
 }
 
 export async function listTerminalSessions(
-	projectId: string,
-	repoId: string,
 	instanceId: string,
 ): Promise<TerminalSession[]> {
 	const response = await apiClient.get(
-		`/projects/${projectId}/repositories/${repoId}/instances/${instanceId}/terminal/sessions`,
+		`/instances/${instanceId}/terminal/sessions`,
 	);
 	return response.data.sessions;
 }
 
 export async function createTerminalSession(
-	projectId: string,
-	repoId: string,
 	instanceId: string,
 	name?: string,
 ): Promise<TerminalSessionCreateResponse> {
 	const response = await apiClient.post(
-		`/projects/${projectId}/repositories/${repoId}/instances/${instanceId}/terminal/sessions`,
+		`/instances/${instanceId}/terminal/sessions`,
 		{ name },
 	);
 	return response.data;
 }
 
 export async function closeTerminalSession(
-	projectId: string,
-	repoId: string,
 	instanceId: string,
 	sessionId: string,
 ): Promise<{ status: string; session_id: string }> {
 	const response = await apiClient.delete(
-		`/projects/${projectId}/repositories/${repoId}/instances/${instanceId}/terminal/sessions/${sessionId}`,
+		`/instances/${instanceId}/terminal/sessions/${sessionId}`,
 	);
 	return response.data;
 }
 
 export async function resetTerminalSession(
-	projectId: string,
-	repoId: string,
 	instanceId: string,
 	sessionId: string,
 ): Promise<{ id: string; name: string; status: string }> {
 	const response = await apiClient.post(
-		`/projects/${projectId}/repositories/${repoId}/instances/${instanceId}/terminal/sessions/${sessionId}/reset`,
+		`/instances/${instanceId}/terminal/sessions/${sessionId}/reset`,
 	);
 	return response.data;
 }
 
 export async function renameTerminalSession(
-	projectId: string,
-	repoId: string,
 	instanceId: string,
 	sessionId: string,
 	name: string,
 ): Promise<{ id: string; name: string }> {
 	const response = await apiClient.post(
-		`/projects/${projectId}/repositories/${repoId}/instances/${instanceId}/terminal/sessions/${sessionId}/rename`,
+		`/instances/${instanceId}/terminal/sessions/${sessionId}/rename`,
 		{ name },
 	);
 	return response.data;