refactor: extract shared validation and reduce duplication

- Extract tool_types validation to shared module (validate_compose_yaml, check_port_exposed, validate_required_variables)
- Extract _get_user and _get_owned_project to auth/dependencies.py
- Create useAsyncData hook and apply to 6 pages
- Create extractErrorMessage utility
- TypeScript and build pass
This commit is contained in:
Alex Blank
2026-05-25 14:01:32 +02:00
parent a905cf729e
commit a37a3122f9
19 changed files with 327 additions and 442 deletions
+35 -38
View File
@@ -3,37 +3,35 @@ import { useCallback, useEffect, useRef, useState } from "react";
import { getProfile, updateProfile, uploadAvatar } from "../api/profile";
import { Icon } from "../components/icon";
import { useAuth } from "../state/auth";
import { useAsyncData } from "../hooks/use-async-data";
import type { UserProfile } from "../api/profile";
type ProfileStatus = "loading" | "ready" | "error" | "saving";
export const ProfilePage = () => {
const { refreshSession } = useAuth();
const [status, setStatus] = useState<ProfileStatus>("loading");
const [profile, setProfile] = useState<UserProfile | null>(null);
const { data: profile, status: loadStatus, reload } = useAsyncData<UserProfile>(getProfile, []);
const [displayStatus, setDisplayStatus] = useState<ProfileStatus>("loading");
const [name, setName] = useState("");
const [email, setEmail] = useState("");
const [error, setError] = useState<string | null>(null);
const fileInputRef = useRef<HTMLInputElement>(null);
const loadProfile = useCallback(async () => {
setStatus("loading");
setError(null);
try {
const data = await getProfile();
setProfile(data);
setName(data.name);
setEmail(data.email);
setStatus("ready");
} catch {
setProfile(null);
setStatus("error");
// Sync loaded profile into form fields
useEffect(() => {
if (profile) {
setName(profile.name);
setEmail(profile.email);
setDisplayStatus("ready");
setError(null);
}
}, []);
}, [profile]);
useEffect(() => {
void loadProfile();
}, [loadProfile]);
if (loadStatus === "error") {
setDisplayStatus("error");
}
}, [loadStatus]);
const handleSave = useCallback(async () => {
if (!name.trim()) {
@@ -45,16 +43,15 @@ export const ProfilePage = () => {
return;
}
setStatus("saving");
setDisplayStatus("saving");
setError(null);
try {
const updated = await updateProfile({ name: name.trim(), email: email.trim() });
setProfile(updated);
await updateProfile({ name: name.trim(), email: email.trim() });
await refreshSession();
setStatus("ready");
setDisplayStatus("ready");
} catch {
setError("Failed to update profile");
setStatus("ready");
setDisplayStatus("ready");
}
}, [name, email, refreshSession]);
@@ -73,19 +70,19 @@ export const ProfilePage = () => {
return;
}
setStatus("saving");
setDisplayStatus("saving");
setError(null);
try {
const updated = await uploadAvatar(file);
setProfile(updated);
await uploadAvatar(file);
await refreshSession();
setStatus("ready");
reload();
setDisplayStatus("ready");
} catch {
setError("Failed to upload avatar");
setStatus("ready");
setDisplayStatus("ready");
}
},
[refreshSession]
[refreshSession, reload]
);
const avatarUrl = profile?.avatar_url ?? null;
@@ -94,19 +91,19 @@ export const ProfilePage = () => {
<section className="stack">
<h1>Profile</h1>
{status === "loading" && <p className="muted">Loading profile...</p>}
{displayStatus === "loading" && <p className="muted">Loading profile...</p>}
{status === "error" && (
{displayStatus === "error" && (
<div className="card stack">
<p>Failed to load profile</p>
<button className="secondary-button" onClick={() => void loadProfile()} type="button">
<button className="secondary-button" onClick={() => reload()} type="button">
<Icon name="refresh" size="sm" />
Retry
</button>
</div>
)}
{(status === "ready" || status === "saving") && profile && (
{(displayStatus === "ready" || displayStatus === "saving") && profile && (
<div className="card stack">
<div className="profile-avatar-section">
<div className="avatar-preview">
@@ -118,11 +115,11 @@ export const ProfilePage = () => {
</div>
<button
className="secondary-button"
disabled={status === "saving"}
disabled={displayStatus === "saving"}
onClick={() => fileInputRef.current?.click()}
type="button"
>
{status === "saving" ? (
{displayStatus === "saving" ? (
<>
<Icon name="loading" size="sm" />
Uploading...
@@ -146,7 +143,7 @@ export const ProfilePage = () => {
<div className="form-group">
<label htmlFor="profile-name">Name</label>
<input
disabled={status === "saving"}
disabled={displayStatus === "saving"}
id="profile-name"
onChange={(e) => setName(e.target.value)}
type="text"
@@ -157,7 +154,7 @@ export const ProfilePage = () => {
<div className="form-group">
<label htmlFor="profile-email">Email</label>
<input
disabled={status === "saving"}
disabled={displayStatus === "saving"}
id="profile-email"
onChange={(e) => setEmail(e.target.value)}
type="email"
@@ -170,11 +167,11 @@ export const ProfilePage = () => {
<div className="form-actions">
<button
className="primary-button"
disabled={status === "saving"}
disabled={displayStatus === "saving"}
onClick={() => void handleSave()}
type="button"
>
{status === "saving" ? (
{displayStatus === "saving" ? (
<>
<Icon name="loading" size="sm" />
Saving...