chore: archive 15 completed OpenSpec changes

Move the following audited-and-implemented changes into openspec/changes/archive/2026-06-12-completed-changes-archive/: - backend-frontend-refactoring - config-profile-git-mounts - config-profile-includes-ui - config-profile-multi-repo-mounts - container-monitoring-notifications - git-mount-url-validation - home-path-expansion - mobile-terminal-ux - mount-specificity-ordering - notification-center - persistent-terminal-sessions - session-list-overhaul - ssh-key-mounting - terminal-fullscreen-unified-header - tool-session-progress-and-updates Also regenerated .pi-map*.md files for openspec/changes so the remaining active changes (multi-session-terminal-ux, reorganize-long-files, working-copies, workspace-first-ui) reflect the new layout.
2026-06-12 14:26:55 +00:00
parent 30549f4863
commit caadd59441
493 changed files with 3563 additions and 3490 deletions
@@ -0,0 +1,2 @@
+schema: spec-driven
+created: 2026-05-24
@@ -0,0 +1,24 @@
+# archive/2026-06-12-completed-changes-archive/config-profile-includes-ui (index)
+dir: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui
+
+## role
+Archive of a completed frontend UI feature for drag-and-drop management of config profile includes with dependency visualization and cycle detection.
+## parent
+index: archive/2026-06-12-completed-changes-archive/.pi-map.index.md
+map: archive/2026-06-12-completed-changes-archive/.pi-map.md
+## children
+- archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs
+  index: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/.pi-map.index.md
+  map: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/.pi-map.md
+## files
+- .openspec.yaml
+- design.md
+- proposal.md
+- tasks.md
+## links
+index: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/.pi-map.index.md
+map: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/.pi-map.md
+## workflows
+-
+## dirty
+-
@@ -0,0 +1,22 @@
+# archive/2026-06-12-completed-changes-archive/config-profile-includes-ui
+dir: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui
+
+index: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/.pi-map.index.md
+
+## role
+Archive of a completed frontend UI feature for drag-and-drop management of config profile includes with dependency visualization and cycle detection.
+## files
+- .openspec.yaml | Defines an OpenSpec configuration file with schema version and creation date metadata
+- design.md | Design document for adding drag-and-drop profile includes management UI to an existing config profile editor frontend | dep: React, HTML5 Drag and Drop API, config profiles backend API (listConfigProfiles, updateConfigProfile, updateProfileIncludes), existing scope badge components
+- proposal.md | Proposes a UI feature for drag-and-drop management of ordered config profile includes with cycle detection and scope visualization | dep: config profiles backend API, frontend React app, drag-and-drop library
+- tasks.md | Task tracking document for implementing a profile "includes" feature with UI, drag-and-drop reordering, and error handling
+## arch
+Design-proposal-task documentation trail with OpenSpec schema metadata, capturing iterative specification of a React/Vue-like component-based UI with topological ordering constraints and visual dependency graph rendering.
+## tags
+drag, profile, design, drop, includes, .openspec, document, management
+## symbols
+-
+## workflows
+-
+## dirty
+-
@@ -0,0 +1,70 @@
+## Context
+
+The config profiles backend already supports full ordered include composition:
+- `PUT /config-profiles/{id}/includes` accepts an ordered array of profile IDs
+- The API validates ownership, self-inclusion, existence, and cycles
+- `GET /config-profiles/{id}/preview` resolves includes and shows merged output
+- The frontend profile editor (`config-profiles.tsx`) already loads all profiles via `listConfigProfiles()`
+
+However, the profile editor UI currently has no includes management surface. Users can create individual profiles but cannot compose them. This design adds a drag-and-drop includes management section to the existing profile editor.
+
+## Goals / Non-Goals
+
+**Goals:**
+- Allow users to see which profiles a profile includes
+- Allow users to add, remove, and reorder includes
+- Prevent invalid includes (self, duplicates, cycles) in the UI
+- Show scope badges on included profiles for clarity
+- Display include count in the profile list sidebar
+- Save includes together with the profile form
+
+**Non-Goals:**
+- Backend changes (APIs already fully support this)
+- Drag-and-drop library dependency (use native HTML5 DnD)
+- Profile dependency graph visualization (future enhancement)
+- Validation of include compatibility at the scope level (backend handles this)
+
+## Decisions
+
+### Use Native HTML5 Drag and Drop
+**Rationale:** No additional dependency needed. The includes list is small (typically < 10 items), so native DnD is sufficient and lightweight. Libraries like react-beautiful-dnd add bundle size and complexity for this use case.
+**Alternative considered:** `@dnd-kit/core` — rejected to keep dependencies minimal.
+
+### Save Includes with Main Form
+**Rationale:** The user explicitly requested this. It's simpler UX than a separate save button and matches the mental model of "editing a profile."
+**Implementation:** On save, first update profile fields via `updateConfigProfile()`, then update includes via `updateProfileIncludes()`. If either fails, show error and don't clear dirty state.
+
+### Frontend Cycle Detection
+**Rationale:** Prevents the user from even selecting profiles that would create a cycle, providing immediate feedback instead of waiting for the API to reject it.
+**Implementation:** Build a graph from the current `profiles` array (which includes `includes` data), then traverse from each candidate profile to check if it can reach the current profile.
+
+### Scope Badge Display
+**Rationale:** Helps users understand why certain profiles are or aren't available for inclusion, and what scope each layer operates at.
+**Implementation:** Reuse existing scope badge logic from the profile list sidebar (Global, Project scoped, Tool scoped, Project + Tool scoped).
+
+### Include Count Badge in Sidebar
+**Rationale:** Quick visual indicator of which profiles are composite vs. standalone.
+**Implementation:** Add a small numeric badge next to the profile name when `profile.includes.length > 0`.
+
+## Risks / Trade-offs
+
+**[Risk]** Saving profile and includes as two separate API calls could lead to partial success (profile saved, includes not saved).
+→ **Mitigation:** Show clear error state if either call fails. The user can retry. Since includes are independent of profile content, partial failure is recoverable.
+
+**[Risk]** Large number of profiles could make the "Add Include" dropdown unwieldy.
+→ **Mitigation:** Cap the dropdown height and add scroll. Typical users have < 20 profiles.
+
+**[Risk]** Drag-and-drop reordering may feel clunky on mobile.
+→ **Mitigation:** This is primarily a desktop admin/settings interface. Mobile support is nice-to-have but not critical.
+
+## Migration Plan
+
+No migration needed — this is a pure frontend addition. Existing profiles with includes (created via API) will immediately show those includes in the UI.
+
+## Open Questions
+
+1. Should we show a preview of the resolved output (with includes applied) in real-time as includes change?
+   - *Tentative: No, keep the existing Preview button. Real-time resolution could be expensive and is not requested.*
+
+2. Should we allow including profiles from other users (shared profiles)?
+   - *Tentative: No, backend already restricts to own profiles. Keep it simple.*
@@ -0,0 +1,29 @@
+## Why
+
+The config profiles feature supports ordered profile composition via the includes system (A includes B then C, resolution applies B → C → A), but this capability is completely invisible to users. They can create and edit individual profiles, but cannot see, add, remove, or reorder the profiles their configuration depends on. Without a UI for profile composition, users cannot build reusable config layers (e.g., an "Auth" profile + "Database" profile → "Full Stack" profile), which was a core design goal of the config profiles feature.
+
+## What Changes
+
+- Add a drag-and-drop includes management section to the config profile editor
+- Display current includes with scope badges (Global, Project, Tool scoped)
+- Allow adding includes via dropdown filtered by compatibility
+- Allow removing includes
+- Reorder includes via drag-and-drop (order affects resolution priority)
+- Save includes together with the main profile form
+- Add frontend cycle detection to prevent adding profiles that would create an include cycle
+- Update profile list items to show include count badge
+
+## Capabilities
+
+### New Capabilities
+- `config-profile-includes-management`: Managing ordered profile includes through the UI, including adding, removing, reordering, and visualizing the composition graph with scope indicators
+
+### Modified Capabilities
+- *(none — backend APIs already fully support includes)*
+
+## Impact
+
+- **Frontend**: `apps/web/src/pages/config-profiles.tsx` — add includes management UI section
+- **Frontend**: `apps/web/src/api/config_profiles.ts` — already has `updateProfileIncludes()`, no changes needed
+- **Backend**: No changes required — `PUT /config-profiles/{id}/includes` and cycle detection already exist
+- **No breaking changes**
@@ -0,0 +1,20 @@
+# archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs (index)
+dir: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs
+
+## role
+Contains archived specification documents for the config-profile-includes-ui feature from a completed changeset dated June 12, 2026.
+## parent
+index: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/.pi-map.index.md
+map: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/.pi-map.md
+## children
+- archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/config-profile-includes-management
+  index: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/config-profile-includes-management/.pi-map.index.md
+  map: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/config-profile-includes-management/.pi-map.md
+## files
+## links
+index: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/.pi-map.index.md
+map: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/.pi-map.md
+## workflows
+-
+## dirty
+-
@@ -0,0 +1,18 @@
+# archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs
+dir: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs
+
+index: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/.pi-map.index.md
+
+## role
+Contains archived specification documents for the config-profile-includes-ui feature from a completed changeset dated June 12, 2026.
+## files
+## arch
+N/A (empty directory - no code or architectural patterns present; intended as historical documentation storage for completed UI specifications)
+## tags
+-
+## symbols
+-
+## workflows
+-
+## dirty
+-
@@ -0,0 +1,19 @@
+# archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/config-profile-includes-management (index)
+dir: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/config-profile-includes-management
+
+## role
+Defines requirements for a UI feature that allows users to manage which configuration profiles are included in another profile.
+## parent
+index: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/.pi-map.index.md
+map: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/.pi-map.md
+## children
+-
+## files
+- spec.md
+## links
+index: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/config-profile-includes-management/.pi-map.index.md
+map: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/config-profile-includes-management/.pi-map.md
+## workflows
+-
+## dirty
+-
@@ -0,0 +1,19 @@
+# archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/config-profile-includes-management
+dir: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/config-profile-includes-management
+
+index: archive/2026-06-12-completed-changes-archive/config-profile-includes-ui/specs/config-profile-includes-management/.pi-map.index.md
+
+## role
+Defines requirements for a UI feature that allows users to manage which configuration profiles are included in another profile.
+## files
+- spec.md | Define requirements for a config profile editor feature that manages profile includes with display, add/remove/reorder functionality, and save capabilities | dep: profile editor UI, includes API, profile update API, dropdown component, drag-and-drop system
+## arch
+Specification-driven requirements document using Markdown format with user stories, acceptance criteria, and UI/UX details for a CRUD+reorder management interface.
+## tags
+profile, spec, define, requirements, config, editor, feature, manages
+## symbols
+-
+## workflows
+-
+## dirty
+-
@@ -0,0 +1,98 @@
+## ADDED Requirements
+
+### Requirement: Display Profile Includes
+The system SHALL display the ordered list of profiles that a config profile includes, with each include showing the included profile's name and scope.
+
+#### Scenario: View includes on profile editor
+- **WHEN** a user opens a config profile in the editor
+- **AND** that profile has includes configured
+- **THEN** the editor shows an "Includes" section
+- **AND** each include displays the profile name
+- **AND** each include displays a scope badge (Global, Project, Tool, or Project + Tool)
+- **AND** includes are shown in their resolution order (first to last)
+
+#### Scenario: Empty includes section
+- **WHEN** a user opens a config profile in the editor
+- **AND** that profile has no includes
+- **THEN** the "Includes" section is visible but empty
+- **AND** it shows a message indicating no includes are configured
+
+### Requirement: Add Profile Includes
+The system SHALL allow users to add other compatible profiles as includes to the currently edited profile.
+
+#### Scenario: Add an include
+- **WHEN** a user clicks "Add Include" in the profile editor
+- **THEN** a dropdown appears with available profiles
+- **AND** the dropdown excludes the current profile
+- **AND** the dropdown excludes profiles already included
+- **AND** the dropdown excludes profiles that would create an include cycle
+- **AND** each option shows the profile name with its scope badge
+- **WHEN** the user selects a profile
+- **THEN** it is appended to the includes list
+- **AND** it appears at the end of the resolution order
+
+#### Scenario: Prevent self-inclusion
+- **GIVEN** a user is editing profile "A"
+- **WHEN** they attempt to include profile "A" itself
+- **THEN** profile "A" does not appear in the dropdown
+
+#### Scenario: Prevent duplicate includes
+- **GIVEN** profile "A" already includes profile "B"
+- **WHEN** a user attempts to add another include
+- **THEN** profile "B" does not appear in the dropdown
+
+#### Scenario: Prevent cyclic includes
+- **GIVEN** profile "A" includes profile "B"
+- **AND** profile "B" includes profile "C"
+- **WHEN** a user is editing profile "C"
+- **THEN** profile "A" does not appear in the dropdown
+- **AND** profile "B" does not appear in the dropdown
+- **BECAUSE** including either would create a cycle
+
+### Requirement: Remove Profile Includes
+The system SHALL allow users to remove includes from a profile.
+
+#### Scenario: Remove an include
+- **WHEN** a user clicks the remove button on an include row
+- **THEN** that include is removed from the list
+- **AND** the remaining includes maintain their relative order
+
+### Requirement: Reorder Profile Includes
+The system SHALL allow users to reorder profile includes via drag-and-drop, where order determines resolution priority.
+
+#### Scenario: Reorder includes via drag-and-drop
+- **GIVEN** a profile includes profiles in order: B, C, D
+- **WHEN** a user drags "C" before "B"
+- **THEN** the order becomes: C, B, D
+- **AND** the resolution order is updated accordingly
+
+#### Scenario: Resolution order affects overrides
+- **GIVEN** profile "A" includes "B" then "C"
+- **AND** both "B" and "C" define the same environment variable "FOO"
+- **WHEN** the profile is resolved
+- **THEN** the value from "C" wins because it comes later in the order
+
+### Requirement: Save Profile Includes
+The system SHALL save profile includes when the user saves the profile form.
+
+#### Scenario: Save includes with profile
+- **GIVEN** a user has modified the includes list (added, removed, or reordered)
+- **WHEN** they click "Save Profile"
+- **THEN** the includes are saved via the includes API
+- **AND** the profile fields are saved via the profile update API
+- **AND** both operations succeed or both fail
+
+#### Scenario: Include cycle error on save
+- **GIVEN** a user has configured includes that would create a cycle
+- **WHEN** they attempt to save
+- **THEN** the save fails
+- **AND** an error message displays the cycle path
+- **AND** the form remains editable so the user can fix it
+
+### Requirement: Show Include Count in Profile List
+The system SHALL display the number of includes each profile has in the profile list sidebar.
+
+#### Scenario: Profile list shows include count
+- **WHEN** a user views the config profiles list
+- **THEN** each profile that has includes shows a badge with the count
+- **AND** profiles with no includes show no badge
@@ -0,0 +1,31 @@
+## 1. Core Includes UI
+
+- [x] 1.1 Add includes section to profile editor form with heading and empty state
+- [x] 1.2 Display current includes list with profile names and scope badges
+- [x] 1.3 Add remove button per include row
+- [x] 1.4 Add "Add Include" dropdown with available profiles filtered by validity
+- [x] 1.5 Implement frontend cycle detection to filter dropdown options
+- [x] 1.6 Save includes together with profile form on save
+
+## 2. Drag and Drop Reordering
+
+- [x] 2.1 Add drag-and-drop reordering to includes list using native HTML5 DnD
+- [x] 2.2 Update order indices after drag-and-drop reorder
+- [x] 2.3 Add visual feedback during drag (ghost image, drop target highlight)
+
+## 3. Profile List Enhancements
+
+- [x] 3.1 Add include count badge to profile list items
+
+## 4. Polish and Error Handling
+
+- [x] 4.1 Handle API cycle errors gracefully with user-friendly messages
+- [x] 4.2 Ensure save rollback on partial failure (profile saved but includes failed)
+- [x] 4.3 Add loading states for includes operations
+
+## 5. Quality Gates
+
+- [x] 5.1 TypeScript type check passes
+- [ ] 5.2 Manual testing: add, remove, reorder includes
+- [ ] 5.3 Manual testing: cycle prevention in UI
+- [ ] 5.4 Manual testing: save includes with profile form