fix: use host bind mount for /data/repos so tool containers can access mounted repos

The API container used a named Docker volume (repo_data:/data/repos) for
storing repositories. When creating tool instances with direct mount mode,
the API told Docker to bind-mount /data/repos/<repo>:/workspace into the
tool container. But the Docker daemon resolves bind-mount paths on the HOST
filesystem, not inside the API container. Since the host had no /data/repos
(the repos only existed inside the named volume), tool containers mounted
empty directories.

Changed both compose files to use a host bind mount (/data/repos:/data/repos)
instead of a named volume. This ensures:
- The API container and tool containers both see the same /data/repos path
- Bind mounts from /data/repos into tool containers work correctly

For existing installations: repos previously stored in the repo_data named
volume should be copied to /data/repos on the host before restarting the
stack.

Quality gates: compose file syntax valid
This commit is contained in:
2026-05-30 15:46:02 +02:00
parent b7396d58d2
commit d2b6bba15c
3 changed files with 167 additions and 147 deletions
+35 -13
View File
@@ -25,11 +25,13 @@ interface UseInstanceActionsReturn {
} }
export function useInstanceActions( export function useInstanceActions(
options: UseInstanceActionsOptions options: UseInstanceActionsOptions,
): UseInstanceActionsReturn { ): UseInstanceActionsReturn {
const { onRefresh } = options; const { onRefresh } = options;
const [loadingSessionId, setLoadingSessionId] = useState<string | null>(null); const [loadingSessionId, setLoadingSessionId] = useState<string | null>(null);
const [dirtyDeleteSession, setDirtyDeleteSession] = useState<Session | null>(null); const [dirtyDeleteSession, setDirtyDeleteSession] = useState<Session | null>(
null,
);
const [dirtyDeleteFiles, setDirtyDeleteFiles] = useState<string[]>([]); const [dirtyDeleteFiles, setDirtyDeleteFiles] = useState<string[]>([]);
const handleOpen = useCallback((session: Session) => { const handleOpen = useCallback((session: Session) => {
@@ -49,7 +51,11 @@ export function useInstanceActions(
if (loadingSessionId === session.id) return; if (loadingSessionId === session.id) return;
setLoadingSessionId(session.id); setLoadingSessionId(session.id);
try { try {
await startInstance(session.project_id, session.repository_id, session.id); await startInstance(
session.project_id,
session.repository_id,
session.id,
);
await onRefresh(); await onRefresh();
} catch { } catch {
// ignore // ignore
@@ -57,7 +63,7 @@ export function useInstanceActions(
setLoadingSessionId(null); setLoadingSessionId(null);
} }
}, },
[loadingSessionId, onRefresh] [loadingSessionId, onRefresh],
); );
const handleStop = useCallback( const handleStop = useCallback(
@@ -65,7 +71,11 @@ export function useInstanceActions(
if (loadingSessionId === session.id) return; if (loadingSessionId === session.id) return;
setLoadingSessionId(session.id); setLoadingSessionId(session.id);
try { try {
await stopInstance(session.project_id, session.repository_id, session.id); await stopInstance(
session.project_id,
session.repository_id,
session.id,
);
await onRefresh(); await onRefresh();
} catch { } catch {
// ignore // ignore
@@ -73,7 +83,7 @@ export function useInstanceActions(
setLoadingSessionId(null); setLoadingSessionId(null);
} }
}, },
[loadingSessionId, onRefresh] [loadingSessionId, onRefresh],
); );
const handleDelete = useCallback( const handleDelete = useCallback(
@@ -81,13 +91,20 @@ export function useInstanceActions(
if (loadingSessionId === session.id) return; if (loadingSessionId === session.id) return;
setLoadingSessionId(session.id); setLoadingSessionId(session.id);
try { try {
await deleteInstance(session.project_id, session.repository_id, session.id); await deleteInstance(
session.project_id,
session.repository_id,
session.id,
);
setDirtyDeleteSession(null); setDirtyDeleteSession(null);
setDirtyDeleteFiles([]); setDirtyDeleteFiles([]);
await onRefresh(); await onRefresh();
} catch (error) { } catch (error) {
const axiosError = error as { const axiosError = error as {
response?: { status?: number; data?: { detail?: { changed_files?: string[] } } }; response?: {
status?: number;
data?: { detail?: { changed_files?: string[] } };
};
}; };
if (axiosError.response?.status === 409) { if (axiosError.response?.status === 409) {
const detail = axiosError.response.data?.detail; const detail = axiosError.response.data?.detail;
@@ -101,7 +118,7 @@ export function useInstanceActions(
setLoadingSessionId(null); setLoadingSessionId(null);
} }
}, },
[loadingSessionId, onRefresh] [loadingSessionId, onRefresh],
); );
const handleForceDelete = useCallback( const handleForceDelete = useCallback(
@@ -109,7 +126,12 @@ export function useInstanceActions(
if (loadingSessionId === session.id) return; if (loadingSessionId === session.id) return;
setLoadingSessionId(session.id); setLoadingSessionId(session.id);
try { try {
await deleteInstance(session.project_id, session.repository_id, session.id, true); await deleteInstance(
session.project_id,
session.repository_id,
session.id,
true,
);
setDirtyDeleteSession(null); setDirtyDeleteSession(null);
setDirtyDeleteFiles([]); setDirtyDeleteFiles([]);
await onRefresh(); await onRefresh();
@@ -119,7 +141,7 @@ export function useInstanceActions(
setLoadingSessionId(null); setLoadingSessionId(null);
} }
}, },
[loadingSessionId, onRefresh] [loadingSessionId, onRefresh],
); );
const handleRecreateTunnel = useCallback( const handleRecreateTunnel = useCallback(
@@ -130,7 +152,7 @@ export function useInstanceActions(
await recreateInstanceTunnel( await recreateInstanceTunnel(
session.project_id, session.project_id,
session.repository_id, session.repository_id,
session.id session.id,
); );
await onRefresh(); await onRefresh();
} catch (err) { } catch (err) {
@@ -142,7 +164,7 @@ export function useInstanceActions(
setLoadingSessionId(null); setLoadingSessionId(null);
} }
}, },
[loadingSessionId, onRefresh] [loadingSessionId, onRefresh],
); );
const clearDirtyDelete = useCallback(() => { const clearDirtyDelete = useCallback(() => {
+1 -2
View File
@@ -92,7 +92,7 @@ services:
AUTHENTIK_AUTHORIZE_URL: ${AUTHENTIK_AUTHORIZE_URL:-} AUTHENTIK_AUTHORIZE_URL: ${AUTHENTIK_AUTHORIZE_URL:-}
AUTHENTIK_TOKEN_URL: ${AUTHENTIK_TOKEN_URL:-} AUTHENTIK_TOKEN_URL: ${AUTHENTIK_TOKEN_URL:-}
volumes: volumes:
- repo_data:/data/repos - /data/repos:/data/repos
- /data/instances:/data/instances - /data/instances:/data/instances
- avatar_uploads:/app/uploads - avatar_uploads:/app/uploads
- /var/run/docker.sock:/var/run/docker.sock - /var/run/docker.sock:/var/run/docker.sock
@@ -116,7 +116,6 @@ services:
volumes: volumes:
postgres_data: postgres_data:
redis_data: redis_data:
repo_data:
avatar_uploads: avatar_uploads:
networks: networks:
+1 -2
View File
@@ -57,7 +57,7 @@ services:
REPO_BASE_PATH: /data/repos REPO_BASE_PATH: /data/repos
INSTANCE_BASE_PATH: /data/instances INSTANCE_BASE_PATH: /data/instances
volumes: volumes:
- repo_data:/data/repos - /data/repos:/data/repos
- /data/instances:/data/instances - /data/instances:/data/instances
ports: ports:
- "8000:8000" - "8000:8000"
@@ -91,7 +91,6 @@ services:
volumes: volumes:
postgres_data: postgres_data:
redis_data: redis_data:
repo_data:
networks: networks:
backend: backend: