diff --git a/openspec/changes/service-storage-harness/apply-progress.md b/openspec/changes/archive/2026-07-09-service-storage-harness/apply-progress.md similarity index 100% rename from openspec/changes/service-storage-harness/apply-progress.md rename to openspec/changes/archive/2026-07-09-service-storage-harness/apply-progress.md diff --git a/openspec/changes/archive/2026-07-09-service-storage-harness/archive-report.md b/openspec/changes/archive/2026-07-09-service-storage-harness/archive-report.md new file mode 100644 index 0000000..a56f8af --- /dev/null +++ b/openspec/changes/archive/2026-07-09-service-storage-harness/archive-report.md @@ -0,0 +1,220 @@ +# Archive Report — `service-storage-harness` + +> Phase: **archive** · Change: `service-storage-harness` · Repo: `/home/user/manage` +> Mode: file-backed (`artifactStore: openspec`). No source-code edits; only OpenSpec artifacts +> were touched. **Not committed** — the parent/orchestrator owns the archive commit. No push, no `gh`. + +**Status: ARCHIVED.** All eight lifecycle phases are complete (proposal → spec → design → tasks → +apply → verify → sync → **archive**). Every archive precondition is verified PASS (see §2). The +canonical `openspec/specs/service-storage/spec.md` (created by `sdd-sync`) remains in place as the +durable end-state spec and is **not** moved (archive never moves canonical specs). The change folder +was moved to `openspec/changes/archive/2026-07-09-service-storage-harness/` via `git mv` to preserve +history (the renames were then unstaged so the parent commits from a clean index with explicit paths). + +--- + +## 0. Archive disposition + +- **Disposition: `archived`.** The folder move was performed inline as instructed (unlike a + `documented-pending-manual` outcome): the parent explicitly requested the `git mv` and owns the + commit, so the move is executed here and left as working-tree changes for the parent's + explicit-path commit. +- **Archive convention:** OpenSpec SDD archive contract for `openspec` mode — completed file-backed + sync → write the in-folder archive report → move the change folder to + `openspec/changes/archive/YYYY-MM-DD-{change}/`. No standalone manifest/index exists under + `openspec/` (only `config.yaml`, `changes/`, `specs/`), so the folder move **is** the archive + mechanism. No `rules.archive` override exists in `openspec/config.yaml`. +- **Target archived path:** `openspec/changes/archive/2026-07-09-service-storage-harness/` +- **Archive date:** `2026-07-09` (ISO). +- **Canonical spec left in place (not moved):** `openspec/specs/service-storage/spec.md` — + 28 requirements (SS-101 … SS-128). Verified present and byte-identical before/after the move + (sha256 `6629e307…` unchanged). The other canonical domains (`web-ui`, `prometheus-charting`) + were also left untouched. +- **Audit-trail integrity:** the change folder was moved as a whole, including the legacy flat + `spec.md` and the per-domain delta `specs/service-storage/spec.md`, which travel with the + record. Nothing was silently deleted or rewritten. The flat `spec.md` is retained as the + authoritative planning artifact the work was built against. + +## 1. Native `sdd-status` read & discrepancy statement + +The native `gentle-pi.sdd-status` engine supplied by the parent reports **non-actionable state for +this archive** because it was resolved without a change context: `changeName: null`, +`artifacts: all missing`, `applyState: blocked`, `dependencies.archive: blocked`, +`blockedReasons: ["Change selection is ambiguous: mobile-responsive-parity, service-storage-harness, +services-as-hub-ia."]`, `isNonAuthoritative: false`. This is a **parent-resolution artifact**: the +engine auto-detected three active changes and could not pick one. The ambiguity does **not** reflect +the state of `service-storage-harness`, which this archive task was **explicitly assigned**. + +**Discrepancy with the parent's authoritative confirmed state — RESOLVED in favor of the parent.** +The parent physically verified (and this executor re-confirmed directly against the filesystem in +§2) that all 35 tasks are ticked, `apply-progress.md` exists and records the four landed slices, the +verify report is clearly passing (28/28 PASS, all four gates green), and `sync-report.md` records a +completed sync. Per the archive contract's non-authoritative-store carve-out guidance and the +parent's explicit instruction ("DISREGARD; PROCEED"), the stale `archive: blocked` / "ambiguous" +labels are **disregarded** and the archive **proceeds**. + +Direct filesystem re-validation (§2) is the source of truth for this report. + +## 2. Archive preconditions (validated directly against the filesystem) + +| Precondition | Evidence | Result | +|---|---|---| +| Verify report present | `verify-report.md` | ✓ verdict **PASS** | +| Verify clearly passing — no unresolved `FAIL`/`BLOCKED`/`CRITICAL` | verify-report: **28/28 PASS** (SS-101…SS-128); the sole CRITICAL was an archive-only checkbox/apply-progress gap (now reconciled) | ✓ | +| Sync report present & successful | `sync-report.md` → **Status: SYNCED** | ✓ | +| Canonical spec exists (sync target) | `openspec/specs/service-storage/spec.md` (28 requirements) | ✓ | +| Change-side domain delta exists | `specs/service-storage/spec.md` | ✓ | +| Delta op-class = pure `## ADDED` (non-destructive) | ADDED=1, MODIFIED=0, REMOVED=0, RENAMED=0 (new domain) | ✓ | +| Requirement-ID parity (flat ↔ delta ↔ canonical) | 28 == 28 == 28, identical IDs SS-101…SS-128 | ✓ | +| proposal / design / tasks artifacts present | all populated | ✓ | +| **Final Task Completion Gate — zero unchecked `- [ ]`** | `grep -nE '^\s*- \[ \]' tasks.md` → **NONE**; `grep -cE '^\s*- \[x\]'` → **35** | ✓ | +| `apply-progress.md` present & records the work | present; status "complete — all 35 tasks done", 4 slices + final gates documented | ✓ | +| No active same-domain (`service-storage`) collision | only this change carries a `service-storage` delta; `web-ui`/`prometheus-charting` untouched | ✓ | +| Canonical untouched by the move | sha256 of `openspec/specs/service-storage/spec.md` identical before/after the `git mv` | ✓ | + +**Stale-checkbox reconciliation note.** At verify time, 30 implementation/verification checkboxes +(Slices §1.1–1.9, §2.1–2.9, §3.1–3.9, §4.1–4.3 and Integration §5.1–5.5) were unchecked and +`apply-progress.md` did not exist. That condition was reconciled **before** archive: the boxes are +now all ticked (re-confirmed directly: `grep -nE '^\s*- \[ \]' tasks.md` → none; 35 `[x]`) and +`apply-progress.md` was authored documenting the four landed slices. `apply-progress.md` plus the +verify report prove every previously-unchecked task complete. No archive-time mechanical checkbox +repair was needed — the gate now passes on the persisted `tasks.md` as-is. No partial-archive +approval applies. + +## 3. Artifacts read (archive preflight) + +- `openspec/changes/service-storage-harness/proposal.md` +- `openspec/changes/service-storage-harness/spec.md` (flat, authoritative planning artifact — 28 requirements) +- `openspec/changes/service-storage-harness/specs/service-storage/spec.md` (change-side domain delta) +- `openspec/changes/service-storage-harness/design.md` +- `openspec/changes/service-storage-harness/tasks.md` +- `openspec/changes/service-storage-harness/apply-progress.md` +- `openspec/changes/service-storage-harness/verify-report.md` +- `openspec/changes/service-storage-harness/sync-report.md` +- `openspec/specs/service-storage/spec.md` (canonical, sync target — verified present and byte-identical after the move) +- `openspec/config.yaml` (rules: proposal/tasks; no `rules.archive` override) + +> The legacy flat `spec.md` is **not** the only spec artifact: a per-domain delta +> (`specs/service-storage/spec.md`) and a canonical spec both exist, so the "legacy flat spec as the +> *only* artifact" archive-block condition does not apply. The flat spec travels with the archived +> folder as part of the audit trail. + +## 4. Domains synced & requirement delta + +| Domain | Change-side delta | Canonical | Action | +|---|---|---|---| +| `service-storage` | `specs/service-storage/spec.md` | `openspec/specs/service-storage/spec.md` | **NEW domain** — pure ADDED (28 requirements) | + +- **ADDED (28)** — all to the new `service-storage` domain (canonical did not exist pre-change). IDs + and text preserved verbatim from the verified flat `spec.md`. Grouped logically: + - *ServiceDataHarness (lifecycle layer)* — SS-101, SS-102, SS-103, SS-104 + - *QbittorrentSampleStore* — SS-105, SS-106, SS-107 + - *QbittorrentClient* — SS-108, SS-109, SS-110 + - *qBittorrent widget source adapter* — SS-111, SS-112, SS-113, SS-114, SS-115 + - *qBittorrent frontend widgets* — SS-116, SS-117, SS-118 + - *MediaIndex migration onto harness* — SS-119, SS-120, SS-121, SS-122, SS-123, SS-124 + - *Cascade-delete wiring* — SS-125, SS-126 + - *Test and build greenness* — SS-127, SS-128 +- **MODIFIED (0)** · **REMOVED (0)** · **RENAMED (0)** — new domain; nothing destructive. + +> No destructive-merge guard or parent approval was triggered (zero REMOVED / zero MODIFIED). The +> new `service-storage` domain is distinct from the existing `web-ui` and `prometheus-charting` +> canonical domains, neither of which was touched. + +## 5. Final lifecycle status (all 8 phases done) + +| Phase | Status | Evidence | +|---|---|---| +| Proposal | ✅ done | `proposal.md` | +| Spec | ✅ done | flat `spec.md` (28) + domain delta `specs/service-storage/spec.md` (28 ADDED) | +| Design | ✅ done | `design.md` | +| Tasks | ✅ done | `tasks.md` — **35/35** checked, zero `- [ ]` | +| Apply | ✅ done | 4 slices delivered (`e7bd0af`, `1fb12b8`, `c87f398`, `75c949a`) | +| Verify | ✅ PASS | `verify-report.md` — 28/28 PASS; gates green | +| Sync | ✅ done | `sync-report.md` — SYNCED; canonical `service-storage` domain created | +| Archive | ✅ done | this report + folder move performed | + +## 6. Gate results (per verify-report; head `c9404f0`) + +| Gate | Command | Result | +|---|---|---| +| Backend tests | `cd backend && PYTHONPATH=src python3 -m pytest -q` | **PASS** — 322 passed (2 pre-existing warnings) | +| Backend lint | `cd backend && PYTHONPATH=src python3 -m ruff check src tests` | **PASS** — All checks passed | +| Frontend build | `cd frontend && npm run build` | **PASS** — exit 0 (pre-existing chunk-size warning) | +| Frontend lint | `cd frontend && npm run lint` | **PASS** — 0 errors (1 pre-existing warning) | +| Extraction non-regression | `npx vitest run …/PrometheusChartWidget.test.tsx` | **PASS** — 4 passed (SS-118) | +| New FE widget/chart tests | `npx vitest run …/widgets/__tests__ …/LineSeriesChart.test.tsx` | **PASS** — 8 files, 31 tests passed | + +## 7. Carry-over follow-ups (non-blocking; recorded per verify/apply-progress) + +1. **[WARNING] Slice-2 review-budget variance** — slice 2 (`1fb12b8`) lands **~644 non-test source + lines** (qBit widget adapter + `LineSeriesChart` extraction + 3 FE widgets), above the 400-line + per-slice budget (`openspec/config.yaml`) and above the slice-2 "~350–400" forecast. No + `size:exception` was recorded. This is a forecast-vs-actual variance on an **additive** slice — + the boundary is exactly the qBit-widget feature (no unrelated files, no scope creep). Non-blocking; + recorded for the record (could have split extraction into its own slice). The verify agent rated + it WARNING, not blocking. +2. **[INFO] Slice-2 commit-hash drift** — the brief/apply-progress cited `8b0e7ea` (an earlier amend + state); the actual landed commit is `1fb12b8`. Content matches spec/design/tasks. Informational. +3. **[INFO] Stale generated `.pi-map.md`** — generated project-map artifacts (`.pi-map.md` / + `.pi-map.index.md`) predate the new modules (`service_data.py`, `qbittorrent_store.py`, + `clients/qbittorrent.py`, `Qbittorrent*.tsx`, `LineSeriesChart.tsx`). These are **generated + artifacts, not deliverable source**, and are out of scope for this change — regenerate via + `project_map_patch` / `project_map_validate` in a separate housekeeping pass; the project-map + protocol already flags these `dirty`. +4. **[INFO] `LineSeriesChart.test.tsx` smoke-only** — asserts the component mounts + (`container.firstChild` non-null) but does not assert the recharts `` SVG series rendered. + Acceptable as a crash-guard; non-blocking coverage note. +5. **[INFO] qBit store prune edge case** — `QbittorrentSampleStore.append` prunes via + `ts NOT IN (SELECT ts … LIMIT 120)`; in the degenerate case of two samples sharing an identical + `ts` the keep-set could exceed `MAX_SAMPLES=120`. At a 5 s poll the probability is effectively nil + and the per-service cap holds in all realistic operation. Non-blocking. +6. **[INFO] Orthogonal dirty working-tree items** — uncommitted cosmetic reformat of + `frontend/src/pages/service-tabs/MediaTab.tsx` and untracked `.pi-tmp/*` (predating/orthogonal to + this change) were **not touched** by this archive. + +## 8. Residual risks & destructive-merge statement + +- **Destructive sync / merge:** **not applicable.** Zero REMOVED and zero MODIFIED requirements (new + `service-storage` domain; pure ADDED). No destructive-merge guard or parent approval was triggered. +- **Backend / data-contract impact:** none beyond the planned change. The `ServiceDataHarness` is + lifecycle-only (provisioning, idempotent migrations, `service_id` cascade-delete) with **no** + generic value table or CRUD. The load-bearing MediaIndex migration (SS-119..SS-124) is correct: + `replace_items` is scoped `WHERE service_id = ?` (fixing the latent global-clear bug), with a real + regression test; the `media_index.db` file location is unchanged; existing callers are + backward-compatible via the `service_id=""` default. Archive touched only OpenSpec docs + the folder + move. +- **No critical verification issues** remain (CRITICAL issues are non-overridable; the one verify + CRITICAL was the reconcilable checkbox/apply-progress gap, now resolved). +- **No browser/visual smoke** was performed (out of scope); the qBit speed recharts line and the + Prometheus/gauge/mean charts are only structurally tested. +- **Memory observation IDs:** none — `artifactStore: openspec`; traceability lives in the filesystem + archive + canonical spec. + +## 9. Move performed + +``` +git mv openspec/changes/service-storage-harness openspec/changes/archive/2026-07-09-service-storage-harness +``` + +- **All 9 artifacts confirmed present at the archived path:** `proposal.md`, `spec.md` (flat), + `specs/service-storage/spec.md` (delta), `design.md`, `tasks.md`, `apply-progress.md`, + `verify-report.md`, `sync-report.md`, `archive-report.md` (this file). +- Of the 9, **8 were git-tracked** (renamed by `git mv`, preserving history via git rename + detection) and **1** (`archive-report.md`) is newly written and traveled with the directory move. +- **Canonical `openspec/specs/service-storage/spec.md` remains in place** — verified byte-identical + (sha256 `6629e307…`) before and after the move. `openspec/specs/web-ui/spec.md` and + `openspec/specs/prometheus-charting/spec.md` also untouched. +- **Not committed / not pushed** — the parent owns the commit with explicit paths. + +--- + +### Appendix — Files written/moved by this archive (OpenSpec only; no source code) + +- **Written:** `openspec/changes/service-storage-harness/archive-report.md` (this file) — at the + active path before the move; travels with the move into the archive. +- **Moved (via `git mv`):** the entire + `openspec/changes/service-storage-harness/` directory → + `openspec/changes/archive/2026-07-09-service-storage-harness/`. +- **Left in place (durable canonical):** `openspec/specs/service-storage/spec.md`. +- **Not committed / not pushed** — the parent owns the commit with explicit paths. diff --git a/openspec/changes/service-storage-harness/design.md b/openspec/changes/archive/2026-07-09-service-storage-harness/design.md similarity index 100% rename from openspec/changes/service-storage-harness/design.md rename to openspec/changes/archive/2026-07-09-service-storage-harness/design.md diff --git a/openspec/changes/service-storage-harness/proposal.md b/openspec/changes/archive/2026-07-09-service-storage-harness/proposal.md similarity index 100% rename from openspec/changes/service-storage-harness/proposal.md rename to openspec/changes/archive/2026-07-09-service-storage-harness/proposal.md diff --git a/openspec/changes/service-storage-harness/spec.md b/openspec/changes/archive/2026-07-09-service-storage-harness/spec.md similarity index 100% rename from openspec/changes/service-storage-harness/spec.md rename to openspec/changes/archive/2026-07-09-service-storage-harness/spec.md diff --git a/openspec/changes/service-storage-harness/specs/service-storage/spec.md b/openspec/changes/archive/2026-07-09-service-storage-harness/specs/service-storage/spec.md similarity index 100% rename from openspec/changes/service-storage-harness/specs/service-storage/spec.md rename to openspec/changes/archive/2026-07-09-service-storage-harness/specs/service-storage/spec.md diff --git a/openspec/changes/service-storage-harness/sync-report.md b/openspec/changes/archive/2026-07-09-service-storage-harness/sync-report.md similarity index 100% rename from openspec/changes/service-storage-harness/sync-report.md rename to openspec/changes/archive/2026-07-09-service-storage-harness/sync-report.md diff --git a/openspec/changes/service-storage-harness/tasks.md b/openspec/changes/archive/2026-07-09-service-storage-harness/tasks.md similarity index 100% rename from openspec/changes/service-storage-harness/tasks.md rename to openspec/changes/archive/2026-07-09-service-storage-harness/tasks.md diff --git a/openspec/changes/service-storage-harness/verify-report.md b/openspec/changes/archive/2026-07-09-service-storage-harness/verify-report.md similarity index 100% rename from openspec/changes/service-storage-harness/verify-report.md rename to openspec/changes/archive/2026-07-09-service-storage-harness/verify-report.md