Compare commits
10 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| b583d5a365 | |||
| 32fa01cc12 | |||
| ac703eecd2 | |||
| d05de0aacd | |||
| 09b9c45665 | |||
| 32516f6e3b | |||
| 30f1b6e6db | |||
| 7808822a55 | |||
| e805c624b2 | |||
| f7b63fead5 |
@@ -468,3 +468,57 @@ The system receives backup execution reports from an external backup tool via HT
|
|||||||
|
|
||||||
- Backup tool uses auto-generated Bearer API key
|
- Backup tool uses auto-generated Bearer API key
|
||||||
- Frontend uses existing OIDC/JWT auth
|
- Frontend uses existing OIDC/JWT auth
|
||||||
|
|
||||||
|
## Mobile Responsive Design
|
||||||
|
|
||||||
|
The frontend is fully operable in phone portrait (≥360px) at a single `md:`
|
||||||
|
(768px) breakpoint. Tablets and wider viewports use the desktop layout
|
||||||
|
unchanged.
|
||||||
|
|
||||||
|
### Breakpoint policy
|
||||||
|
|
||||||
|
- Single responsive cut: `md:` (768px). Below is "mobile"; at-or-above is
|
||||||
|
"desktop" (existing layout, unchanged).
|
||||||
|
- `useIsMobile()` hook (`frontend/src/hooks/useIsMobile.ts`) is the single
|
||||||
|
source of truth; it wraps `matchMedia("(max-width: 768px)")` and is SSR-safe.
|
||||||
|
- No `sm:` intermediate cut. No PWA, manifest, or service worker.
|
||||||
|
|
||||||
|
### Data tables (hybrid)
|
||||||
|
|
||||||
|
- The four wide tables (Media, FileBrowser, Users, Backups) render stacked
|
||||||
|
**cards per row** below `md` via `MobileCardRow`, each showing a primary
|
||||||
|
title plus 3–5 key fields. Narrow tables (SessionActivity) keep horizontal
|
||||||
|
scroll. The TanStack column-visibility toggle is hidden below `md`.
|
||||||
|
- At `md:` and above, all tables render as the existing `<DataTable>` unchanged.
|
||||||
|
|
||||||
|
### Edit forms (Sheet)
|
||||||
|
|
||||||
|
- Below `md`, ServicePage, Settings (machine editor), message compose, and
|
||||||
|
WidgetConfigDialog open inside a full-height `SheetForm` (side=bottom,
|
||||||
|
`h-[100dvh]`) with sticky header + sticky save bar instead of a centered
|
||||||
|
Dialog.
|
||||||
|
- At `md:` and above, the existing Dialog-based forms are unchanged.
|
||||||
|
|
||||||
|
### Touch targets
|
||||||
|
|
||||||
|
- All interactive elements below `md` have a minimum 44×44px hit area via the
|
||||||
|
`.mobile-touch-target` CSS utility (applied only below 768px). This covers
|
||||||
|
icon buttons, checkboxes, switches, and small text buttons. The class is a
|
||||||
|
no-op at `md:` and above.
|
||||||
|
|
||||||
|
### Dashboard
|
||||||
|
|
||||||
|
- Below `md`, the widget grid collapses to a single column with a section
|
||||||
|
anchor bar (Observability / Media / Backups / Custom) for quick navigation.
|
||||||
|
- At `md:` and above, the existing multi-widget grid is unchanged.
|
||||||
|
|
||||||
|
### Polling
|
||||||
|
|
||||||
|
- Widget refresh intervals and the message-queue poll interval are identical
|
||||||
|
on mobile and desktop. A follow-up to pause refetch when the tab is hidden
|
||||||
|
(`document.visibilityState`) is tracked as a future battery optimization.
|
||||||
|
|
||||||
|
### `HoverEditButton`
|
||||||
|
|
||||||
|
- Below `md`, edit affordances are always visible (not hover-gated). At `md:`
|
||||||
|
and above, the desktop hover-reveal aesthetic is preserved.
|
||||||
|
|||||||
+13
-4
@@ -62,7 +62,16 @@ import {
|
|||||||
} from "lucide-react";
|
} from "lucide-react";
|
||||||
|
|
||||||
const queryClient = new QueryClient({
|
const queryClient = new QueryClient({
|
||||||
defaultOptions: { queries: { retry: 1, refetchOnWindowFocus: false } },
|
defaultOptions: {
|
||||||
|
queries: {
|
||||||
|
retry: 1,
|
||||||
|
refetchOnWindowFocus: false,
|
||||||
|
// Pause interval-based refetches (widgets ~30s, queue status 5s,
|
||||||
|
// media build progress 1s) when the tab is hidden. Saves battery on
|
||||||
|
// mobile (D8 follow-up). Build progress polls resume on return.
|
||||||
|
refetchIntervalInBackground: false,
|
||||||
|
},
|
||||||
|
},
|
||||||
});
|
});
|
||||||
|
|
||||||
function useDarkMode() {
|
function useDarkMode() {
|
||||||
@@ -194,7 +203,7 @@ function MobileDrawer() {
|
|||||||
return (
|
return (
|
||||||
<Sheet open={open} onOpenChange={setOpen}>
|
<Sheet open={open} onOpenChange={setOpen}>
|
||||||
<SheetTrigger asChild>
|
<SheetTrigger asChild>
|
||||||
<Button variant="ghost" size="icon" className="md:hidden">
|
<Button variant="ghost" size="icon" className="mobile-touch-target md:hidden">
|
||||||
<Menu className="h-5 w-5" />
|
<Menu className="h-5 w-5" />
|
||||||
</Button>
|
</Button>
|
||||||
</SheetTrigger>
|
</SheetTrigger>
|
||||||
@@ -281,7 +290,7 @@ function TopBar({
|
|||||||
variant="ghost"
|
variant="ghost"
|
||||||
size="icon"
|
size="icon"
|
||||||
onClick={onToggleDarkMode}
|
onClick={onToggleDarkMode}
|
||||||
className="h-8 w-8"
|
className="mobile-touch-target h-8 w-8"
|
||||||
>
|
>
|
||||||
{darkMode ? (
|
{darkMode ? (
|
||||||
<Sun className="h-4 w-4" />
|
<Sun className="h-4 w-4" />
|
||||||
@@ -294,7 +303,7 @@ function TopBar({
|
|||||||
variant="ghost"
|
variant="ghost"
|
||||||
size="sm"
|
size="sm"
|
||||||
onClick={onSignOut}
|
onClick={onSignOut}
|
||||||
className="gap-2"
|
className="mobile-touch-target gap-2"
|
||||||
>
|
>
|
||||||
<LogOut className="h-4 w-4" />
|
<LogOut className="h-4 w-4" />
|
||||||
<span className="hidden sm:inline">Logout</span>
|
<span className="hidden sm:inline">Logout</span>
|
||||||
|
|||||||
@@ -50,7 +50,11 @@ export function DialogFooter({
|
|||||||
}: DialogFooterProps) {
|
}: DialogFooterProps) {
|
||||||
return (
|
return (
|
||||||
<div className="flex flex-row flex-wrap items-center justify-end gap-2">
|
<div className="flex flex-row flex-wrap items-center justify-end gap-2">
|
||||||
<Button variant="ghost" onClick={onCancel}>
|
<Button
|
||||||
|
variant="ghost"
|
||||||
|
className="mobile-touch-target"
|
||||||
|
onClick={onCancel}
|
||||||
|
>
|
||||||
{cancelLabel}
|
{cancelLabel}
|
||||||
</Button>
|
</Button>
|
||||||
{secondaryAction ? (
|
{secondaryAction ? (
|
||||||
@@ -59,6 +63,7 @@ export function DialogFooter({
|
|||||||
</div>
|
</div>
|
||||||
) : null}
|
) : null}
|
||||||
<Button
|
<Button
|
||||||
|
className="mobile-touch-target"
|
||||||
variant={resolveConfirmVariant(confirmColor, confirmVariant)}
|
variant={resolveConfirmVariant(confirmColor, confirmVariant)}
|
||||||
disabled={confirmDisabled}
|
disabled={confirmDisabled}
|
||||||
onClick={onConfirm}
|
onClick={onConfirm}
|
||||||
|
|||||||
@@ -141,7 +141,7 @@ function QueryError({
|
|||||||
<AlertTitle>{label} failed</AlertTitle>
|
<AlertTitle>{label} failed</AlertTitle>
|
||||||
<AlertDescription className="flex flex-col gap-3 sm:flex-row sm:items-center sm:justify-between">
|
<AlertDescription className="flex flex-col gap-3 sm:flex-row sm:items-center sm:justify-between">
|
||||||
<span className="break-words">{error.message}</span>
|
<span className="break-words">{error.message}</span>
|
||||||
<Button variant="outline" size="sm" onClick={() => refetch()}>
|
<Button variant="outline" size="sm" className="mobile-touch-target" onClick={() => refetch()}>
|
||||||
<RefreshCw className="mr-1 h-3 w-3" />
|
<RefreshCw className="mr-1 h-3 w-3" />
|
||||||
Retry
|
Retry
|
||||||
</Button>
|
</Button>
|
||||||
@@ -255,7 +255,7 @@ function GrafanaLinkCard({
|
|||||||
<div className="font-medium">{title}</div>
|
<div className="font-medium">{title}</div>
|
||||||
<div className="text-sm text-muted-foreground">{description}</div>
|
<div className="text-sm text-muted-foreground">{description}</div>
|
||||||
</div>
|
</div>
|
||||||
<Button variant="outline" size="sm" asChild>
|
<Button variant="outline" size="sm" className="mobile-touch-target" asChild>
|
||||||
<a
|
<a
|
||||||
href={href}
|
href={href}
|
||||||
target="_blank"
|
target="_blank"
|
||||||
@@ -585,7 +585,7 @@ export function ObservabilityPage() {
|
|||||||
title="No Node Exporter targets"
|
title="No Node Exporter targets"
|
||||||
description="Enable Node Exporter on an SSH machine in Settings to populate Prometheus scrape targets."
|
description="Enable Node Exporter on an SSH machine in Settings to populate Prometheus scrape targets."
|
||||||
action={
|
action={
|
||||||
<Button variant="outline" size="sm" asChild>
|
<Button variant="outline" size="sm" className="mobile-touch-target" asChild>
|
||||||
<Link to="/settings">Open Settings</Link>
|
<Link to="/settings">Open Settings</Link>
|
||||||
</Button>
|
</Button>
|
||||||
}
|
}
|
||||||
@@ -641,7 +641,7 @@ export function ObservabilityPage() {
|
|||||||
title="No Grafana service configured"
|
title="No Grafana service configured"
|
||||||
description="Add a Grafana service instance to enable deep-links to dashboards and logs."
|
description="Add a Grafana service instance to enable deep-links to dashboards and logs."
|
||||||
action={
|
action={
|
||||||
<Button variant="outline" size="sm" asChild>
|
<Button variant="outline" size="sm" className="mobile-touch-target" asChild>
|
||||||
<Link to="/services">Open Services</Link>
|
<Link to="/services">Open Services</Link>
|
||||||
</Button>
|
</Button>
|
||||||
}
|
}
|
||||||
@@ -653,7 +653,7 @@ export function ObservabilityPage() {
|
|||||||
title="No machine selected"
|
title="No machine selected"
|
||||||
description="Add monitoring machines in Settings to see Grafana drill-down links."
|
description="Add monitoring machines in Settings to see Grafana drill-down links."
|
||||||
action={
|
action={
|
||||||
<Button variant="outline" size="sm" asChild>
|
<Button variant="outline" size="sm" className="mobile-touch-target" asChild>
|
||||||
<Link to="/settings">Open Settings</Link>
|
<Link to="/settings">Open Settings</Link>
|
||||||
</Button>
|
</Button>
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -168,6 +168,7 @@ export function SessionActivityPanel({
|
|||||||
<Button
|
<Button
|
||||||
variant="outline"
|
variant="outline"
|
||||||
size="sm"
|
size="sm"
|
||||||
|
className="mobile-touch-target"
|
||||||
onClick={(event) => {
|
onClick={(event) => {
|
||||||
event.stopPropagation();
|
event.stopPropagation();
|
||||||
onSelectSession(session);
|
onSelectSession(session);
|
||||||
|
|||||||
@@ -26,6 +26,8 @@ import {
|
|||||||
} from "../hooks/useWidgets";
|
} from "../hooks/useWidgets";
|
||||||
import { useServiceInstances } from "../hooks/useServices";
|
import { useServiceInstances } from "../hooks/useServices";
|
||||||
import { useTasks } from "../hooks/useSettings";
|
import { useTasks } from "../hooks/useSettings";
|
||||||
|
import { useIsMobile } from "../hooks/useIsMobile";
|
||||||
|
import { SheetForm } from "@/components/ui/sheet-form";
|
||||||
import type { WidgetInstance, WidgetInstanceInput } from "../types";
|
import type { WidgetInstance, WidgetInstanceInput } from "../types";
|
||||||
import {
|
import {
|
||||||
BUILTIN_WIDGETS,
|
BUILTIN_WIDGETS,
|
||||||
@@ -277,201 +279,220 @@ export function WidgetConfigDialog({ open, onClose }: Props) {
|
|||||||
]?.widgets.find((w) => w.kind === draft.widgetKind)
|
]?.widgets.find((w) => w.kind === draft.widgetKind)
|
||||||
: BUILTIN_WIDGETS[draft.widgetKind]
|
: BUILTIN_WIDGETS[draft.widgetKind]
|
||||||
: undefined;
|
: undefined;
|
||||||
|
const isMobile = useIsMobile();
|
||||||
const isTaskOutput =
|
const isTaskOutput =
|
||||||
draft?.serviceId !== null &&
|
draft?.serviceId !== null &&
|
||||||
services.find((s) => s.id === draft?.serviceId)?.service_type ===
|
services.find((s) => s.id === draft?.serviceId)?.service_type ===
|
||||||
"ssh_tasks";
|
"ssh_tasks";
|
||||||
|
|
||||||
|
// The draft body (Title/SortOrder/Enabled/config editor) is shared between
|
||||||
|
// the Dialog (desktop) and SheetForm (mobile). On mobile the inline
|
||||||
|
// Back/Save buttons are omitted because the SheetForm footer provides them.
|
||||||
|
const draftBody = draft ? (
|
||||||
|
<div className="flex flex-col gap-4">
|
||||||
|
<div className="grid grid-cols-1 gap-3 sm:grid-cols-2">
|
||||||
|
<Field label="Title" htmlFor="widget-title">
|
||||||
|
<Input
|
||||||
|
id="widget-title"
|
||||||
|
value={draft.title}
|
||||||
|
onChange={(e) => setDraft({ ...draft, title: e.target.value })}
|
||||||
|
/>
|
||||||
|
</Field>
|
||||||
|
<Field label="Sort order" htmlFor="widget-sort-order">
|
||||||
|
<Input
|
||||||
|
id="widget-sort-order"
|
||||||
|
type="number"
|
||||||
|
value={String(draft.sortOrder)}
|
||||||
|
onChange={(e) =>
|
||||||
|
setDraft({
|
||||||
|
...draft,
|
||||||
|
sortOrder: e.target.value === "" ? 0 : Number(e.target.value),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
/>
|
||||||
|
</Field>
|
||||||
|
</div>
|
||||||
|
<div className="flex items-center gap-2">
|
||||||
|
<Switch
|
||||||
|
id="widget-enabled"
|
||||||
|
className="mobile-touch-target"
|
||||||
|
checked={draft.enabled}
|
||||||
|
onCheckedChange={(checked) =>
|
||||||
|
setDraft({ ...draft, enabled: checked })
|
||||||
|
}
|
||||||
|
/>
|
||||||
|
<Label htmlFor="widget-enabled">Enabled</Label>
|
||||||
|
</div>
|
||||||
|
<WidgetConfigEditor
|
||||||
|
binding={draftBinding}
|
||||||
|
isTaskOutput={!!isTaskOutput}
|
||||||
|
config={draft.config}
|
||||||
|
onChange={(config) => setDraft({ ...draft, config })}
|
||||||
|
tasks={tasks}
|
||||||
|
/>
|
||||||
|
{!isMobile ? (
|
||||||
|
<div className="flex justify-end gap-2">
|
||||||
|
<Button variant="outline" onClick={reset} className="mobile-touch-target">
|
||||||
|
Back
|
||||||
|
</Button>
|
||||||
|
<Button onClick={saveDraft} disabled={saveWidget.isPending} className="mobile-touch-target">
|
||||||
|
Save widget
|
||||||
|
</Button>
|
||||||
|
</div>
|
||||||
|
) : null}
|
||||||
|
</div>
|
||||||
|
) : (
|
||||||
|
<div className="flex flex-col gap-4">
|
||||||
|
{sortedInstances.length === 0 ? (
|
||||||
|
<Alert>
|
||||||
|
<AlertDescription>No widgets yet. Add one below.</AlertDescription>
|
||||||
|
</Alert>
|
||||||
|
) : (
|
||||||
|
<div className="flex flex-col gap-2">
|
||||||
|
{sortedInstances.map((instance, index) => {
|
||||||
|
const serviceName = instance.service_id
|
||||||
|
? services.find((s) => s.id === instance.service_id)?.name
|
||||||
|
: "Built-in";
|
||||||
|
return (
|
||||||
|
<div
|
||||||
|
key={instance.id}
|
||||||
|
className="flex items-center gap-2 rounded border p-2"
|
||||||
|
>
|
||||||
|
<div className="flex flex-1 flex-col gap-1">
|
||||||
|
<div className="flex items-center gap-2">
|
||||||
|
<span className="font-medium">{instance.title}</span>
|
||||||
|
<Badge variant="outline">
|
||||||
|
{bindingLabel(instance.service_id, instance.widget_kind)}
|
||||||
|
</Badge>
|
||||||
|
{serviceName ? (
|
||||||
|
<span className="text-xs text-muted-foreground">
|
||||||
|
{serviceName}
|
||||||
|
</span>
|
||||||
|
) : null}
|
||||||
|
{!instance.enabled ? (
|
||||||
|
<Badge variant="secondary">disabled</Badge>
|
||||||
|
) : null}
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
<div className="flex items-center gap-1">
|
||||||
|
<Button
|
||||||
|
variant="ghost"
|
||||||
|
size="icon"
|
||||||
|
className="mobile-touch-target h-8 w-8"
|
||||||
|
disabled={index === 0}
|
||||||
|
onClick={() => moveInstance(index, -1)}
|
||||||
|
>
|
||||||
|
<ChevronUp className="h-4 w-4" />
|
||||||
|
</Button>
|
||||||
|
<Button
|
||||||
|
variant="ghost"
|
||||||
|
size="icon"
|
||||||
|
className="mobile-touch-target h-8 w-8"
|
||||||
|
disabled={index === sortedInstances.length - 1}
|
||||||
|
onClick={() => moveInstance(index, 1)}
|
||||||
|
>
|
||||||
|
<ChevronDown className="h-4 w-4" />
|
||||||
|
</Button>
|
||||||
|
<Switch
|
||||||
|
className="mobile-touch-target"
|
||||||
|
checked={instance.enabled}
|
||||||
|
onCheckedChange={() => toggleEnabled(instance)}
|
||||||
|
aria-label={`Toggle ${instance.title}`}
|
||||||
|
/>
|
||||||
|
<Button
|
||||||
|
variant="ghost"
|
||||||
|
size="icon"
|
||||||
|
className="mobile-touch-target h-8 w-8"
|
||||||
|
onClick={() => startEdit(instance)}
|
||||||
|
>
|
||||||
|
<Pencil className="h-4 w-4" />
|
||||||
|
</Button>
|
||||||
|
<Button
|
||||||
|
variant="ghost"
|
||||||
|
size="icon"
|
||||||
|
className="mobile-touch-target h-8 w-8 text-destructive"
|
||||||
|
onClick={() => removeInstance(instance)}
|
||||||
|
>
|
||||||
|
<Trash2 className="h-4 w-4" />
|
||||||
|
</Button>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
})}
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
|
||||||
|
<div className="flex flex-col gap-2">
|
||||||
|
<p className="text-sm font-medium">Add widget</p>
|
||||||
|
<div className="flex flex-wrap gap-2">
|
||||||
|
{Object.values(BUILTIN_WIDGETS).map((b) => (
|
||||||
|
<Button
|
||||||
|
key={b.kind}
|
||||||
|
variant="outline"
|
||||||
|
size="sm"
|
||||||
|
className="mobile-touch-target"
|
||||||
|
onClick={() => startAddBuiltIn(b.kind)}
|
||||||
|
>
|
||||||
|
<Plus className="mr-1 h-3 w-3" />
|
||||||
|
{b.name}
|
||||||
|
</Button>
|
||||||
|
))}
|
||||||
|
{services
|
||||||
|
.filter((s) => s.enabled)
|
||||||
|
.flatMap((s) =>
|
||||||
|
(SERVICE_REGISTRY[s.service_type]?.widgets ?? []).map((w) => (
|
||||||
|
<Button
|
||||||
|
key={`${s.id}:${w.kind}`}
|
||||||
|
variant="outline"
|
||||||
|
size="sm"
|
||||||
|
className="mobile-touch-target"
|
||||||
|
onClick={() => startAddService(s.id, w.kind)}
|
||||||
|
>
|
||||||
|
<Plus className="mr-1 h-3 w-3" />
|
||||||
|
{w.name} · {s.name}
|
||||||
|
</Button>
|
||||||
|
)),
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
|
<p className="text-xs text-muted-foreground">
|
||||||
|
Configure services on their service pages to unlock more widgets.
|
||||||
|
</p>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
|
||||||
|
const dialogTitle = draft
|
||||||
|
? draft.id
|
||||||
|
? "Edit widget"
|
||||||
|
: "Add widget"
|
||||||
|
: "Dashboard widgets";
|
||||||
|
|
||||||
|
if (isMobile) {
|
||||||
|
return (
|
||||||
|
<SheetForm
|
||||||
|
open={open}
|
||||||
|
onOpenChange={(next) => {
|
||||||
|
if (!next) handleClose(next);
|
||||||
|
}}
|
||||||
|
title={dialogTitle}
|
||||||
|
onSave={draft ? saveDraft : () => handleClose(false)}
|
||||||
|
onCancel={draft ? reset : () => handleClose(false)}
|
||||||
|
saveLabel={draft ? "Save widget" : "Done"}
|
||||||
|
isPending={draft ? saveWidget.isPending : false}
|
||||||
|
isDirty={draft !== null}
|
||||||
|
>
|
||||||
|
<div className="flex flex-col gap-4">{draftBody}</div>
|
||||||
|
</SheetForm>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<Dialog open={open} onOpenChange={handleClose}>
|
<Dialog open={open} onOpenChange={handleClose}>
|
||||||
<DialogContent className="sm:max-w-2xl">
|
<DialogContent className="sm:max-w-2xl">
|
||||||
<DialogHeader>
|
<DialogHeader>
|
||||||
<DialogTitle>
|
<DialogTitle>{dialogTitle}</DialogTitle>
|
||||||
{draft
|
|
||||||
? draft.id
|
|
||||||
? "Edit widget"
|
|
||||||
: "Add widget"
|
|
||||||
: "Dashboard widgets"}
|
|
||||||
</DialogTitle>
|
|
||||||
</DialogHeader>
|
</DialogHeader>
|
||||||
|
{draftBody}
|
||||||
{draft ? (
|
|
||||||
<div className="flex flex-col gap-4">
|
|
||||||
<div className="grid grid-cols-1 gap-3 sm:grid-cols-2">
|
|
||||||
<Field label="Title" htmlFor="widget-title">
|
|
||||||
<Input
|
|
||||||
id="widget-title"
|
|
||||||
value={draft.title}
|
|
||||||
onChange={(e) =>
|
|
||||||
setDraft({ ...draft, title: e.target.value })
|
|
||||||
}
|
|
||||||
/>
|
|
||||||
</Field>
|
|
||||||
<Field label="Sort order" htmlFor="widget-sort-order">
|
|
||||||
<Input
|
|
||||||
id="widget-sort-order"
|
|
||||||
type="number"
|
|
||||||
value={String(draft.sortOrder)}
|
|
||||||
onChange={(e) =>
|
|
||||||
setDraft({
|
|
||||||
...draft,
|
|
||||||
sortOrder:
|
|
||||||
e.target.value === "" ? 0 : Number(e.target.value),
|
|
||||||
})
|
|
||||||
}
|
|
||||||
/>
|
|
||||||
</Field>
|
|
||||||
</div>
|
|
||||||
<div className="flex items-center gap-2">
|
|
||||||
<Switch
|
|
||||||
id="widget-enabled"
|
|
||||||
checked={draft.enabled}
|
|
||||||
onCheckedChange={(checked) =>
|
|
||||||
setDraft({ ...draft, enabled: checked })
|
|
||||||
}
|
|
||||||
/>
|
|
||||||
<Label htmlFor="widget-enabled">Enabled</Label>
|
|
||||||
</div>
|
|
||||||
<WidgetConfigEditor
|
|
||||||
binding={draftBinding}
|
|
||||||
isTaskOutput={!!isTaskOutput}
|
|
||||||
config={draft.config}
|
|
||||||
onChange={(config) => setDraft({ ...draft, config })}
|
|
||||||
tasks={tasks}
|
|
||||||
/>
|
|
||||||
<div className="flex justify-end gap-2">
|
|
||||||
<Button variant="outline" onClick={reset}>
|
|
||||||
Back
|
|
||||||
</Button>
|
|
||||||
<Button onClick={saveDraft} disabled={saveWidget.isPending}>
|
|
||||||
Save widget
|
|
||||||
</Button>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
) : (
|
|
||||||
<div className="flex flex-col gap-4">
|
|
||||||
{sortedInstances.length === 0 ? (
|
|
||||||
<Alert>
|
|
||||||
<AlertDescription>
|
|
||||||
No widgets yet. Add one below.
|
|
||||||
</AlertDescription>
|
|
||||||
</Alert>
|
|
||||||
) : (
|
|
||||||
<div className="flex flex-col gap-2">
|
|
||||||
{sortedInstances.map((instance, index) => {
|
|
||||||
const serviceName = instance.service_id
|
|
||||||
? services.find((s) => s.id === instance.service_id)?.name
|
|
||||||
: "Built-in";
|
|
||||||
return (
|
|
||||||
<div
|
|
||||||
key={instance.id}
|
|
||||||
className="flex items-center gap-2 rounded border p-2"
|
|
||||||
>
|
|
||||||
<div className="flex flex-1 flex-col gap-1">
|
|
||||||
<div className="flex items-center gap-2">
|
|
||||||
<span className="font-medium">{instance.title}</span>
|
|
||||||
<Badge variant="outline">
|
|
||||||
{bindingLabel(
|
|
||||||
instance.service_id,
|
|
||||||
instance.widget_kind,
|
|
||||||
)}
|
|
||||||
</Badge>
|
|
||||||
{serviceName ? (
|
|
||||||
<span className="text-xs text-muted-foreground">
|
|
||||||
{serviceName}
|
|
||||||
</span>
|
|
||||||
) : null}
|
|
||||||
{!instance.enabled ? (
|
|
||||||
<Badge variant="secondary">disabled</Badge>
|
|
||||||
) : null}
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
<div className="flex items-center gap-1">
|
|
||||||
<Button
|
|
||||||
variant="ghost"
|
|
||||||
size="icon"
|
|
||||||
className="h-8 w-8"
|
|
||||||
disabled={index === 0}
|
|
||||||
onClick={() => moveInstance(index, -1)}
|
|
||||||
>
|
|
||||||
<ChevronUp className="h-4 w-4" />
|
|
||||||
</Button>
|
|
||||||
<Button
|
|
||||||
variant="ghost"
|
|
||||||
size="icon"
|
|
||||||
className="h-8 w-8"
|
|
||||||
disabled={index === sortedInstances.length - 1}
|
|
||||||
onClick={() => moveInstance(index, 1)}
|
|
||||||
>
|
|
||||||
<ChevronDown className="h-4 w-4" />
|
|
||||||
</Button>
|
|
||||||
<Switch
|
|
||||||
checked={instance.enabled}
|
|
||||||
onCheckedChange={() => toggleEnabled(instance)}
|
|
||||||
aria-label={`Toggle ${instance.title}`}
|
|
||||||
/>
|
|
||||||
<Button
|
|
||||||
variant="ghost"
|
|
||||||
size="icon"
|
|
||||||
className="h-8 w-8"
|
|
||||||
onClick={() => startEdit(instance)}
|
|
||||||
>
|
|
||||||
<Pencil className="h-4 w-4" />
|
|
||||||
</Button>
|
|
||||||
<Button
|
|
||||||
variant="ghost"
|
|
||||||
size="icon"
|
|
||||||
className="h-8 w-8 text-destructive"
|
|
||||||
onClick={() => removeInstance(instance)}
|
|
||||||
>
|
|
||||||
<Trash2 className="h-4 w-4" />
|
|
||||||
</Button>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
);
|
|
||||||
})}
|
|
||||||
</div>
|
|
||||||
)}
|
|
||||||
|
|
||||||
<div className="flex flex-col gap-2">
|
|
||||||
<p className="text-sm font-medium">Add widget</p>
|
|
||||||
<div className="flex flex-wrap gap-2">
|
|
||||||
{Object.values(BUILTIN_WIDGETS).map((b) => (
|
|
||||||
<Button
|
|
||||||
key={b.kind}
|
|
||||||
variant="outline"
|
|
||||||
size="sm"
|
|
||||||
onClick={() => startAddBuiltIn(b.kind)}
|
|
||||||
>
|
|
||||||
<Plus className="mr-1 h-3 w-3" />
|
|
||||||
{b.name}
|
|
||||||
</Button>
|
|
||||||
))}
|
|
||||||
{services
|
|
||||||
.filter((s) => s.enabled)
|
|
||||||
.flatMap((s) =>
|
|
||||||
(SERVICE_REGISTRY[s.service_type]?.widgets ?? []).map(
|
|
||||||
(w) => (
|
|
||||||
<Button
|
|
||||||
key={`${s.id}:${w.kind}`}
|
|
||||||
variant="outline"
|
|
||||||
size="sm"
|
|
||||||
onClick={() => startAddService(s.id, w.kind)}
|
|
||||||
>
|
|
||||||
<Plus className="mr-1 h-3 w-3" />
|
|
||||||
{w.name} · {s.name}
|
|
||||||
</Button>
|
|
||||||
),
|
|
||||||
),
|
|
||||||
)}
|
|
||||||
</div>
|
|
||||||
<p className="text-xs text-muted-foreground">
|
|
||||||
Configure services on their service pages to unlock more
|
|
||||||
widgets.
|
|
||||||
</p>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
)}
|
|
||||||
</DialogContent>
|
</DialogContent>
|
||||||
</Dialog>
|
</Dialog>
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -0,0 +1,67 @@
|
|||||||
|
import { describe, it, expect, beforeEach, vi } from "vitest";
|
||||||
|
import { render, screen } from "@testing-library/react";
|
||||||
|
import { WidgetConfigDialog } from "../WidgetConfigDialog";
|
||||||
|
|
||||||
|
// jsdom has no window.matchMedia; default to desktop (matches: false).
|
||||||
|
function setMatchMedia(matches: boolean) {
|
||||||
|
window.matchMedia = ((query: string) => ({
|
||||||
|
matches: query.includes("768") ? matches : false,
|
||||||
|
media: query,
|
||||||
|
onchange: null,
|
||||||
|
addEventListener: () => {},
|
||||||
|
removeEventListener: () => {},
|
||||||
|
addListener: () => {},
|
||||||
|
removeListener: () => {},
|
||||||
|
dispatchEvent: () => false,
|
||||||
|
})) as unknown as typeof window.matchMedia;
|
||||||
|
}
|
||||||
|
|
||||||
|
vi.mock("../../hooks/useWidgets", () => ({
|
||||||
|
useWidgetInstances: () => ({ data: [] }),
|
||||||
|
useSaveWidgetInstance: () => ({ mutateAsync: vi.fn(), isPending: false }),
|
||||||
|
useDeleteWidgetInstance: () => ({ mutateAsync: vi.fn(), isPending: false }),
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("../../hooks/useServices", () => ({
|
||||||
|
useServiceInstances: () => ({ data: [] }),
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("../../hooks/useSettings", () => ({
|
||||||
|
useTasks: () => ({ data: [] }),
|
||||||
|
}));
|
||||||
|
|
||||||
|
beforeEach(() => setMatchMedia(false));
|
||||||
|
|
||||||
|
describe("WidgetConfigDialog (desktop)", () => {
|
||||||
|
it("renders a Dialog with the dashboard widgets title at md+", () => {
|
||||||
|
render(<WidgetConfigDialog open={true} onClose={() => {}} />);
|
||||||
|
expect(
|
||||||
|
screen.getByRole("heading", { name: "Dashboard widgets" }),
|
||||||
|
).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("WidgetConfigDialog (mobile SheetForm — slice 8)", () => {
|
||||||
|
beforeEach(() => setMatchMedia(true));
|
||||||
|
|
||||||
|
it("renders a SheetForm with the dashboard widgets title below md", () => {
|
||||||
|
render(<WidgetConfigDialog open={true} onClose={() => {}} />);
|
||||||
|
expect(screen.getByText("Dashboard widgets")).toBeInTheDocument();
|
||||||
|
// List mode footer: "Done" button closes.
|
||||||
|
expect(screen.getByRole("button", { name: "Done" })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("prompts before discarding a widget draft (R4.5)", async () => {
|
||||||
|
const { userEvent } = await import("@testing-library/user-event");
|
||||||
|
render(<WidgetConfigDialog open={true} onClose={() => {}} />);
|
||||||
|
|
||||||
|
// Enter draft mode by clicking an "Add widget" button.
|
||||||
|
await userEvent.click(screen.getByRole("button", { name: /Backups/i }));
|
||||||
|
|
||||||
|
// Now in draft mode — Cancel should prompt before resetting.
|
||||||
|
await userEvent.click(screen.getByRole("button", { name: "Cancel" }));
|
||||||
|
expect(
|
||||||
|
screen.getByRole("heading", { name: "Discard changes?" }),
|
||||||
|
).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -93,4 +93,76 @@ describe("SheetForm", () => {
|
|||||||
await userEvent.click(screen.getByRole("button", { name: "Close" }));
|
await userEvent.click(screen.getByRole("button", { name: "Close" }));
|
||||||
expect(onCancel).toHaveBeenCalledTimes(1);
|
expect(onCancel).toHaveBeenCalledTimes(1);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe("dirty-state confirm (R4.5)", () => {
|
||||||
|
it("prompts before discarding via Cancel when isDirty", async () => {
|
||||||
|
const onCancel = vi.fn();
|
||||||
|
render(
|
||||||
|
<SheetForm
|
||||||
|
open
|
||||||
|
onOpenChange={() => {}}
|
||||||
|
title="Edit"
|
||||||
|
onSave={() => {}}
|
||||||
|
onCancel={onCancel}
|
||||||
|
isDirty
|
||||||
|
>
|
||||||
|
<div />
|
||||||
|
</SheetForm>,
|
||||||
|
);
|
||||||
|
|
||||||
|
// Cancel does not immediately close; a confirm opens.
|
||||||
|
await userEvent.click(screen.getByRole("button", { name: "Cancel" }));
|
||||||
|
expect(onCancel).not.toHaveBeenCalled();
|
||||||
|
expect(
|
||||||
|
screen.getByRole("heading", { name: "Discard changes?" }),
|
||||||
|
).toBeInTheDocument();
|
||||||
|
|
||||||
|
// Confirm discard -> actually closes.
|
||||||
|
await userEvent.click(screen.getByRole("button", { name: "Discard" }));
|
||||||
|
expect(onCancel).toHaveBeenCalledTimes(1);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("closing the confirm without discarding keeps the form open", async () => {
|
||||||
|
const onCancel = vi.fn();
|
||||||
|
render(
|
||||||
|
<SheetForm
|
||||||
|
open
|
||||||
|
onOpenChange={() => {}}
|
||||||
|
title="Edit"
|
||||||
|
onSave={() => {}}
|
||||||
|
onCancel={onCancel}
|
||||||
|
isDirty
|
||||||
|
>
|
||||||
|
<div />
|
||||||
|
</SheetForm>,
|
||||||
|
);
|
||||||
|
|
||||||
|
await userEvent.click(screen.getByRole("button", { name: "Cancel" }));
|
||||||
|
// Two Cancel buttons now exist: the SheetForm footer and the confirm dialog.
|
||||||
|
const cancelButtons = screen.getAllByRole("button", { name: "Cancel" });
|
||||||
|
await userEvent.click(cancelButtons[cancelButtons.length - 1]);
|
||||||
|
expect(onCancel).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("closes immediately when not dirty", async () => {
|
||||||
|
const onCancel = vi.fn();
|
||||||
|
render(
|
||||||
|
<SheetForm
|
||||||
|
open
|
||||||
|
onOpenChange={() => {}}
|
||||||
|
title="Edit"
|
||||||
|
onSave={() => {}}
|
||||||
|
onCancel={onCancel}
|
||||||
|
>
|
||||||
|
<div />
|
||||||
|
</SheetForm>,
|
||||||
|
);
|
||||||
|
|
||||||
|
await userEvent.click(screen.getByRole("button", { name: "Cancel" }));
|
||||||
|
expect(onCancel).toHaveBeenCalledTimes(1);
|
||||||
|
expect(
|
||||||
|
screen.queryByRole("heading", { name: "Discard changes?" }),
|
||||||
|
).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -6,7 +6,6 @@ import {
|
|||||||
type OnChangeFn,
|
type OnChangeFn,
|
||||||
type PaginationState,
|
type PaginationState,
|
||||||
type RowSelectionState,
|
type RowSelectionState,
|
||||||
type Table as TableInstance,
|
|
||||||
type VisibilityState,
|
type VisibilityState,
|
||||||
flexRender,
|
flexRender,
|
||||||
getCoreRowModel,
|
getCoreRowModel,
|
||||||
@@ -18,6 +17,7 @@ import { Columns3 } from "lucide-react";
|
|||||||
import { cn } from "@/lib/utils";
|
import { cn } from "@/lib/utils";
|
||||||
import { Button } from "@/components/ui/button";
|
import { Button } from "@/components/ui/button";
|
||||||
import { Checkbox } from "@/components/ui/checkbox";
|
import { Checkbox } from "@/components/ui/checkbox";
|
||||||
|
import { TablePagination } from "@/components/ui/table-pagination";
|
||||||
import {
|
import {
|
||||||
Table,
|
Table,
|
||||||
TableBody,
|
TableBody,
|
||||||
@@ -34,13 +34,6 @@ import {
|
|||||||
DropdownMenuSeparator,
|
DropdownMenuSeparator,
|
||||||
DropdownMenuTrigger,
|
DropdownMenuTrigger,
|
||||||
} from "@/components/ui/dropdown-menu";
|
} from "@/components/ui/dropdown-menu";
|
||||||
import {
|
|
||||||
Select,
|
|
||||||
SelectContent,
|
|
||||||
SelectItem,
|
|
||||||
SelectTrigger,
|
|
||||||
SelectValue,
|
|
||||||
} from "@/components/ui/select";
|
|
||||||
|
|
||||||
export interface DataTableProps<TData, TValue = unknown> {
|
export interface DataTableProps<TData, TValue = unknown> {
|
||||||
columns: ColumnDef<TData, TValue>[];
|
columns: ColumnDef<TData, TValue>[];
|
||||||
@@ -253,90 +246,19 @@ export function DataTable<TData, TValue = unknown>({
|
|||||||
</div>
|
</div>
|
||||||
|
|
||||||
{enablePagination && (
|
{enablePagination && (
|
||||||
<DataTablePagination
|
<TablePagination
|
||||||
table={table}
|
pageIndex={table.getState().pagination.pageIndex}
|
||||||
|
pageSize={table.getState().pagination.pageSize}
|
||||||
pageSizeOptions={pageSizeOptions}
|
pageSizeOptions={pageSizeOptions}
|
||||||
|
totalRows={manualPagination ? (rowCount ?? 0) : table.getRowModel().rows.length}
|
||||||
pageCount={pageCount}
|
pageCount={pageCount}
|
||||||
manual={manualPagination}
|
onPaginationChange={table.setPagination}
|
||||||
rowCount={rowCount}
|
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
interface PaginationProps<TData> {
|
// DataTablePagination was extracted into the shared TablePagination component
|
||||||
table: TableInstance<TData>;
|
// (frontend/src/components/ui/table-pagination.tsx). Both the desktop DataTable
|
||||||
pageSizeOptions: number[];
|
// and the Media mobile card list consume it.
|
||||||
pageCount: number;
|
|
||||||
manual: boolean;
|
|
||||||
rowCount?: number;
|
|
||||||
}
|
|
||||||
|
|
||||||
function DataTablePagination<TData>({
|
|
||||||
table,
|
|
||||||
pageSizeOptions,
|
|
||||||
pageCount,
|
|
||||||
manual,
|
|
||||||
rowCount,
|
|
||||||
}: PaginationProps<TData>) {
|
|
||||||
const pageIndex = table.getState().pagination.pageIndex;
|
|
||||||
const pageSize = table.getState().pagination.pageSize;
|
|
||||||
const visibleRows = table.getRowModel().rows.length;
|
|
||||||
const totalRows = manual ? (rowCount ?? 0) : visibleRows;
|
|
||||||
|
|
||||||
return (
|
|
||||||
<div className="flex flex-wrap items-center justify-between gap-3 text-sm">
|
|
||||||
<div className="text-muted-foreground">
|
|
||||||
{`${totalRows} row${totalRows === 1 ? "" : "s"}`}
|
|
||||||
</div>
|
|
||||||
<div className="flex items-center gap-3">
|
|
||||||
<div className="flex items-center gap-1.5">
|
|
||||||
<span className="text-muted-foreground">Rows per page</span>
|
|
||||||
<Select
|
|
||||||
value={String(pageSize)}
|
|
||||||
onValueChange={(value) => table.setPageSize(Number(value))}
|
|
||||||
>
|
|
||||||
<SelectTrigger
|
|
||||||
size="sm"
|
|
||||||
className="w-[70px]"
|
|
||||||
aria-label="Rows per page"
|
|
||||||
>
|
|
||||||
<SelectValue />
|
|
||||||
</SelectTrigger>
|
|
||||||
<SelectContent>
|
|
||||||
{pageSizeOptions.map((option) => (
|
|
||||||
<SelectItem key={option} value={String(option)}>
|
|
||||||
{option}
|
|
||||||
</SelectItem>
|
|
||||||
))}
|
|
||||||
</SelectContent>
|
|
||||||
</Select>
|
|
||||||
</div>
|
|
||||||
<span className="text-muted-foreground">
|
|
||||||
Page {pageIndex + 1} of {pageCount}
|
|
||||||
</span>
|
|
||||||
<div className="flex items-center gap-1">
|
|
||||||
<Button
|
|
||||||
variant="outline"
|
|
||||||
size="sm"
|
|
||||||
onClick={() => table.previousPage()}
|
|
||||||
disabled={!table.getCanPreviousPage()}
|
|
||||||
aria-label="Previous page"
|
|
||||||
>
|
|
||||||
Previous
|
|
||||||
</Button>
|
|
||||||
<Button
|
|
||||||
variant="outline"
|
|
||||||
size="sm"
|
|
||||||
onClick={() => table.nextPage()}
|
|
||||||
disabled={!table.getCanNextPage()}
|
|
||||||
aria-label="Next page"
|
|
||||||
>
|
|
||||||
Next
|
|
||||||
</Button>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|||||||
@@ -4,6 +4,7 @@ import { Loader2, XIcon } from "lucide-react";
|
|||||||
import { cn } from "@/lib/utils";
|
import { cn } from "@/lib/utils";
|
||||||
import { Button } from "@/components/ui/button";
|
import { Button } from "@/components/ui/button";
|
||||||
import { Sheet, SheetContent, SheetTitle } from "@/components/ui/sheet";
|
import { Sheet, SheetContent, SheetTitle } from "@/components/ui/sheet";
|
||||||
|
import { ConfirmDialog } from "@/components/ConfirmDialog";
|
||||||
|
|
||||||
export interface SheetFormProps {
|
export interface SheetFormProps {
|
||||||
open: boolean;
|
open: boolean;
|
||||||
@@ -15,6 +16,14 @@ export interface SheetFormProps {
|
|||||||
isPending?: boolean;
|
isPending?: boolean;
|
||||||
/** Override the Save button label (default "Save"). */
|
/** Override the Save button label (default "Save"). */
|
||||||
saveLabel?: string;
|
saveLabel?: string;
|
||||||
|
/** Disable the Save button (e.g. when required fields are empty). */
|
||||||
|
saveDisabled?: boolean;
|
||||||
|
/**
|
||||||
|
* When true, any close attempt (Cancel button, header X, overlay click,
|
||||||
|
* Escape) prompts a discard-confirmation instead of immediately closing.
|
||||||
|
* Spec R4.5.
|
||||||
|
*/
|
||||||
|
isDirty?: boolean;
|
||||||
children: React.ReactNode;
|
children: React.ReactNode;
|
||||||
/** Optional className applied to the scrolling body. */
|
/** Optional className applied to the scrolling body. */
|
||||||
bodyClassName?: string;
|
bodyClassName?: string;
|
||||||
@@ -39,16 +48,55 @@ export function SheetForm({
|
|||||||
onSave,
|
onSave,
|
||||||
onCancel,
|
onCancel,
|
||||||
isPending = false,
|
isPending = false,
|
||||||
|
saveDisabled = false,
|
||||||
saveLabel = "Save",
|
saveLabel = "Save",
|
||||||
|
isDirty = false,
|
||||||
children,
|
children,
|
||||||
bodyClassName,
|
bodyClassName,
|
||||||
}: SheetFormProps) {
|
}: SheetFormProps) {
|
||||||
|
const [confirmDiscardOpen, setConfirmDiscardOpen] = React.useState(false);
|
||||||
|
|
||||||
|
// Route every close path (Cancel, header X, Radix overlay/Escape) through one
|
||||||
|
// guard so the dirty-confirm is applied uniformly (spec R4.5).
|
||||||
|
const attemptClose = React.useCallback(() => {
|
||||||
|
if (isDirty) {
|
||||||
|
setConfirmDiscardOpen(true);
|
||||||
|
} else {
|
||||||
|
onCancel();
|
||||||
|
}
|
||||||
|
}, [isDirty, onCancel]);
|
||||||
|
|
||||||
|
const handleOpenChange = React.useCallback(
|
||||||
|
(next: boolean) => {
|
||||||
|
if (!next) {
|
||||||
|
attemptClose();
|
||||||
|
} else {
|
||||||
|
onOpenChange(next);
|
||||||
|
}
|
||||||
|
},
|
||||||
|
[attemptClose, onOpenChange],
|
||||||
|
);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<Sheet open={open} onOpenChange={onOpenChange}>
|
<Sheet open={open} onOpenChange={handleOpenChange}>
|
||||||
<SheetContent
|
<SheetContent
|
||||||
side="bottom"
|
side="bottom"
|
||||||
showCloseButton={false}
|
showCloseButton={false}
|
||||||
className="flex h-[100dvh] w-full flex-col gap-0 p-0 sm:max-w-full"
|
className="flex h-[100dvh] w-full flex-col gap-0 p-0 sm:max-w-full"
|
||||||
|
onEscapeKeyDown={(e) => {
|
||||||
|
// Prevent Radix's default Escape close so our guard runs instead.
|
||||||
|
if (isDirty) {
|
||||||
|
e.preventDefault();
|
||||||
|
attemptClose();
|
||||||
|
}
|
||||||
|
}}
|
||||||
|
onPointerDownOutside={(e) => {
|
||||||
|
// Prevent overlay-click close so our guard runs instead.
|
||||||
|
if (isDirty) {
|
||||||
|
e.preventDefault();
|
||||||
|
attemptClose();
|
||||||
|
}
|
||||||
|
}}
|
||||||
>
|
>
|
||||||
{/* Header — fixed at top */}
|
{/* Header — fixed at top */}
|
||||||
<div className="flex h-14 shrink-0 items-center justify-between border-b border-border px-4">
|
<div className="flex h-14 shrink-0 items-center justify-between border-b border-border px-4">
|
||||||
@@ -59,7 +107,7 @@ export function SheetForm({
|
|||||||
variant="ghost"
|
variant="ghost"
|
||||||
size="icon-sm"
|
size="icon-sm"
|
||||||
aria-label="Close"
|
aria-label="Close"
|
||||||
onClick={onCancel}
|
onClick={attemptClose}
|
||||||
>
|
>
|
||||||
<XIcon />
|
<XIcon />
|
||||||
</Button>
|
</Button>
|
||||||
@@ -72,10 +120,10 @@ export function SheetForm({
|
|||||||
|
|
||||||
{/* Footer — fixed at bottom */}
|
{/* Footer — fixed at bottom */}
|
||||||
<div className="flex shrink-0 items-center justify-end gap-2 border-t border-border bg-muted/50 p-4">
|
<div className="flex shrink-0 items-center justify-end gap-2 border-t border-border bg-muted/50 p-4">
|
||||||
<Button variant="outline" onClick={onCancel} disabled={isPending}>
|
<Button variant="outline" onClick={attemptClose} disabled={isPending}>
|
||||||
Cancel
|
Cancel
|
||||||
</Button>
|
</Button>
|
||||||
<Button onClick={onSave} disabled={isPending}>
|
<Button onClick={onSave} disabled={isPending || saveDisabled}>
|
||||||
{isPending ? (
|
{isPending ? (
|
||||||
<>
|
<>
|
||||||
<Loader2 className="animate-spin" />
|
<Loader2 className="animate-spin" />
|
||||||
@@ -87,6 +135,18 @@ export function SheetForm({
|
|||||||
</Button>
|
</Button>
|
||||||
</div>
|
</div>
|
||||||
</SheetContent>
|
</SheetContent>
|
||||||
|
|
||||||
|
<ConfirmDialog
|
||||||
|
open={confirmDiscardOpen}
|
||||||
|
title="Discard changes?"
|
||||||
|
message="You have unsaved changes. Discard them and close?"
|
||||||
|
confirmLabel="Discard"
|
||||||
|
onCancel={() => setConfirmDiscardOpen(false)}
|
||||||
|
onConfirm={() => {
|
||||||
|
setConfirmDiscardOpen(false);
|
||||||
|
onCancel();
|
||||||
|
}}
|
||||||
|
/>
|
||||||
</Sheet>
|
</Sheet>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,122 @@
|
|||||||
|
import type { OnChangeFn } from "@tanstack/react-table";
|
||||||
|
import type { PaginationState } from "@tanstack/react-table";
|
||||||
|
|
||||||
|
import { cn } from "@/lib/utils";
|
||||||
|
import { Button } from "@/components/ui/button";
|
||||||
|
import {
|
||||||
|
Select,
|
||||||
|
SelectContent,
|
||||||
|
SelectItem,
|
||||||
|
SelectTrigger,
|
||||||
|
SelectValue,
|
||||||
|
} from "@/components/ui/select";
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Shared pagination footer for table-style views.
|
||||||
|
*
|
||||||
|
* Renders the rows count, page-size select, page indicator, and prev/next
|
||||||
|
* buttons. Works off the raw {@link PaginationState} primitives so it can back
|
||||||
|
* both a TanStack `Table` instance (via a thin adapter) and standalone card
|
||||||
|
* layouts that drive pagination directly (e.g. MediaMobilePagination).
|
||||||
|
*
|
||||||
|
* The Desktop DataTable and the Media mobile card list both consume this to
|
||||||
|
* avoid the duplication flagged in
|
||||||
|
* `openspec/changes/mobile-responsive-parity/verify-report.md` residual risk #5.
|
||||||
|
*/
|
||||||
|
export interface TablePaginationProps {
|
||||||
|
pageIndex: number;
|
||||||
|
pageSize: number;
|
||||||
|
pageSizeOptions: number[];
|
||||||
|
totalRows: number;
|
||||||
|
pageCount: number;
|
||||||
|
onPaginationChange: OnChangeFn<PaginationState>;
|
||||||
|
/** Optional extra className on the outer container (e.g. "p-4"). */
|
||||||
|
className?: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
export function TablePagination({
|
||||||
|
pageIndex,
|
||||||
|
pageSize,
|
||||||
|
pageSizeOptions,
|
||||||
|
totalRows,
|
||||||
|
pageCount,
|
||||||
|
onPaginationChange,
|
||||||
|
className,
|
||||||
|
}: TablePaginationProps) {
|
||||||
|
return (
|
||||||
|
<div
|
||||||
|
className={cn(
|
||||||
|
"flex flex-wrap items-center justify-between gap-3 text-sm",
|
||||||
|
className,
|
||||||
|
)}
|
||||||
|
>
|
||||||
|
<div className="text-muted-foreground">
|
||||||
|
{`${totalRows} row${totalRows === 1 ? "" : "s"}`}
|
||||||
|
</div>
|
||||||
|
<div className="flex items-center gap-3">
|
||||||
|
<div className="flex items-center gap-1.5">
|
||||||
|
<span className="text-muted-foreground">Rows per page</span>
|
||||||
|
<Select
|
||||||
|
value={String(pageSize)}
|
||||||
|
onValueChange={(value) =>
|
||||||
|
onPaginationChange(() => ({
|
||||||
|
pageIndex: 0,
|
||||||
|
pageSize: Number(value),
|
||||||
|
}))
|
||||||
|
}
|
||||||
|
>
|
||||||
|
<SelectTrigger
|
||||||
|
size="sm"
|
||||||
|
className="w-[70px]"
|
||||||
|
aria-label="Rows per page"
|
||||||
|
>
|
||||||
|
<SelectValue />
|
||||||
|
</SelectTrigger>
|
||||||
|
<SelectContent>
|
||||||
|
{pageSizeOptions.map((option) => (
|
||||||
|
<SelectItem key={option} value={String(option)}>
|
||||||
|
{option}
|
||||||
|
</SelectItem>
|
||||||
|
))}
|
||||||
|
</SelectContent>
|
||||||
|
</Select>
|
||||||
|
</div>
|
||||||
|
<span className="text-muted-foreground">
|
||||||
|
Page {pageIndex + 1} of {pageCount}
|
||||||
|
</span>
|
||||||
|
<div className="flex items-center gap-1">
|
||||||
|
<Button
|
||||||
|
variant="outline"
|
||||||
|
size="sm"
|
||||||
|
className="mobile-touch-target"
|
||||||
|
onClick={() =>
|
||||||
|
onPaginationChange((prev) => ({
|
||||||
|
...prev,
|
||||||
|
pageIndex: Math.max(0, prev.pageIndex - 1),
|
||||||
|
}))
|
||||||
|
}
|
||||||
|
disabled={pageIndex <= 0}
|
||||||
|
aria-label="Previous page"
|
||||||
|
>
|
||||||
|
Previous
|
||||||
|
</Button>
|
||||||
|
<Button
|
||||||
|
variant="outline"
|
||||||
|
size="sm"
|
||||||
|
className="mobile-touch-target"
|
||||||
|
onClick={() =>
|
||||||
|
onPaginationChange((prev) => ({
|
||||||
|
...prev,
|
||||||
|
pageIndex: prev.pageIndex + 1,
|
||||||
|
}))
|
||||||
|
}
|
||||||
|
disabled={pageIndex >= pageCount - 1}
|
||||||
|
aria-label="Next page"
|
||||||
|
>
|
||||||
|
Next
|
||||||
|
</Button>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
@@ -14,7 +14,10 @@ export function useMediaStatus(jellyfinServiceId?: string) {
|
|||||||
staleTime: 5_000,
|
staleTime: 5_000,
|
||||||
refetchInterval: (query) =>
|
refetchInterval: (query) =>
|
||||||
query.state.data?.build_running ? 1000 : false,
|
query.state.data?.build_running ? 1000 : false,
|
||||||
refetchIntervalInBackground: true,
|
// Inherit the default refetchIntervalInBackground: false — pause the
|
||||||
|
// 1s build-progress poll when the tab is hidden. The build keeps
|
||||||
|
// running server-side; the poll resumes and catches up on return.
|
||||||
|
// Battery-friendly (D8 follow-up).
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -266,7 +266,7 @@ function TaskDialog({
|
|||||||
confirmBusyLabel="Save action"
|
confirmBusyLabel="Save action"
|
||||||
secondaryAction={
|
secondaryAction={
|
||||||
onDelete ? (
|
onDelete ? (
|
||||||
<Button variant="destructive" onClick={onDelete}>
|
<Button variant="destructive" onClick={onDelete} className="mobile-touch-target">
|
||||||
Delete
|
Delete
|
||||||
</Button>
|
</Button>
|
||||||
) : undefined
|
) : undefined
|
||||||
@@ -367,7 +367,7 @@ export function Actions() {
|
|||||||
<Button
|
<Button
|
||||||
variant="outline"
|
variant="outline"
|
||||||
size="sm"
|
size="sm"
|
||||||
className="w-full"
|
className="mobile-touch-target w-full"
|
||||||
onClick={createNew}
|
onClick={createNew}
|
||||||
>
|
>
|
||||||
Add action
|
Add action
|
||||||
@@ -412,13 +412,13 @@ export function Actions() {
|
|||||||
description="Open the editor popup to modify this action."
|
description="Open the editor popup to modify this action."
|
||||||
action={
|
action={
|
||||||
<div className="flex flex-row flex-wrap items-center gap-2">
|
<div className="flex flex-row flex-wrap items-center gap-2">
|
||||||
<Button
|
<Button className="mobile-touch-target"
|
||||||
variant="outline"
|
variant="outline"
|
||||||
onClick={() => openEdit(initialFromTask(editingTask))}
|
onClick={() => openEdit(initialFromTask(editingTask))}
|
||||||
>
|
>
|
||||||
Edit
|
Edit
|
||||||
</Button>
|
</Button>
|
||||||
<Button
|
<Button className="mobile-touch-target"
|
||||||
disabled={runTask.isPending || !runServiceId}
|
disabled={runTask.isPending || !runServiceId}
|
||||||
onClick={async () => {
|
onClick={async () => {
|
||||||
await runTask.mutateAsync({
|
await runTask.mutateAsync({
|
||||||
@@ -515,7 +515,7 @@ export function Actions() {
|
|||||||
description="Select a saved action from the list on the left to view its details, run it, or open the editor popup. Use the button at the bottom to add a new action."
|
description="Select a saved action from the list on the left to view its details, run it, or open the editor popup. Use the button at the bottom to add a new action."
|
||||||
>
|
>
|
||||||
{tasks[0] && (
|
{tasks[0] && (
|
||||||
<Button variant="outline" onClick={() => setTab(tasks[0].id)}>
|
<Button variant="outline" onClick={() => setTab(tasks[0].id)} className="mobile-touch-target">
|
||||||
Select first action
|
Select first action
|
||||||
</Button>
|
</Button>
|
||||||
)}
|
)}
|
||||||
|
|||||||
@@ -354,6 +354,7 @@ function ShortcutDialog({
|
|||||||
<div className="flex items-center gap-2">
|
<div className="flex items-center gap-2">
|
||||||
<Switch
|
<Switch
|
||||||
id="shortcut-enabled"
|
id="shortcut-enabled"
|
||||||
|
className="mobile-touch-target"
|
||||||
checked={draft.enabled}
|
checked={draft.enabled}
|
||||||
onCheckedChange={(checked) =>
|
onCheckedChange={(checked) =>
|
||||||
onChange({ ...draft, enabled: checked })
|
onChange({ ...draft, enabled: checked })
|
||||||
@@ -424,13 +425,24 @@ function ShortcutCard({
|
|||||||
size="sm"
|
size="sm"
|
||||||
disabled={!shortcut.enabled || !href}
|
disabled={!shortcut.enabled || !href}
|
||||||
onClick={onOpen}
|
onClick={onOpen}
|
||||||
|
className="mobile-touch-target"
|
||||||
>
|
>
|
||||||
Open
|
Open
|
||||||
</Button>
|
</Button>
|
||||||
<Button size="sm" variant="outline" onClick={onEdit}>
|
<Button
|
||||||
|
size="sm"
|
||||||
|
variant="outline"
|
||||||
|
onClick={onEdit}
|
||||||
|
className="mobile-touch-target"
|
||||||
|
>
|
||||||
Edit
|
Edit
|
||||||
</Button>
|
</Button>
|
||||||
<Button size="sm" variant="destructive" onClick={onDelete}>
|
<Button
|
||||||
|
size="sm"
|
||||||
|
variant="destructive"
|
||||||
|
onClick={onDelete}
|
||||||
|
className="mobile-touch-target"
|
||||||
|
>
|
||||||
Delete
|
Delete
|
||||||
</Button>
|
</Button>
|
||||||
</div>
|
</div>
|
||||||
@@ -501,10 +513,18 @@ export function Dashboard() {
|
|||||||
description="Quick links to websites today, with room for action and user shortcuts later."
|
description="Quick links to websites today, with room for action and user shortcuts later."
|
||||||
action={
|
action={
|
||||||
<div className="flex gap-2">
|
<div className="flex gap-2">
|
||||||
<Button variant="outline" onClick={() => setWidgetDialogOpen(true)}>
|
<Button
|
||||||
|
variant="outline"
|
||||||
|
className="mobile-touch-target"
|
||||||
|
onClick={() => setWidgetDialogOpen(true)}
|
||||||
|
>
|
||||||
Edit dashboard
|
Edit dashboard
|
||||||
</Button>
|
</Button>
|
||||||
<Button variant="outline" onClick={openCreateShortcut}>
|
<Button
|
||||||
|
variant="outline"
|
||||||
|
className="mobile-touch-target"
|
||||||
|
onClick={openCreateShortcut}
|
||||||
|
>
|
||||||
Add shortcut
|
Add shortcut
|
||||||
</Button>
|
</Button>
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -718,14 +718,14 @@ export function FileBrowser() {
|
|||||||
<div className="flex flex-col gap-2 md:flex-row md:items-end">
|
<div className="flex flex-col gap-2 md:flex-row md:items-end">
|
||||||
<Button
|
<Button
|
||||||
variant="outline"
|
variant="outline"
|
||||||
className="w-full md:w-auto"
|
className="w-full md:w-auto mobile-touch-target"
|
||||||
onClick={() => navigate(pathInput || "/")}
|
onClick={() => navigate(pathInput || "/")}
|
||||||
>
|
>
|
||||||
Open
|
Open
|
||||||
</Button>
|
</Button>
|
||||||
<Button
|
<Button
|
||||||
variant="outline"
|
variant="outline"
|
||||||
className="w-full md:w-auto"
|
className="w-full md:w-auto mobile-touch-target"
|
||||||
onClick={() => refetch()}
|
onClick={() => refetch()}
|
||||||
>
|
>
|
||||||
Refresh
|
Refresh
|
||||||
@@ -837,7 +837,7 @@ export function FileBrowser() {
|
|||||||
</Select>
|
</Select>
|
||||||
</div>
|
</div>
|
||||||
<div className="flex flex-col gap-2 md:col-span-3 md:flex-row md:items-end">
|
<div className="flex flex-col gap-2 md:col-span-3 md:flex-row md:items-end">
|
||||||
<Button
|
<Button className="mobile-touch-target"
|
||||||
disabled={!selectedJob || runJob.isPending}
|
disabled={!selectedJob || runJob.isPending}
|
||||||
onClick={() =>
|
onClick={() =>
|
||||||
runJob.mutate({
|
runJob.mutate({
|
||||||
@@ -879,6 +879,7 @@ export function FileBrowser() {
|
|||||||
variant="outline"
|
variant="outline"
|
||||||
size="sm"
|
size="sm"
|
||||||
onClick={() => navigateToSettings("/settings")}
|
onClick={() => navigateToSettings("/settings")}
|
||||||
|
className="mobile-touch-target"
|
||||||
>
|
>
|
||||||
Open Settings
|
Open Settings
|
||||||
</Button>
|
</Button>
|
||||||
|
|||||||
@@ -13,6 +13,7 @@ import {
|
|||||||
MobileCardRow,
|
MobileCardRow,
|
||||||
type MobileCardField,
|
type MobileCardField,
|
||||||
} from "@/components/ui/mobile-card";
|
} from "@/components/ui/mobile-card";
|
||||||
|
import { TablePagination } from "@/components/ui/table-pagination";
|
||||||
import { Alert, AlertDescription } from "@/components/ui/alert";
|
import { Alert, AlertDescription } from "@/components/ui/alert";
|
||||||
import { Button } from "@/components/ui/button";
|
import { Button } from "@/components/ui/button";
|
||||||
import { Card, CardContent } from "@/components/ui/card";
|
import { Card, CardContent } from "@/components/ui/card";
|
||||||
@@ -100,95 +101,8 @@ const mediaCardFields: MobileCardField<MediaItem>[] = [
|
|||||||
},
|
},
|
||||||
];
|
];
|
||||||
|
|
||||||
// Standalone pagination for the mobile card layout. The DataTable renders its
|
// Mobile pagination uses the shared TablePagination component
|
||||||
// own pagination internally; this mirrors that UI (rows count, page-size
|
// (frontend/src/components/ui/table-pagination.tsx).
|
||||||
// select, page indicator, prev/next) but works off the raw pagination state
|
|
||||||
// instead of a TanStack table instance. See spec R3.3.
|
|
||||||
function MediaMobilePagination({
|
|
||||||
pageIndex,
|
|
||||||
pageSize,
|
|
||||||
pageSizeOptions,
|
|
||||||
totalRows,
|
|
||||||
pageCount,
|
|
||||||
onPaginationChange,
|
|
||||||
}: {
|
|
||||||
pageIndex: number;
|
|
||||||
pageSize: number;
|
|
||||||
pageSizeOptions: number[];
|
|
||||||
totalRows: number;
|
|
||||||
pageCount: number;
|
|
||||||
onPaginationChange: OnChangeFn<PaginationState>;
|
|
||||||
}) {
|
|
||||||
return (
|
|
||||||
<div className="flex flex-wrap items-center justify-between gap-3 p-4 text-sm">
|
|
||||||
<div className="text-muted-foreground">
|
|
||||||
{`${totalRows} row${totalRows === 1 ? "" : "s"}`}
|
|
||||||
</div>
|
|
||||||
<div className="flex items-center gap-3">
|
|
||||||
<div className="flex items-center gap-1.5">
|
|
||||||
<span className="text-muted-foreground">Rows per page</span>
|
|
||||||
<Select
|
|
||||||
value={String(pageSize)}
|
|
||||||
onValueChange={(value) =>
|
|
||||||
onPaginationChange(() => ({
|
|
||||||
pageIndex: 0,
|
|
||||||
pageSize: Number(value),
|
|
||||||
}))
|
|
||||||
}
|
|
||||||
>
|
|
||||||
<SelectTrigger
|
|
||||||
size="sm"
|
|
||||||
className="w-[70px]"
|
|
||||||
aria-label="Rows per page"
|
|
||||||
>
|
|
||||||
<SelectValue />
|
|
||||||
</SelectTrigger>
|
|
||||||
<SelectContent>
|
|
||||||
{pageSizeOptions.map((option) => (
|
|
||||||
<SelectItem key={option} value={String(option)}>
|
|
||||||
{option}
|
|
||||||
</SelectItem>
|
|
||||||
))}
|
|
||||||
</SelectContent>
|
|
||||||
</Select>
|
|
||||||
</div>
|
|
||||||
<span className="text-muted-foreground">
|
|
||||||
Page {pageIndex + 1} of {pageCount}
|
|
||||||
</span>
|
|
||||||
<div className="flex items-center gap-1">
|
|
||||||
<Button
|
|
||||||
variant="outline"
|
|
||||||
size="sm"
|
|
||||||
onClick={() =>
|
|
||||||
onPaginationChange((prev) => ({
|
|
||||||
...prev,
|
|
||||||
pageIndex: Math.max(0, prev.pageIndex - 1),
|
|
||||||
}))
|
|
||||||
}
|
|
||||||
disabled={pageIndex <= 0}
|
|
||||||
aria-label="Previous page"
|
|
||||||
>
|
|
||||||
Previous
|
|
||||||
</Button>
|
|
||||||
<Button
|
|
||||||
variant="outline"
|
|
||||||
size="sm"
|
|
||||||
onClick={() =>
|
|
||||||
onPaginationChange((prev) => ({
|
|
||||||
...prev,
|
|
||||||
pageIndex: prev.pageIndex + 1,
|
|
||||||
}))
|
|
||||||
}
|
|
||||||
disabled={pageIndex >= pageCount - 1}
|
|
||||||
aria-label="Next page"
|
|
||||||
>
|
|
||||||
Next
|
|
||||||
</Button>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
const MEDIA_TAB_STATE_KEY = "manage.media.tabState";
|
const MEDIA_TAB_STATE_KEY = "manage.media.tabState";
|
||||||
const SMALL_BREAKPOINT = "(max-width: 900px)";
|
const SMALL_BREAKPOINT = "(max-width: 900px)";
|
||||||
@@ -483,7 +397,7 @@ export function Media() {
|
|||||||
</p>
|
</p>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
<Button
|
<Button className="mobile-touch-target"
|
||||||
variant="outline"
|
variant="outline"
|
||||||
onClick={() => buildIndex.mutate()}
|
onClick={() => buildIndex.mutate()}
|
||||||
disabled={
|
disabled={
|
||||||
@@ -494,7 +408,7 @@ export function Media() {
|
|||||||
</Button>
|
</Button>
|
||||||
{buildRunning && (
|
{buildRunning && (
|
||||||
<>
|
<>
|
||||||
<Button
|
<Button className="mobile-touch-target"
|
||||||
variant="destructive"
|
variant="destructive"
|
||||||
onClick={() => stopBuildIndex.mutate()}
|
onClick={() => stopBuildIndex.mutate()}
|
||||||
disabled={stopBuildIndex.isPending || buildCancelRequested}
|
disabled={stopBuildIndex.isPending || buildCancelRequested}
|
||||||
@@ -505,7 +419,7 @@ export function Media() {
|
|||||||
</Button>
|
</Button>
|
||||||
<Button
|
<Button
|
||||||
variant="outline"
|
variant="outline"
|
||||||
className="border-chart-3/40 text-chart-3 hover:bg-chart-3/10"
|
className="border-chart-3/40 text-chart-3 hover:bg-chart-3/10 mobile-touch-target"
|
||||||
onClick={() => forceStopBuildIndex.mutate()}
|
onClick={() => forceStopBuildIndex.mutate()}
|
||||||
disabled={forceStopBuildIndex.isPending}
|
disabled={forceStopBuildIndex.isPending}
|
||||||
>
|
>
|
||||||
@@ -660,13 +574,14 @@ export function Media() {
|
|||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
{queryResult && (
|
{queryResult && (
|
||||||
<MediaMobilePagination
|
<TablePagination
|
||||||
pageIndex={pageIndex}
|
pageIndex={pageIndex}
|
||||||
pageSize={pageSize}
|
pageSize={pageSize}
|
||||||
pageSizeOptions={[50, 100, 200]}
|
pageSizeOptions={[50, 100, 200]}
|
||||||
totalRows={total}
|
totalRows={total}
|
||||||
pageCount={totalPages}
|
pageCount={totalPages}
|
||||||
onPaginationChange={handlePaginationChange}
|
onPaginationChange={handlePaginationChange}
|
||||||
|
className="p-4"
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
+233
-132
@@ -1,5 +1,5 @@
|
|||||||
import { useMemo, useState } from "react";
|
import { useMemo, useState } from "react";
|
||||||
import { useParams } from "react-router-dom";
|
import { useNavigate, useParams } from "react-router-dom";
|
||||||
import { Alert, AlertDescription } from "@/components/ui/alert";
|
import { Alert, AlertDescription } from "@/components/ui/alert";
|
||||||
import { Badge } from "@/components/ui/badge";
|
import { Badge } from "@/components/ui/badge";
|
||||||
import { Button } from "@/components/ui/button";
|
import { Button } from "@/components/ui/button";
|
||||||
@@ -12,6 +12,7 @@ import {
|
|||||||
useServiceInstances,
|
useServiceInstances,
|
||||||
useServiceTypes,
|
useServiceTypes,
|
||||||
} from "../hooks/useServices";
|
} from "../hooks/useServices";
|
||||||
|
import { useIsMobile } from "../hooks/useIsMobile";
|
||||||
import type {
|
import type {
|
||||||
ServiceInstance,
|
ServiceInstance,
|
||||||
ServiceInstanceInput,
|
ServiceInstanceInput,
|
||||||
@@ -19,6 +20,7 @@ import type {
|
|||||||
} from "../types";
|
} from "../types";
|
||||||
import { SectionCard } from "../components/SectionCard";
|
import { SectionCard } from "../components/SectionCard";
|
||||||
import { ConfirmDialog } from "../components/ConfirmDialog";
|
import { ConfirmDialog } from "../components/ConfirmDialog";
|
||||||
|
import { SheetForm } from "@/components/ui/sheet-form";
|
||||||
import { getServiceBinding } from "../integrations/registry";
|
import { getServiceBinding } from "../integrations/registry";
|
||||||
|
|
||||||
function Field({
|
function Field({
|
||||||
@@ -63,11 +65,17 @@ export function ServicePage() {
|
|||||||
[types, serviceType],
|
[types, serviceType],
|
||||||
);
|
);
|
||||||
|
|
||||||
|
const navigate = useNavigate();
|
||||||
const [name, setName] = useState("");
|
const [name, setName] = useState("");
|
||||||
const [enabled, setEnabled] = useState(true);
|
const [enabled, setEnabled] = useState(true);
|
||||||
const [draftConfig, setDraftConfig] = useState<Record<string, unknown>>({});
|
const [draftConfig, setDraftConfig] = useState<Record<string, unknown>>({});
|
||||||
const [deleteOpen, setDeleteOpen] = useState(false);
|
const [deleteOpen, setDeleteOpen] = useState(false);
|
||||||
const [hydrated, setHydrated] = useState(false);
|
const [hydrated, setHydrated] = useState(false);
|
||||||
|
const isMobile = useIsMobile();
|
||||||
|
// The mobile SheetForm opens by default when the page loads: this page is
|
||||||
|
// reached via /services/:serviceType/:serviceId, always editing an existing
|
||||||
|
// instance, so there is no separate "open edit" trigger on mobile.
|
||||||
|
const [sheetOpen, setSheetOpen] = useState(true);
|
||||||
|
|
||||||
// Hydrate local form state once the instance loads.
|
// Hydrate local form state once the instance loads.
|
||||||
if (instance && !hydrated) {
|
if (instance && !hydrated) {
|
||||||
@@ -106,6 +114,117 @@ export function ServicePage() {
|
|||||||
|
|
||||||
async function save() {
|
async function save() {
|
||||||
await saveService.mutateAsync(buildInput());
|
await saveService.mutateAsync(buildInput());
|
||||||
|
// R4.5: close the sheet on successful save and return to the services list
|
||||||
|
// (on mobile the sheet IS the page, so closing it would strand the user).
|
||||||
|
if (isMobile) {
|
||||||
|
setSheetOpen(false);
|
||||||
|
navigate("/services");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
const configFields = (
|
||||||
|
<ServiceConnectionFields
|
||||||
|
instance={instance}
|
||||||
|
typeInfo={typeInfo}
|
||||||
|
draftConfig={draftConfig}
|
||||||
|
onConfigChange={setDraftConfig}
|
||||||
|
isMobile={isMobile}
|
||||||
|
/>
|
||||||
|
);
|
||||||
|
|
||||||
|
const widgetsCard =
|
||||||
|
binding.widgets.length > 0 ? (
|
||||||
|
<SectionCard
|
||||||
|
title="Widgets"
|
||||||
|
description="Widget kinds this service provides."
|
||||||
|
>
|
||||||
|
<div className="flex flex-col gap-2">
|
||||||
|
{binding.widgets.map((w) => (
|
||||||
|
<div
|
||||||
|
key={w.kind}
|
||||||
|
className="flex items-center justify-between rounded border p-2"
|
||||||
|
>
|
||||||
|
<div>
|
||||||
|
<div className="font-medium">{w.name}</div>
|
||||||
|
<div className="text-xs text-muted-foreground">
|
||||||
|
{w.description}
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
<Badge variant="outline">{w.kind}</Badge>
|
||||||
|
</div>
|
||||||
|
))}
|
||||||
|
<p className="text-xs text-muted-foreground">
|
||||||
|
Add these to the dashboard from the dashboard's edit dialog.
|
||||||
|
</p>
|
||||||
|
</div>
|
||||||
|
</SectionCard>
|
||||||
|
) : null;
|
||||||
|
|
||||||
|
const confirmDelete = (
|
||||||
|
<ConfirmDialog
|
||||||
|
open={deleteOpen}
|
||||||
|
title="Delete service?"
|
||||||
|
message="This removes the service and any widgets that reference it. This cannot be undone."
|
||||||
|
confirmLabel="Delete"
|
||||||
|
onCancel={() => setDeleteOpen(false)}
|
||||||
|
onConfirm={() => {
|
||||||
|
deleteService.mutate(instance.id);
|
||||||
|
setDeleteOpen(false);
|
||||||
|
}}
|
||||||
|
/>
|
||||||
|
);
|
||||||
|
|
||||||
|
// Dirty when any editable field diverges from the persisted instance (mobile SheetForm R4.5 guard).
|
||||||
|
const isDirty =
|
||||||
|
name !== instance.name ||
|
||||||
|
enabled !== instance.enabled ||
|
||||||
|
JSON.stringify(draftConfig) !== JSON.stringify(instance.config);
|
||||||
|
|
||||||
|
if (isMobile) {
|
||||||
|
return (
|
||||||
|
<div className="flex flex-col gap-4">
|
||||||
|
<SheetForm
|
||||||
|
open={sheetOpen}
|
||||||
|
onOpenChange={setSheetOpen}
|
||||||
|
title={name || instance.name}
|
||||||
|
onSave={save}
|
||||||
|
onCancel={() => {
|
||||||
|
setSheetOpen(false);
|
||||||
|
navigate("/services");
|
||||||
|
}}
|
||||||
|
isPending={saveService.isPending}
|
||||||
|
isDirty={isDirty}
|
||||||
|
>
|
||||||
|
<div className="flex flex-col gap-6">
|
||||||
|
<Field label="Name" htmlFor="service-name">
|
||||||
|
<Input
|
||||||
|
id="service-name"
|
||||||
|
value={name}
|
||||||
|
onChange={(e) => setName(e.target.value)}
|
||||||
|
/>
|
||||||
|
</Field>
|
||||||
|
<div className="flex items-center gap-2">
|
||||||
|
<Switch
|
||||||
|
id="service-enabled"
|
||||||
|
checked={enabled}
|
||||||
|
onCheckedChange={setEnabled}
|
||||||
|
/>
|
||||||
|
<Label htmlFor="service-enabled">Enabled</Label>
|
||||||
|
</div>
|
||||||
|
{configFields}
|
||||||
|
<Button
|
||||||
|
className="mobile-touch-target"
|
||||||
|
variant="destructive"
|
||||||
|
onClick={() => setDeleteOpen(true)}
|
||||||
|
>
|
||||||
|
Delete service
|
||||||
|
</Button>
|
||||||
|
{widgetsCard}
|
||||||
|
</div>
|
||||||
|
</SheetForm>
|
||||||
|
{confirmDelete}
|
||||||
|
</div>
|
||||||
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
return (
|
return (
|
||||||
@@ -130,81 +249,52 @@ export function ServicePage() {
|
|||||||
<div className="flex items-center gap-2">
|
<div className="flex items-center gap-2">
|
||||||
<Switch
|
<Switch
|
||||||
id="service-enabled"
|
id="service-enabled"
|
||||||
|
className="mobile-touch-target"
|
||||||
checked={enabled}
|
checked={enabled}
|
||||||
onCheckedChange={setEnabled}
|
onCheckedChange={setEnabled}
|
||||||
/>
|
/>
|
||||||
<Label htmlFor="service-enabled">Enabled</Label>
|
<Label htmlFor="service-enabled">Enabled</Label>
|
||||||
</div>
|
</div>
|
||||||
<div className="flex justify-between">
|
<div className="flex justify-between">
|
||||||
<Button onClick={save} disabled={saveService.isPending}>
|
<Button
|
||||||
|
className="mobile-touch-target"
|
||||||
|
onClick={save}
|
||||||
|
disabled={saveService.isPending}
|
||||||
|
>
|
||||||
Save
|
Save
|
||||||
</Button>
|
</Button>
|
||||||
<Button variant="destructive" onClick={() => setDeleteOpen(true)}>
|
<Button
|
||||||
|
className="mobile-touch-target"
|
||||||
|
variant="destructive"
|
||||||
|
onClick={() => setDeleteOpen(true)}
|
||||||
|
>
|
||||||
Delete
|
Delete
|
||||||
</Button>
|
</Button>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
</SectionCard>
|
</SectionCard>
|
||||||
|
|
||||||
<ServiceConnectionCard
|
{configFields}
|
||||||
instance={instance}
|
|
||||||
typeInfo={typeInfo}
|
|
||||||
draftConfig={draftConfig}
|
|
||||||
onConfigChange={setDraftConfig}
|
|
||||||
/>
|
|
||||||
|
|
||||||
{binding.widgets.length > 0 ? (
|
{widgetsCard}
|
||||||
<SectionCard
|
|
||||||
title="Widgets"
|
|
||||||
description="Widget kinds this service provides."
|
|
||||||
>
|
|
||||||
<div className="flex flex-col gap-2">
|
|
||||||
{binding.widgets.map((w) => (
|
|
||||||
<div
|
|
||||||
key={w.kind}
|
|
||||||
className="flex items-center justify-between rounded border p-2"
|
|
||||||
>
|
|
||||||
<div>
|
|
||||||
<div className="font-medium">{w.name}</div>
|
|
||||||
<div className="text-xs text-muted-foreground">
|
|
||||||
{w.description}
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
<Badge variant="outline">{w.kind}</Badge>
|
|
||||||
</div>
|
|
||||||
))}
|
|
||||||
<p className="text-xs text-muted-foreground">
|
|
||||||
Add these to the dashboard from the dashboard's edit dialog.
|
|
||||||
</p>
|
|
||||||
</div>
|
|
||||||
</SectionCard>
|
|
||||||
) : null}
|
|
||||||
|
|
||||||
<ConfirmDialog
|
{confirmDelete}
|
||||||
open={deleteOpen}
|
|
||||||
title="Delete service?"
|
|
||||||
message="This removes the service and any widgets that reference it. This cannot be undone."
|
|
||||||
confirmLabel="Delete"
|
|
||||||
onCancel={() => setDeleteOpen(false)}
|
|
||||||
onConfirm={() => {
|
|
||||||
deleteService.mutate(instance.id);
|
|
||||||
setDeleteOpen(false);
|
|
||||||
}}
|
|
||||||
/>
|
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
function ServiceConnectionCard({
|
function ServiceConnectionFields({
|
||||||
instance,
|
instance,
|
||||||
typeInfo,
|
typeInfo,
|
||||||
draftConfig,
|
draftConfig,
|
||||||
onConfigChange,
|
onConfigChange,
|
||||||
|
isMobile,
|
||||||
}: {
|
}: {
|
||||||
instance: ServiceInstance;
|
instance: ServiceInstance;
|
||||||
typeInfo: ServiceTypeInfo | undefined;
|
typeInfo: ServiceTypeInfo | undefined;
|
||||||
draftConfig: Record<string, unknown>;
|
draftConfig: Record<string, unknown>;
|
||||||
onConfigChange: (config: Record<string, unknown>) => void;
|
onConfigChange: (config: Record<string, unknown>) => void;
|
||||||
|
isMobile: boolean;
|
||||||
}) {
|
}) {
|
||||||
const saveService = useSaveServiceInstance();
|
const saveService = useSaveServiceInstance();
|
||||||
// Empty-on-edit: local state starts blank; a blank field means "keep existing".
|
// Empty-on-edit: local state starts blank; a blank field means "keep existing".
|
||||||
@@ -232,96 +322,107 @@ function ServiceConnectionCard({
|
|||||||
{ type: typeof value === "number" ? "integer" : "string" },
|
{ type: typeof value === "number" ? "integer" : "string" },
|
||||||
]);
|
]);
|
||||||
|
|
||||||
|
function handleUpdateConnection() {
|
||||||
|
const onlyChanged = Object.fromEntries(
|
||||||
|
Object.entries(draftSecrets).filter(([, v]) => v !== ""),
|
||||||
|
);
|
||||||
|
saveService.mutate({
|
||||||
|
id: instance.id,
|
||||||
|
service_type: instance.service_type,
|
||||||
|
name: instance.name,
|
||||||
|
config: draftConfig,
|
||||||
|
secrets: onlyChanged,
|
||||||
|
enabled: instance.enabled,
|
||||||
|
});
|
||||||
|
setDraftSecrets({});
|
||||||
|
}
|
||||||
|
|
||||||
|
const fields = (
|
||||||
|
<div className="flex flex-col gap-3">
|
||||||
|
{configEntries.length === 0 ? (
|
||||||
|
<p className="text-sm text-muted-foreground">No connection config.</p>
|
||||||
|
) : (
|
||||||
|
<div className="flex flex-col gap-3">
|
||||||
|
{configEntries.map(([key, schema]) => {
|
||||||
|
const isNumber =
|
||||||
|
schema.type === "integer" || schema.type === "number";
|
||||||
|
return (
|
||||||
|
<Field
|
||||||
|
key={key}
|
||||||
|
label={key}
|
||||||
|
htmlFor={`cfg-${key}`}
|
||||||
|
helper={schema.description}
|
||||||
|
>
|
||||||
|
<Input
|
||||||
|
id={`cfg-${key}`}
|
||||||
|
type={isNumber ? "number" : "text"}
|
||||||
|
value={String(draftConfig[key] ?? "")}
|
||||||
|
onChange={(e) =>
|
||||||
|
onConfigChange({
|
||||||
|
...draftConfig,
|
||||||
|
[key]: isNumber
|
||||||
|
? e.target.value === ""
|
||||||
|
? undefined
|
||||||
|
: Number(e.target.value)
|
||||||
|
: e.target.value,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
/>
|
||||||
|
</Field>
|
||||||
|
);
|
||||||
|
})}
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
|
||||||
|
{Object.keys(instance.secrets_set).length === 0 ? (
|
||||||
|
<p className="text-sm text-muted-foreground">No secret fields.</p>
|
||||||
|
) : (
|
||||||
|
<div className="flex flex-col gap-3">
|
||||||
|
{Object.entries(instance.secrets_set).map(([key, isSet]) => (
|
||||||
|
<div key={key} className="flex flex-col gap-1.5">
|
||||||
|
<Field
|
||||||
|
label={key}
|
||||||
|
htmlFor={`secret-${key}`}
|
||||||
|
helper="Leave blank to keep the current value."
|
||||||
|
>
|
||||||
|
<Input
|
||||||
|
id={`secret-${key}`}
|
||||||
|
type="password"
|
||||||
|
placeholder={isSet ? "•••••• (set)" : "Not set"}
|
||||||
|
value={draftSecrets[key] ?? ""}
|
||||||
|
onChange={(e) =>
|
||||||
|
setDraftSecrets({
|
||||||
|
...draftSecrets,
|
||||||
|
[key]: e.target.value,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
/>
|
||||||
|
</Field>
|
||||||
|
{isSet ? <Badge variant="secondary">set</Badge> : null}
|
||||||
|
</div>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
|
||||||
|
<Button className="mobile-touch-target" onClick={handleUpdateConnection}>
|
||||||
|
Update connection
|
||||||
|
</Button>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
|
||||||
|
// On mobile the fields render inside the SheetForm body without a card
|
||||||
|
// wrapper (the SheetForm already provides the container). On desktop they
|
||||||
|
// keep their original SectionCard framing.
|
||||||
|
if (isMobile) {
|
||||||
|
return <div className="flex flex-col gap-3">{fields}</div>;
|
||||||
|
}
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<SectionCard
|
<SectionCard
|
||||||
title="Connection"
|
title="Connection"
|
||||||
description="Edit non-secret connection config and secret values."
|
description="Edit non-secret connection config and secret values."
|
||||||
>
|
>
|
||||||
<div className="flex flex-col gap-3">
|
{fields}
|
||||||
{configEntries.length === 0 ? (
|
|
||||||
<p className="text-sm text-muted-foreground">No connection config.</p>
|
|
||||||
) : (
|
|
||||||
<div className="flex flex-col gap-3">
|
|
||||||
{configEntries.map(([key, schema]) => {
|
|
||||||
const isNumber =
|
|
||||||
schema.type === "integer" || schema.type === "number";
|
|
||||||
return (
|
|
||||||
<Field
|
|
||||||
key={key}
|
|
||||||
label={key}
|
|
||||||
htmlFor={`cfg-${key}`}
|
|
||||||
helper={schema.description}
|
|
||||||
>
|
|
||||||
<Input
|
|
||||||
id={`cfg-${key}`}
|
|
||||||
type={isNumber ? "number" : "text"}
|
|
||||||
value={String(draftConfig[key] ?? "")}
|
|
||||||
onChange={(e) =>
|
|
||||||
onConfigChange({
|
|
||||||
...draftConfig,
|
|
||||||
[key]: isNumber
|
|
||||||
? e.target.value === ""
|
|
||||||
? undefined
|
|
||||||
: Number(e.target.value)
|
|
||||||
: e.target.value,
|
|
||||||
})
|
|
||||||
}
|
|
||||||
/>
|
|
||||||
</Field>
|
|
||||||
);
|
|
||||||
})}
|
|
||||||
</div>
|
|
||||||
)}
|
|
||||||
|
|
||||||
{Object.keys(instance.secrets_set).length === 0 ? (
|
|
||||||
<p className="text-sm text-muted-foreground">No secret fields.</p>
|
|
||||||
) : (
|
|
||||||
<div className="flex flex-col gap-3">
|
|
||||||
{Object.entries(instance.secrets_set).map(([key, isSet]) => (
|
|
||||||
<div key={key} className="flex flex-col gap-1.5">
|
|
||||||
<Field
|
|
||||||
label={key}
|
|
||||||
htmlFor={`secret-${key}`}
|
|
||||||
helper="Leave blank to keep the current value."
|
|
||||||
>
|
|
||||||
<Input
|
|
||||||
id={`secret-${key}`}
|
|
||||||
type="password"
|
|
||||||
placeholder={isSet ? "•••••• (set)" : "Not set"}
|
|
||||||
value={draftSecrets[key] ?? ""}
|
|
||||||
onChange={(e) =>
|
|
||||||
setDraftSecrets({
|
|
||||||
...draftSecrets,
|
|
||||||
[key]: e.target.value,
|
|
||||||
})
|
|
||||||
}
|
|
||||||
/>
|
|
||||||
</Field>
|
|
||||||
{isSet ? <Badge variant="secondary">set</Badge> : null}
|
|
||||||
</div>
|
|
||||||
))}
|
|
||||||
</div>
|
|
||||||
)}
|
|
||||||
|
|
||||||
<Button
|
|
||||||
onClick={() => {
|
|
||||||
const onlyChanged = Object.fromEntries(
|
|
||||||
Object.entries(draftSecrets).filter(([, v]) => v !== ""),
|
|
||||||
);
|
|
||||||
saveService.mutate({
|
|
||||||
id: instance.id,
|
|
||||||
service_type: instance.service_type,
|
|
||||||
name: instance.name,
|
|
||||||
config: draftConfig,
|
|
||||||
secrets: onlyChanged,
|
|
||||||
enabled: instance.enabled,
|
|
||||||
});
|
|
||||||
setDraftSecrets({});
|
|
||||||
}}
|
|
||||||
>
|
|
||||||
Update connection
|
|
||||||
</Button>
|
|
||||||
</div>
|
|
||||||
</SectionCard>
|
</SectionCard>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -195,7 +195,7 @@ function CreateServiceDialog({
|
|||||||
{!draft ? (
|
{!draft ? (
|
||||||
<div className="flex flex-col gap-2">
|
<div className="flex flex-col gap-2">
|
||||||
{types.map((t) => (
|
{types.map((t) => (
|
||||||
<Button
|
<Button className="mobile-touch-target"
|
||||||
key={t.service_type}
|
key={t.service_type}
|
||||||
variant="outline"
|
variant="outline"
|
||||||
onClick={() => setDraft(emptyDraft(t.service_type))}
|
onClick={() => setDraft(emptyDraft(t.service_type))}
|
||||||
@@ -234,6 +234,7 @@ function CreateServiceDialog({
|
|||||||
<div className="flex items-center gap-2">
|
<div className="flex items-center gap-2">
|
||||||
<Switch
|
<Switch
|
||||||
id="service-enabled"
|
id="service-enabled"
|
||||||
|
className="mobile-touch-target"
|
||||||
checked={draft.enabled}
|
checked={draft.enabled}
|
||||||
onCheckedChange={(checked) =>
|
onCheckedChange={(checked) =>
|
||||||
setDraft({ ...draft, enabled: checked })
|
setDraft({ ...draft, enabled: checked })
|
||||||
@@ -286,7 +287,7 @@ export function ServicesPage() {
|
|||||||
title="Services"
|
title="Services"
|
||||||
description="External services the app talks to. Configure URLs and API keys here; they are encrypted at rest."
|
description="External services the app talks to. Configure URLs and API keys here; they are encrypted at rest."
|
||||||
action={
|
action={
|
||||||
<Button variant="outline" onClick={() => setCreateOpen(true)}>
|
<Button variant="outline" onClick={() => setCreateOpen(true)} className="mobile-touch-target">
|
||||||
<Plus className="mr-1 h-3 w-3" />
|
<Plus className="mr-1 h-3 w-3" />
|
||||||
Add service
|
Add service
|
||||||
</Button>
|
</Button>
|
||||||
@@ -328,6 +329,7 @@ export function ServicesPage() {
|
|||||||
<Button
|
<Button
|
||||||
variant="ghost"
|
variant="ghost"
|
||||||
size="sm"
|
size="sm"
|
||||||
|
className="mobile-touch-target"
|
||||||
onClick={() =>
|
onClick={() =>
|
||||||
navigate(`/services/${s.service_type}/${s.id}`)
|
navigate(`/services/${s.service_type}/${s.id}`)
|
||||||
}
|
}
|
||||||
@@ -337,7 +339,7 @@ export function ServicesPage() {
|
|||||||
<Button
|
<Button
|
||||||
variant="ghost"
|
variant="ghost"
|
||||||
size="icon"
|
size="icon"
|
||||||
className="h-8 w-8 text-destructive"
|
className="mobile-touch-target h-8 w-8 text-destructive"
|
||||||
onClick={() => setDeleteId(s.id)}
|
onClick={() => setDeleteId(s.id)}
|
||||||
>
|
>
|
||||||
<Trash2 className="h-4 w-4" />
|
<Trash2 className="h-4 w-4" />
|
||||||
|
|||||||
+144
-45
@@ -17,6 +17,8 @@ import {
|
|||||||
useSaveSSHKey,
|
useSaveSSHKey,
|
||||||
useTestMonitoringMachineSSH,
|
useTestMonitoringMachineSSH,
|
||||||
} from "../hooks/useSettings";
|
} from "../hooks/useSettings";
|
||||||
|
import { useIsMobile } from "../hooks/useIsMobile";
|
||||||
|
import { SheetForm } from "@/components/ui/sheet-form";
|
||||||
import { DialogFooter } from "../components/DialogFooter";
|
import { DialogFooter } from "../components/DialogFooter";
|
||||||
import { HoverEditButton } from "../components/HoverEditButton";
|
import { HoverEditButton } from "../components/HoverEditButton";
|
||||||
import { SectionCard } from "../components/SectionCard";
|
import { SectionCard } from "../components/SectionCard";
|
||||||
@@ -126,6 +128,30 @@ function emptyMachine(
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Dirty check for the machine editor SheetForm guard (spec R4.5).
|
||||||
|
* Pragmatic field-by-field comparison of the user-editable fields. In create
|
||||||
|
* mode (editingMachine is null) the form is always dirty.
|
||||||
|
*/
|
||||||
|
function isMachineDraftDirty(
|
||||||
|
draft: MonitoringMachineInput,
|
||||||
|
editingMachine: MonitoringMachine | null,
|
||||||
|
): boolean {
|
||||||
|
if (!editingMachine) return true;
|
||||||
|
return (
|
||||||
|
draft.name !== editingMachine.name ||
|
||||||
|
draft.host !== editingMachine.host ||
|
||||||
|
draft.mode !== editingMachine.mode ||
|
||||||
|
draft.port !== editingMachine.port ||
|
||||||
|
draft.username !== editingMachine.username ||
|
||||||
|
draft.ssh_key_id !== editingMachine.ssh_key_id ||
|
||||||
|
draft.enabled !== editingMachine.enabled ||
|
||||||
|
draft.notes !== editingMachine.notes ||
|
||||||
|
JSON.stringify([...draft.services].sort()) !==
|
||||||
|
JSON.stringify([...editingMachine.services].sort())
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
function MachineEditor({
|
function MachineEditor({
|
||||||
title,
|
title,
|
||||||
hint,
|
hint,
|
||||||
@@ -230,6 +256,7 @@ function MachineEditor({
|
|||||||
<div className="flex items-center gap-2">
|
<div className="flex items-center gap-2">
|
||||||
<Switch
|
<Switch
|
||||||
id="machine-enabled"
|
id="machine-enabled"
|
||||||
|
className="mobile-touch-target"
|
||||||
checked={draft.enabled}
|
checked={draft.enabled}
|
||||||
onCheckedChange={(checked) =>
|
onCheckedChange={(checked) =>
|
||||||
setDraft((current) => ({ ...current, enabled: checked }))
|
setDraft((current) => ({ ...current, enabled: checked }))
|
||||||
@@ -439,6 +466,7 @@ function MachineEditor({
|
|||||||
</Alert>
|
</Alert>
|
||||||
<div className="flex flex-row flex-wrap items-center gap-2">
|
<div className="flex flex-row flex-wrap items-center gap-2">
|
||||||
<Button
|
<Button
|
||||||
|
className="mobile-touch-target"
|
||||||
variant="outline"
|
variant="outline"
|
||||||
onClick={onValidateSSH}
|
onClick={onValidateSSH}
|
||||||
disabled={
|
disabled={
|
||||||
@@ -532,7 +560,7 @@ function SSHKeyManager({
|
|||||||
<Button
|
<Button
|
||||||
variant="outline"
|
variant="outline"
|
||||||
size="sm"
|
size="sm"
|
||||||
className="w-full"
|
className="mobile-touch-target w-full"
|
||||||
onClick={() => {
|
onClick={() => {
|
||||||
clear();
|
clear();
|
||||||
}}
|
}}
|
||||||
@@ -651,6 +679,7 @@ function SSHKeyManager({
|
|||||||
</div>
|
</div>
|
||||||
<div className="flex flex-row flex-wrap items-center gap-2">
|
<div className="flex flex-row flex-wrap items-center gap-2">
|
||||||
<Button
|
<Button
|
||||||
|
className="mobile-touch-target"
|
||||||
disabled={saveKey.isPending}
|
disabled={saveKey.isPending}
|
||||||
onClick={async () => {
|
onClick={async () => {
|
||||||
await saveKey.mutateAsync(draft);
|
await saveKey.mutateAsync(draft);
|
||||||
@@ -660,6 +689,7 @@ function SSHKeyManager({
|
|||||||
{editing ? "Update key" : "Save key"}
|
{editing ? "Update key" : "Save key"}
|
||||||
</Button>
|
</Button>
|
||||||
<Button
|
<Button
|
||||||
|
className="mobile-touch-target"
|
||||||
variant="outline"
|
variant="outline"
|
||||||
disabled={generateKey.isPending}
|
disabled={generateKey.isPending}
|
||||||
onClick={async () => {
|
onClick={async () => {
|
||||||
@@ -683,11 +713,16 @@ function SSHKeyManager({
|
|||||||
>
|
>
|
||||||
{generateKey.isPending ? "Generating..." : "Generate key"}
|
{generateKey.isPending ? "Generating..." : "Generate key"}
|
||||||
</Button>
|
</Button>
|
||||||
<Button variant="outline" onClick={clear}>
|
<Button
|
||||||
|
variant="outline"
|
||||||
|
onClick={clear}
|
||||||
|
className="mobile-touch-target"
|
||||||
|
>
|
||||||
Clear
|
Clear
|
||||||
</Button>
|
</Button>
|
||||||
{selectedKey && (
|
{selectedKey && (
|
||||||
<Button
|
<Button
|
||||||
|
className="mobile-touch-target"
|
||||||
variant="destructive"
|
variant="destructive"
|
||||||
onClick={() => deleteKey.mutate(selectedKey.id)}
|
onClick={() => deleteKey.mutate(selectedKey.id)}
|
||||||
>
|
>
|
||||||
@@ -753,7 +788,11 @@ function ResetLocalDatabaseCard() {
|
|||||||
Reset the local SQLite settings/media index databases after
|
Reset the local SQLite settings/media index databases after
|
||||||
acknowledging the data loss.
|
acknowledging the data loss.
|
||||||
</p>
|
</p>
|
||||||
<Button variant="destructive" onClick={() => setOpen(true)}>
|
<Button
|
||||||
|
variant="destructive"
|
||||||
|
onClick={() => setOpen(true)}
|
||||||
|
className="mobile-touch-target"
|
||||||
|
>
|
||||||
Reset local database
|
Reset local database
|
||||||
</Button>
|
</Button>
|
||||||
{resetDatabase.error && (
|
{resetDatabase.error && (
|
||||||
@@ -780,6 +819,7 @@ function ResetLocalDatabaseCard() {
|
|||||||
<div className="flex flex-col gap-3">
|
<div className="flex flex-col gap-3">
|
||||||
<label className="flex items-center gap-2 text-sm">
|
<label className="flex items-center gap-2 text-sm">
|
||||||
<Checkbox
|
<Checkbox
|
||||||
|
className="mobile-touch-target"
|
||||||
checked={ackSettings}
|
checked={ackSettings}
|
||||||
onCheckedChange={(checked) => setAckSettings(Boolean(checked))}
|
onCheckedChange={(checked) => setAckSettings(Boolean(checked))}
|
||||||
/>
|
/>
|
||||||
@@ -787,6 +827,7 @@ function ResetLocalDatabaseCard() {
|
|||||||
</label>
|
</label>
|
||||||
<label className="flex items-center gap-2 text-sm">
|
<label className="flex items-center gap-2 text-sm">
|
||||||
<Checkbox
|
<Checkbox
|
||||||
|
className="mobile-touch-target"
|
||||||
checked={ackIndex}
|
checked={ackIndex}
|
||||||
onCheckedChange={(checked) => setAckIndex(Boolean(checked))}
|
onCheckedChange={(checked) => setAckIndex(Boolean(checked))}
|
||||||
/>
|
/>
|
||||||
@@ -794,6 +835,7 @@ function ResetLocalDatabaseCard() {
|
|||||||
</label>
|
</label>
|
||||||
<label className="flex items-center gap-2 text-sm">
|
<label className="flex items-center gap-2 text-sm">
|
||||||
<Checkbox
|
<Checkbox
|
||||||
|
className="mobile-touch-target"
|
||||||
checked={ackIrreversible}
|
checked={ackIrreversible}
|
||||||
onCheckedChange={(checked) =>
|
onCheckedChange={(checked) =>
|
||||||
setAckIrreversible(Boolean(checked))
|
setAckIrreversible(Boolean(checked))
|
||||||
@@ -850,6 +892,7 @@ export function Settings() {
|
|||||||
const [editingMachine, setEditingMachine] =
|
const [editingMachine, setEditingMachine] =
|
||||||
useState<MonitoringMachine | null>(null);
|
useState<MonitoringMachine | null>(null);
|
||||||
const [selectedMachineId, setSelectedMachineId] = useState("");
|
const [selectedMachineId, setSelectedMachineId] = useState("");
|
||||||
|
const isMobile = useIsMobile();
|
||||||
const orderedMachines = useMemo(() => machines ?? [], [machines]);
|
const orderedMachines = useMemo(() => machines ?? [], [machines]);
|
||||||
const selectedMachine = useMemo(
|
const selectedMachine = useMemo(
|
||||||
() =>
|
() =>
|
||||||
@@ -970,7 +1013,7 @@ export function Settings() {
|
|||||||
<Button
|
<Button
|
||||||
variant="outline"
|
variant="outline"
|
||||||
size="sm"
|
size="sm"
|
||||||
className="w-full"
|
className="mobile-touch-target w-full"
|
||||||
onClick={() => {
|
onClick={() => {
|
||||||
clearSSHValidation();
|
clearSSHValidation();
|
||||||
setMachineDraft(emptyMachine("local"));
|
setMachineDraft(emptyMachine("local"));
|
||||||
@@ -1086,6 +1129,7 @@ export function Settings() {
|
|||||||
</div>
|
</div>
|
||||||
<div className="flex flex-row flex-wrap items-center gap-2">
|
<div className="flex flex-row flex-wrap items-center gap-2">
|
||||||
<Button
|
<Button
|
||||||
|
className="mobile-touch-target"
|
||||||
variant="outline"
|
variant="outline"
|
||||||
onClick={() =>
|
onClick={() =>
|
||||||
openEditMachine(
|
openEditMachine(
|
||||||
@@ -1113,6 +1157,7 @@ export function Settings() {
|
|||||||
Edit
|
Edit
|
||||||
</Button>
|
</Button>
|
||||||
<Button
|
<Button
|
||||||
|
className="mobile-touch-target"
|
||||||
variant="destructive"
|
variant="destructive"
|
||||||
onClick={() => setDeleteMachineId(selectedMachine.id)}
|
onClick={() => setDeleteMachineId(selectedMachine.id)}
|
||||||
>
|
>
|
||||||
@@ -1135,21 +1180,25 @@ export function Settings() {
|
|||||||
)}
|
)}
|
||||||
{tab === "danger" && <ResetLocalDatabaseCard />}
|
{tab === "danger" && <ResetLocalDatabaseCard />}
|
||||||
</TabbedCard>
|
</TabbedCard>
|
||||||
<Dialog
|
{isMobile ? (
|
||||||
open={machineDialogOpen}
|
<SheetForm
|
||||||
onOpenChange={(open) => {
|
open={machineDialogOpen}
|
||||||
if (!open) closeMachineDialog();
|
onOpenChange={(open) => {
|
||||||
}}
|
if (!open) closeMachineDialog();
|
||||||
>
|
}}
|
||||||
<DialogContent className="sm:max-w-4xl">
|
title={machineDraft.id ? "Edit machine" : "Create machine"}
|
||||||
<DialogHeader>
|
onSave={() => {
|
||||||
<DialogTitle>
|
void saveMachineDraft(machineDraft);
|
||||||
{machineDraft.id ? "Edit machine" : "Create machine"}
|
}}
|
||||||
</DialogTitle>
|
onCancel={closeMachineDialog}
|
||||||
<DialogDescription>
|
isPending={saveMachine.isPending}
|
||||||
{machineDraft.mode === "local" ? "Local API host" : "SSH target"}
|
saveDisabled={
|
||||||
</DialogDescription>
|
!machineDraft.name ||
|
||||||
</DialogHeader>
|
(machineDraft.mode === "ssh" && !machineDraft.host.trim())
|
||||||
|
}
|
||||||
|
saveLabel={machineDraft.id ? "Save machine" : "Create machine"}
|
||||||
|
isDirty={isMachineDraftDirty(machineDraft, editingMachine)}
|
||||||
|
>
|
||||||
<MachineEditor
|
<MachineEditor
|
||||||
key={`${machineDraft.id ?? machineDraft.mode}-${machineDraft.mode}`}
|
key={`${machineDraft.id ?? machineDraft.mode}-${machineDraft.mode}`}
|
||||||
title={
|
title={
|
||||||
@@ -1170,32 +1219,82 @@ export function Settings() {
|
|||||||
sshValidationError={sshValidationError}
|
sshValidationError={sshValidationError}
|
||||||
sshValidationStatus={sshValidationStatus}
|
sshValidationStatus={sshValidationStatus}
|
||||||
/>
|
/>
|
||||||
<DialogFooter
|
{machineDraft.id ? (
|
||||||
onCancel={closeMachineDialog}
|
<Button
|
||||||
cancelLabel="Cancel"
|
className="mobile-touch-target"
|
||||||
onConfirm={() => {
|
variant="destructive"
|
||||||
void saveMachineDraft(machineDraft);
|
onClick={() => setDeleteMachineId(machineDraft.id as string)}
|
||||||
}}
|
>
|
||||||
confirmLabel={machineDraft.id ? "Save machine" : "Create machine"}
|
Delete machine
|
||||||
confirmDisabled={
|
</Button>
|
||||||
!machineDraft.name ||
|
) : null}
|
||||||
(machineDraft.mode === "ssh" && !machineDraft.host.trim())
|
</SheetForm>
|
||||||
}
|
) : (
|
||||||
secondaryAction={
|
<Dialog
|
||||||
machineDraft.id ? (
|
open={machineDialogOpen}
|
||||||
<Button
|
onOpenChange={(open) => {
|
||||||
variant="destructive"
|
if (!open) closeMachineDialog();
|
||||||
onClick={() => {
|
}}
|
||||||
setDeleteMachineId(machineDraft.id as string);
|
>
|
||||||
}}
|
<DialogContent className="sm:max-w-4xl">
|
||||||
>
|
<DialogHeader>
|
||||||
Delete
|
<DialogTitle>
|
||||||
</Button>
|
{machineDraft.id ? "Edit machine" : "Create machine"}
|
||||||
) : undefined
|
</DialogTitle>
|
||||||
}
|
<DialogDescription>
|
||||||
/>
|
{machineDraft.mode === "local"
|
||||||
</DialogContent>
|
? "Local API host"
|
||||||
</Dialog>
|
: "SSH target"}
|
||||||
|
</DialogDescription>
|
||||||
|
</DialogHeader>
|
||||||
|
<MachineEditor
|
||||||
|
key={`${machineDraft.id ?? machineDraft.mode}-${machineDraft.mode}`}
|
||||||
|
title={
|
||||||
|
machineDraft.id
|
||||||
|
? machineDraft.name || "Edit machine"
|
||||||
|
: "New machine"
|
||||||
|
}
|
||||||
|
hint={
|
||||||
|
machineDraft.mode === "local" ? "Local API host" : "SSH target"
|
||||||
|
}
|
||||||
|
machine={machineDraft}
|
||||||
|
sshKeys={sshKeys}
|
||||||
|
editingMachine={editingMachine}
|
||||||
|
onChange={updateMachineDraft}
|
||||||
|
onValidateSSH={validateMachineSSH}
|
||||||
|
isValidatingSSH={testMachineSSH.isPending}
|
||||||
|
sshValidationMessage={sshValidationMessage}
|
||||||
|
sshValidationError={sshValidationError}
|
||||||
|
sshValidationStatus={sshValidationStatus}
|
||||||
|
/>
|
||||||
|
<DialogFooter
|
||||||
|
onCancel={closeMachineDialog}
|
||||||
|
cancelLabel="Cancel"
|
||||||
|
onConfirm={() => {
|
||||||
|
void saveMachineDraft(machineDraft);
|
||||||
|
}}
|
||||||
|
confirmLabel={machineDraft.id ? "Save machine" : "Create machine"}
|
||||||
|
confirmDisabled={
|
||||||
|
!machineDraft.name ||
|
||||||
|
(machineDraft.mode === "ssh" && !machineDraft.host.trim())
|
||||||
|
}
|
||||||
|
secondaryAction={
|
||||||
|
machineDraft.id ? (
|
||||||
|
<Button
|
||||||
|
className="mobile-touch-target"
|
||||||
|
variant="destructive"
|
||||||
|
onClick={() => {
|
||||||
|
setDeleteMachineId(machineDraft.id as string);
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Delete
|
||||||
|
</Button>
|
||||||
|
) : undefined
|
||||||
|
}
|
||||||
|
/>
|
||||||
|
</DialogContent>
|
||||||
|
</Dialog>
|
||||||
|
)}
|
||||||
<ConfirmDialog
|
<ConfirmDialog
|
||||||
open={Boolean(deleteMachineId)}
|
open={Boolean(deleteMachineId)}
|
||||||
title="Delete machine?"
|
title="Delete machine?"
|
||||||
|
|||||||
@@ -40,6 +40,7 @@ import {
|
|||||||
TooltipTrigger,
|
TooltipTrigger,
|
||||||
} from "@/components/ui/tooltip";
|
} from "@/components/ui/tooltip";
|
||||||
import { Sheet, SheetContent } from "@/components/ui/sheet";
|
import { Sheet, SheetContent } from "@/components/ui/sheet";
|
||||||
|
import { SheetForm } from "@/components/ui/sheet-form";
|
||||||
import {
|
import {
|
||||||
Table,
|
Table,
|
||||||
TableBody,
|
TableBody,
|
||||||
@@ -813,229 +814,271 @@ export function UsersPage() {
|
|||||||
</SheetContent>
|
</SheetContent>
|
||||||
</Sheet>
|
</Sheet>
|
||||||
|
|
||||||
<Dialog
|
{/* Compose dialog: SheetForm below md, Dialog at md+ (spec R4.1) */}
|
||||||
open={composeOpen}
|
{(() => {
|
||||||
onOpenChange={(open) => {
|
const composeBody = (
|
||||||
if (!open) {
|
<>
|
||||||
closeCompose();
|
{sendUserMessage.isPending ? (
|
||||||
}
|
<Progress value={100} className="animate-pulse" />
|
||||||
}}
|
|
||||||
>
|
|
||||||
<DialogContent
|
|
||||||
className={cn(
|
|
||||||
"flex max-h-[90dvh] flex-col gap-0 overflow-hidden p-0 sm:max-w-2xl",
|
|
||||||
isComposeMobile &&
|
|
||||||
"inset-0 max-h-none max-w-none translate-x-0 translate-y-0 rounded-none",
|
|
||||||
)}
|
|
||||||
>
|
|
||||||
<DialogHeader className="gap-1 px-4 pt-4">
|
|
||||||
<DialogTitle className="pr-8">Message selected users</DialogTitle>
|
|
||||||
<DialogDescription className="sr-only">
|
|
||||||
Compose a message to the selected deliverable users.
|
|
||||||
</DialogDescription>
|
|
||||||
</DialogHeader>
|
|
||||||
{sendUserMessage.isPending ? (
|
|
||||||
<Progress value={100} className="animate-pulse" />
|
|
||||||
) : null}
|
|
||||||
<div className="flex flex-1 flex-col gap-4 overflow-y-auto px-4 py-4">
|
|
||||||
{sendUserMessage.isError ? (
|
|
||||||
<UIAlert variant="destructive">
|
|
||||||
<AlertDescription>
|
|
||||||
Unable to send message:{" "}
|
|
||||||
{(sendUserMessage.error as Error)?.message || "Unknown error"}
|
|
||||||
</AlertDescription>
|
|
||||||
</UIAlert>
|
|
||||||
) : null}
|
) : null}
|
||||||
{sendUserMessage.isSuccess ? (
|
<div className="flex flex-1 flex-col gap-4 overflow-y-auto px-4 py-4">
|
||||||
|
{sendUserMessage.isError ? (
|
||||||
|
<UIAlert variant="destructive">
|
||||||
|
<AlertDescription>
|
||||||
|
Unable to send message:{" "}
|
||||||
|
{(sendUserMessage.error as Error)?.message ||
|
||||||
|
"Unknown error"}
|
||||||
|
</AlertDescription>
|
||||||
|
</UIAlert>
|
||||||
|
) : null}
|
||||||
|
{sendUserMessage.isSuccess ? (
|
||||||
|
<UIAlert>
|
||||||
|
<AlertDescription>
|
||||||
|
Queued for {sendUserMessage.data.recipient_count} recipients
|
||||||
|
{sendUserMessage.data.attachment_count
|
||||||
|
? ` with ${sendUserMessage.data.attachment_count} attachment${sendUserMessage.data.attachment_count === 1 ? "" : "s"}`
|
||||||
|
: ""}
|
||||||
|
{sendUserMessage.data.request_id
|
||||||
|
? ` (request ${sendUserMessage.data.request_id.slice(0, 8)})`
|
||||||
|
: ""}
|
||||||
|
.
|
||||||
|
</AlertDescription>
|
||||||
|
</UIAlert>
|
||||||
|
) : null}
|
||||||
|
|
||||||
|
{queueBanner ? (
|
||||||
|
<UIAlert
|
||||||
|
variant={
|
||||||
|
queueBanner.severity === "error" ? "destructive" : undefined
|
||||||
|
}
|
||||||
|
>
|
||||||
|
<div className="flex flex-wrap items-center gap-2">
|
||||||
|
<span className="text-sm font-semibold">
|
||||||
|
{queueBanner.message}
|
||||||
|
</span>
|
||||||
|
<Badge variant="secondary">{queueBanner.countLabel}</Badge>
|
||||||
|
</div>
|
||||||
|
</UIAlert>
|
||||||
|
) : null}
|
||||||
|
|
||||||
<UIAlert>
|
<UIAlert>
|
||||||
<AlertDescription>
|
<AlertDescription>
|
||||||
Queued for {sendUserMessage.data.recipient_count} recipients
|
{selectedRows.length} selected,{" "}
|
||||||
{sendUserMessage.data.attachment_count
|
{selectedDeliverableRows.length} deliverable.
|
||||||
? ` with ${sendUserMessage.data.attachment_count} attachment${sendUserMessage.data.attachment_count === 1 ? "" : "s"}`
|
{skippedRows.length
|
||||||
|
? ` ${skippedRows.length} will be skipped because they do not have a deliverable email address.`
|
||||||
: ""}
|
: ""}
|
||||||
{sendUserMessage.data.request_id
|
|
||||||
? ` (request ${sendUserMessage.data.request_id.slice(0, 8)})`
|
|
||||||
: ""}
|
|
||||||
.
|
|
||||||
</AlertDescription>
|
</AlertDescription>
|
||||||
</UIAlert>
|
</UIAlert>
|
||||||
) : null}
|
|
||||||
|
|
||||||
{queueBanner ? (
|
<div className="flex flex-wrap gap-1">
|
||||||
<UIAlert
|
{selectedDeliverableRows.map((row) => (
|
||||||
variant={
|
<Badge key={row.jellyfin_id} variant="secondary">
|
||||||
queueBanner.severity === "error" ? "destructive" : undefined
|
{`${userLabel(row)} <${row.email}>`}
|
||||||
}
|
</Badge>
|
||||||
>
|
))}
|
||||||
<div className="flex flex-wrap items-center gap-2">
|
</div>
|
||||||
<span className="text-sm font-semibold">
|
|
||||||
{queueBanner.message}
|
|
||||||
</span>
|
|
||||||
<Badge variant="secondary">{queueBanner.countLabel}</Badge>
|
|
||||||
</div>
|
|
||||||
</UIAlert>
|
|
||||||
) : null}
|
|
||||||
|
|
||||||
<UIAlert>
|
<div className="flex flex-col gap-1.5">
|
||||||
<AlertDescription>
|
<Label htmlFor="compose-subject">Subject</Label>
|
||||||
{selectedRows.length} selected, {selectedDeliverableRows.length}{" "}
|
<Input
|
||||||
deliverable.
|
id="compose-subject"
|
||||||
{skippedRows.length
|
value={subject}
|
||||||
? ` ${skippedRows.length} will be skipped because they do not have a deliverable email address.`
|
onChange={(event) => setSubject(event.target.value)}
|
||||||
: ""}
|
|
||||||
</AlertDescription>
|
|
||||||
</UIAlert>
|
|
||||||
|
|
||||||
<div className="flex flex-wrap gap-1">
|
|
||||||
{selectedDeliverableRows.map((row) => (
|
|
||||||
<Badge key={row.jellyfin_id} variant="secondary">
|
|
||||||
{`${userLabel(row)} <${row.email}>`}
|
|
||||||
</Badge>
|
|
||||||
))}
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div className="flex flex-col gap-1.5">
|
|
||||||
<Label htmlFor="compose-subject">Subject</Label>
|
|
||||||
<Input
|
|
||||||
id="compose-subject"
|
|
||||||
value={subject}
|
|
||||||
onChange={(event) => setSubject(event.target.value)}
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div className="flex flex-wrap gap-1">
|
|
||||||
<Tooltip>
|
|
||||||
<TooltipTrigger asChild>
|
|
||||||
<UiButton
|
|
||||||
variant="ghost"
|
|
||||||
size="icon"
|
|
||||||
onClick={() => insertMarkup("<strong>", "</strong>")}
|
|
||||||
aria-label="Bold"
|
|
||||||
>
|
|
||||||
<Bold />
|
|
||||||
</UiButton>
|
|
||||||
</TooltipTrigger>
|
|
||||||
<TooltipContent>Bold</TooltipContent>
|
|
||||||
</Tooltip>
|
|
||||||
<Tooltip>
|
|
||||||
<TooltipTrigger asChild>
|
|
||||||
<UiButton
|
|
||||||
variant="ghost"
|
|
||||||
size="icon"
|
|
||||||
onClick={() => insertMarkup("<em>", "</em>")}
|
|
||||||
aria-label="Italic"
|
|
||||||
>
|
|
||||||
<Italic />
|
|
||||||
</UiButton>
|
|
||||||
</TooltipTrigger>
|
|
||||||
<TooltipContent>Italic</TooltipContent>
|
|
||||||
</Tooltip>
|
|
||||||
<Tooltip>
|
|
||||||
<TooltipTrigger asChild>
|
|
||||||
<UiButton
|
|
||||||
variant="ghost"
|
|
||||||
size="icon"
|
|
||||||
onClick={addLink}
|
|
||||||
aria-label="Link"
|
|
||||||
>
|
|
||||||
<Link />
|
|
||||||
</UiButton>
|
|
||||||
</TooltipTrigger>
|
|
||||||
<TooltipContent>Link</TooltipContent>
|
|
||||||
</Tooltip>
|
|
||||||
<Tooltip>
|
|
||||||
<TooltipTrigger asChild>
|
|
||||||
<UiButton
|
|
||||||
variant="ghost"
|
|
||||||
size="icon"
|
|
||||||
onClick={() => insertMarkup("<ul><li>", "</li></ul>")}
|
|
||||||
aria-label="Bullet list"
|
|
||||||
>
|
|
||||||
<List />
|
|
||||||
</UiButton>
|
|
||||||
</TooltipTrigger>
|
|
||||||
<TooltipContent>Bullet list</TooltipContent>
|
|
||||||
</Tooltip>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div className="flex flex-col gap-1.5">
|
|
||||||
<Label htmlFor="compose-body">HTML message body</Label>
|
|
||||||
<Textarea
|
|
||||||
id="compose-body"
|
|
||||||
ref={htmlBodyRef}
|
|
||||||
value={htmlBody}
|
|
||||||
onChange={(event) => setHtmlBody(event.target.value)}
|
|
||||||
className="min-h-[260px] font-mono"
|
|
||||||
/>
|
|
||||||
<p className="text-xs text-muted-foreground">
|
|
||||||
Formatting is sent as HTML; a plain-text fallback is generated
|
|
||||||
automatically.
|
|
||||||
</p>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div className="rounded-lg border bg-muted/40 p-4">
|
|
||||||
<p className="mb-2 text-sm font-semibold">Preview</p>
|
|
||||||
<div className="overflow-hidden rounded-md border bg-card">
|
|
||||||
<iframe
|
|
||||||
title="Email preview"
|
|
||||||
sandbox=""
|
|
||||||
srcDoc={`<!doctype html><html><head><meta charset="utf-8"><style>body{font-family:Roboto,Arial,sans-serif;padding:16px;margin:0;background:#fff;color:#111;line-height:1.5}</style></head><body>${htmlBody || "<p>(Empty)</p>"}</body></html>`}
|
|
||||||
style={{ width: "100%", minHeight: 220, border: 0 }}
|
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
|
||||||
|
|
||||||
<div className="flex flex-wrap items-center gap-1">
|
<div className="flex flex-wrap gap-1">
|
||||||
<UiButton asChild variant="outline">
|
<Tooltip>
|
||||||
<label className="cursor-pointer">
|
<TooltipTrigger asChild>
|
||||||
<Paperclip />
|
<UiButton
|
||||||
Add attachment
|
variant="ghost"
|
||||||
<input
|
size="icon"
|
||||||
hidden
|
className="mobile-touch-target"
|
||||||
type="file"
|
onClick={() => insertMarkup("<strong>", "</strong>")}
|
||||||
multiple
|
aria-label="Bold"
|
||||||
onChange={handleAttachments}
|
>
|
||||||
|
<Bold />
|
||||||
|
</UiButton>
|
||||||
|
</TooltipTrigger>
|
||||||
|
<TooltipContent>Bold</TooltipContent>
|
||||||
|
</Tooltip>
|
||||||
|
<Tooltip>
|
||||||
|
<TooltipTrigger asChild>
|
||||||
|
<UiButton
|
||||||
|
variant="ghost"
|
||||||
|
size="icon"
|
||||||
|
className="mobile-touch-target"
|
||||||
|
onClick={() => insertMarkup("<em>", "</em>")}
|
||||||
|
aria-label="Italic"
|
||||||
|
>
|
||||||
|
<Italic />
|
||||||
|
</UiButton>
|
||||||
|
</TooltipTrigger>
|
||||||
|
<TooltipContent>Italic</TooltipContent>
|
||||||
|
</Tooltip>
|
||||||
|
<Tooltip>
|
||||||
|
<TooltipTrigger asChild>
|
||||||
|
<UiButton
|
||||||
|
variant="ghost"
|
||||||
|
size="icon"
|
||||||
|
className="mobile-touch-target"
|
||||||
|
onClick={addLink}
|
||||||
|
aria-label="Link"
|
||||||
|
>
|
||||||
|
<Link />
|
||||||
|
</UiButton>
|
||||||
|
</TooltipTrigger>
|
||||||
|
<TooltipContent>Link</TooltipContent>
|
||||||
|
</Tooltip>
|
||||||
|
<Tooltip>
|
||||||
|
<TooltipTrigger asChild>
|
||||||
|
<UiButton
|
||||||
|
variant="ghost"
|
||||||
|
size="icon"
|
||||||
|
className="mobile-touch-target"
|
||||||
|
onClick={() => insertMarkup("<ul><li>", "</li></ul>")}
|
||||||
|
aria-label="Bullet list"
|
||||||
|
>
|
||||||
|
<List />
|
||||||
|
</UiButton>
|
||||||
|
</TooltipTrigger>
|
||||||
|
<TooltipContent>Bullet list</TooltipContent>
|
||||||
|
</Tooltip>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<div className="flex flex-col gap-1.5">
|
||||||
|
<Label htmlFor="compose-body">HTML message body</Label>
|
||||||
|
<Textarea
|
||||||
|
id="compose-body"
|
||||||
|
ref={htmlBodyRef}
|
||||||
|
value={htmlBody}
|
||||||
|
onChange={(event) => setHtmlBody(event.target.value)}
|
||||||
|
className="min-h-[260px] font-mono"
|
||||||
|
/>
|
||||||
|
<p className="text-xs text-muted-foreground">
|
||||||
|
Formatting is sent as HTML; a plain-text fallback is generated
|
||||||
|
automatically.
|
||||||
|
</p>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<div className="rounded-lg border bg-muted/40 p-4">
|
||||||
|
<p className="mb-2 text-sm font-semibold">Preview</p>
|
||||||
|
<div className="overflow-hidden rounded-md border bg-card">
|
||||||
|
<iframe
|
||||||
|
title="Email preview"
|
||||||
|
sandbox=""
|
||||||
|
srcDoc={`<!doctype html><html><head><meta charset="utf-8"><style>body{font-family:Roboto,Arial,sans-serif;padding:16px;margin:0;background:#fff;color:#111;line-height:1.5}</style></head><body>${htmlBody || "<p>(Empty)</p>"}</body></html>`}
|
||||||
|
style={{ width: "100%", minHeight: 220, border: 0 }}
|
||||||
/>
|
/>
|
||||||
</label>
|
</div>
|
||||||
</UiButton>
|
</div>
|
||||||
{attachments.map((file, index) => (
|
|
||||||
<Badge
|
<div className="flex flex-wrap items-center gap-1">
|
||||||
key={`${file.name}-${index}`}
|
<UiButton asChild variant="outline">
|
||||||
variant="secondary"
|
<label className="cursor-pointer">
|
||||||
className="gap-1 pr-1"
|
<Paperclip />
|
||||||
>
|
Add attachment
|
||||||
{file.name}
|
<input
|
||||||
<button
|
hidden
|
||||||
type="button"
|
type="file"
|
||||||
aria-label={`Remove ${file.name}`}
|
multiple
|
||||||
onClick={() => removeAttachment(index)}
|
onChange={handleAttachments}
|
||||||
className="inline-flex items-center text-current [&>svg]:size-3"
|
/>
|
||||||
|
</label>
|
||||||
|
</UiButton>
|
||||||
|
{attachments.map((file, index) => (
|
||||||
|
<Badge
|
||||||
|
key={`${file.name}-${index}`}
|
||||||
|
variant="secondary"
|
||||||
|
className="gap-1 pr-1"
|
||||||
>
|
>
|
||||||
<Trash2 />
|
{file.name}
|
||||||
</button>
|
<button
|
||||||
</Badge>
|
type="button"
|
||||||
))}
|
aria-label={`Remove ${file.name}`}
|
||||||
|
onClick={() => removeAttachment(index)}
|
||||||
|
className="mobile-touch-target inline-flex items-center text-current [&>svg]:size-3"
|
||||||
|
>
|
||||||
|
<Trash2 />
|
||||||
|
</button>
|
||||||
|
</Badge>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</>
|
||||||
<DialogFooter className="m-0 border-t p-4">
|
);
|
||||||
<UiButton variant="ghost" onClick={closeCompose}>
|
|
||||||
Cancel
|
if (isMobile) {
|
||||||
</UiButton>
|
return (
|
||||||
<UiButton
|
<SheetForm
|
||||||
variant="default"
|
open={composeOpen}
|
||||||
disabled={
|
onOpenChange={(open) => {
|
||||||
sendUserMessage.isPending ||
|
if (!open) closeCompose();
|
||||||
!selectedDeliverableRows.length ||
|
}}
|
||||||
!subject.trim()
|
title="Message selected users"
|
||||||
|
onSave={handleSend}
|
||||||
|
onCancel={closeCompose}
|
||||||
|
isPending={sendUserMessage.isPending}
|
||||||
|
saveDisabled={!selectedDeliverableRows.length || !subject.trim()}
|
||||||
|
saveLabel="Send message"
|
||||||
|
isDirty={
|
||||||
|
subject.trim() !== "" ||
|
||||||
|
htmlBody.trim() !== DEFAULT_HTML_BODY.trim() ||
|
||||||
|
attachments.length > 0
|
||||||
}
|
}
|
||||||
onClick={handleSend}
|
|
||||||
>
|
>
|
||||||
<Send />
|
<div className="flex flex-col gap-4">{composeBody}</div>
|
||||||
Send message
|
</SheetForm>
|
||||||
</UiButton>
|
);
|
||||||
</DialogFooter>
|
}
|
||||||
</DialogContent>
|
|
||||||
</Dialog>
|
return (
|
||||||
|
<Dialog
|
||||||
|
open={composeOpen}
|
||||||
|
onOpenChange={(open) => {
|
||||||
|
if (!open) {
|
||||||
|
closeCompose();
|
||||||
|
}
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<DialogContent
|
||||||
|
className={cn(
|
||||||
|
"flex max-h-[90dvh] flex-col gap-0 overflow-hidden p-0 sm:max-w-2xl",
|
||||||
|
isComposeMobile &&
|
||||||
|
"inset-0 max-h-none max-w-none translate-x-0 translate-y-0 rounded-none",
|
||||||
|
)}
|
||||||
|
>
|
||||||
|
<DialogHeader className="gap-1 px-4 pt-4">
|
||||||
|
<DialogTitle className="pr-8">
|
||||||
|
Message selected users
|
||||||
|
</DialogTitle>
|
||||||
|
<DialogDescription className="sr-only">
|
||||||
|
Compose a message to the selected deliverable users.
|
||||||
|
</DialogDescription>
|
||||||
|
</DialogHeader>
|
||||||
|
{composeBody}
|
||||||
|
<DialogFooter className="m-0 border-t p-4">
|
||||||
|
<UiButton variant="ghost" onClick={closeCompose}>
|
||||||
|
Cancel
|
||||||
|
</UiButton>
|
||||||
|
<UiButton
|
||||||
|
variant="default"
|
||||||
|
disabled={
|
||||||
|
sendUserMessage.isPending ||
|
||||||
|
!selectedDeliverableRows.length ||
|
||||||
|
!subject.trim()
|
||||||
|
}
|
||||||
|
onClick={handleSend}
|
||||||
|
>
|
||||||
|
<Send />
|
||||||
|
Send message
|
||||||
|
</UiButton>
|
||||||
|
</DialogFooter>
|
||||||
|
</DialogContent>
|
||||||
|
</Dialog>
|
||||||
|
);
|
||||||
|
})()}
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,149 @@
|
|||||||
|
import { describe, it, expect, beforeEach, vi } from "vitest";
|
||||||
|
import { render, screen } from "@testing-library/react";
|
||||||
|
import userEvent from "@testing-library/user-event";
|
||||||
|
import { ServicePage } from "../ServicePage";
|
||||||
|
import type {
|
||||||
|
ServiceInstance,
|
||||||
|
ServiceInstanceInput,
|
||||||
|
ServiceTypeInfo,
|
||||||
|
} from "../../types";
|
||||||
|
|
||||||
|
// --- fixtures ---
|
||||||
|
|
||||||
|
const instance: ServiceInstance = {
|
||||||
|
id: "svc-1",
|
||||||
|
service_type: "grafana",
|
||||||
|
name: "Production Grafana",
|
||||||
|
config: { base_url: "https://grafana.example.com", timeout_seconds: 5 },
|
||||||
|
secrets_set: { api_key: true },
|
||||||
|
enabled: true,
|
||||||
|
created_at: 1_700_000_000,
|
||||||
|
updated_at: 1_700_000_000,
|
||||||
|
};
|
||||||
|
|
||||||
|
const typeInfo: ServiceTypeInfo = {
|
||||||
|
service_type: "grafana",
|
||||||
|
name: "Grafana",
|
||||||
|
description: "Dashboards, metrics, and logs.",
|
||||||
|
config_schema: {
|
||||||
|
type: "object",
|
||||||
|
properties: {
|
||||||
|
base_url: { type: "string", description: "Absolute URL." },
|
||||||
|
timeout_seconds: { type: "integer" },
|
||||||
|
},
|
||||||
|
},
|
||||||
|
secret_fields: [{ key: "api_key", label: "API key", required: false }],
|
||||||
|
widget_kinds: [],
|
||||||
|
};
|
||||||
|
|
||||||
|
// --- mocks ---
|
||||||
|
|
||||||
|
const mutateAsync = vi.fn();
|
||||||
|
const mutate = vi.fn();
|
||||||
|
const deleteMutate = vi.fn();
|
||||||
|
|
||||||
|
vi.mock("../../hooks/useServices", () => ({
|
||||||
|
useServiceInstances: () => ({ data: [instance] }),
|
||||||
|
useServiceTypes: () => ({ data: [typeInfo] }),
|
||||||
|
useSaveServiceInstance: () => ({
|
||||||
|
mutateAsync,
|
||||||
|
mutate,
|
||||||
|
isPending: false,
|
||||||
|
}),
|
||||||
|
useDeleteServiceInstance: () => ({ mutate: deleteMutate, isPending: false }),
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("react-router-dom", () => ({
|
||||||
|
useParams: () => ({
|
||||||
|
serviceType: "grafana",
|
||||||
|
serviceId: "svc-1",
|
||||||
|
}),
|
||||||
|
useNavigate: () => vi.fn(),
|
||||||
|
}));
|
||||||
|
|
||||||
|
// jsdom has no window.matchMedia; stub it. Default to desktop (matches: false).
|
||||||
|
function setMatchMedia(matches: boolean) {
|
||||||
|
window.matchMedia = ((query: string) => ({
|
||||||
|
matches: query.includes("768") ? matches : false,
|
||||||
|
media: query,
|
||||||
|
onchange: null,
|
||||||
|
addEventListener: () => {},
|
||||||
|
removeEventListener: () => {},
|
||||||
|
addListener: () => {},
|
||||||
|
removeListener: () => {},
|
||||||
|
dispatchEvent: () => false,
|
||||||
|
})) as unknown as typeof window.matchMedia;
|
||||||
|
}
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
setMatchMedia(false);
|
||||||
|
mutateAsync.mockReset();
|
||||||
|
mutate.mockReset();
|
||||||
|
deleteMutate.mockReset();
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("ServicePage (desktop)", () => {
|
||||||
|
it("renders the full-page layout with the service name and connection card", () => {
|
||||||
|
render(<ServicePage />);
|
||||||
|
// Page heading (desktop only — mobile uses SheetForm title)
|
||||||
|
expect(
|
||||||
|
screen.getByRole("heading", { name: "Production Grafana" }),
|
||||||
|
).toBeInTheDocument();
|
||||||
|
// Connection section card title
|
||||||
|
expect(screen.getByText("Connection")).toBeInTheDocument();
|
||||||
|
// General Save button
|
||||||
|
expect(screen.getByRole("button", { name: "Save" })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("does not render the SheetForm at desktop width", () => {
|
||||||
|
render(<ServicePage />);
|
||||||
|
// SheetForm renders a dialog with role="dialog" only when open; on
|
||||||
|
// desktop the page layout is used, so no dialog should be present.
|
||||||
|
expect(screen.queryByRole("dialog")).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("ServicePage (mobile SheetForm — slice 6)", () => {
|
||||||
|
beforeEach(() => setMatchMedia(true));
|
||||||
|
|
||||||
|
it("renders the SheetForm with the service name as title below md", () => {
|
||||||
|
render(<ServicePage />);
|
||||||
|
// SheetForm title is rendered inside a SheetTitle (role="heading").
|
||||||
|
expect(
|
||||||
|
screen.getByRole("heading", { name: "Production Grafana" }),
|
||||||
|
).toBeInTheDocument();
|
||||||
|
// The dialog (Sheet content) should be present on mobile.
|
||||||
|
expect(screen.getByRole("dialog")).toBeInTheDocument();
|
||||||
|
// Desktop page header description is NOT rendered inside the SheetForm.
|
||||||
|
expect(
|
||||||
|
screen.queryByText("Dashboards, metrics, and logs."),
|
||||||
|
).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("edits the name field and Save calls the save mutation", async () => {
|
||||||
|
render(<ServicePage />);
|
||||||
|
const nameInput = screen.getByLabelText("Name");
|
||||||
|
expect(nameInput).toHaveValue("Production Grafana");
|
||||||
|
|
||||||
|
await userEvent.clear(nameInput);
|
||||||
|
await userEvent.type(nameInput, "Renamed Grafana");
|
||||||
|
|
||||||
|
const saveButton = screen.getByRole("button", { name: "Save" });
|
||||||
|
await userEvent.click(saveButton);
|
||||||
|
|
||||||
|
expect(mutateAsync).toHaveBeenCalledTimes(1);
|
||||||
|
const input = mutateAsync.mock.calls[0][0] as ServiceInstanceInput;
|
||||||
|
expect(input.name).toBe("Renamed Grafana");
|
||||||
|
expect(input.id).toBe("svc-1");
|
||||||
|
// Lock the full save payload (config draft, enabled, secrets sentinel).
|
||||||
|
expect(input.enabled).toBe(true);
|
||||||
|
expect(input.secrets).toEqual({});
|
||||||
|
expect(input.config).toMatchObject({ base_url: "https://grafana.example.com" });
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders the connection config fields as editable inside the SheetForm", () => {
|
||||||
|
render(<ServicePage />);
|
||||||
|
const urlInput = screen.getByLabelText("base_url");
|
||||||
|
expect(urlInput).toHaveValue("https://grafana.example.com");
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -6,12 +6,10 @@ import type { MonitoringMachine } from "../../types";
|
|||||||
|
|
||||||
const saveMachineMutate = vi.fn().mockResolvedValue({});
|
const saveMachineMutate = vi.fn().mockResolvedValue({});
|
||||||
const deleteMachineMutate = vi.fn();
|
const deleteMachineMutate = vi.fn();
|
||||||
const testSSHMutate = vi
|
const testSSHMutate = vi.fn().mockResolvedValue({
|
||||||
.fn()
|
message: "SSH auth succeeded",
|
||||||
.mockResolvedValue({
|
known_hosts_updated: true,
|
||||||
message: "SSH auth succeeded",
|
});
|
||||||
known_hosts_updated: true,
|
|
||||||
});
|
|
||||||
|
|
||||||
let machines: MonitoringMachine[] = [];
|
let machines: MonitoringMachine[] = [];
|
||||||
|
|
||||||
@@ -113,3 +111,103 @@ describe("Settings", () => {
|
|||||||
expect(deleteMachineMutate).toHaveBeenCalledWith("m1");
|
expect(deleteMachineMutate).toHaveBeenCalledWith("m1");
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// jsdom has no window.matchMedia; default to desktop so existing tests are
|
||||||
|
// unaffected.
|
||||||
|
function setMatchMedia(matches: boolean) {
|
||||||
|
window.matchMedia = ((query: string) => ({
|
||||||
|
matches: query.includes("768") ? matches : false,
|
||||||
|
media: query,
|
||||||
|
onchange: null,
|
||||||
|
addEventListener: () => {},
|
||||||
|
removeEventListener: () => {},
|
||||||
|
addListener: () => {},
|
||||||
|
removeListener: () => {},
|
||||||
|
dispatchEvent: () => false,
|
||||||
|
})) as unknown as typeof window.matchMedia;
|
||||||
|
}
|
||||||
|
|
||||||
|
describe("Settings (mobile SheetForm — slice 7)", () => {
|
||||||
|
beforeEach(() => setMatchMedia(true));
|
||||||
|
|
||||||
|
it("opens the machine editor in a SheetForm below md", async () => {
|
||||||
|
machines = [localMachine()];
|
||||||
|
render(<Settings />);
|
||||||
|
|
||||||
|
// Open the editor via the detail-pane Edit button (visible text).
|
||||||
|
const detailEdit = screen
|
||||||
|
.getAllByRole("button", { name: "Edit" })
|
||||||
|
.find((button) => button.textContent === "Edit") as HTMLButtonElement;
|
||||||
|
await userEvent.click(detailEdit);
|
||||||
|
|
||||||
|
// SheetForm renders a dialog; the DialogTitle shows the editor title.
|
||||||
|
expect(screen.getByText("Edit machine")).toBeInTheDocument();
|
||||||
|
expect(screen.getByRole("dialog")).toBeInTheDocument();
|
||||||
|
// Desktop DialogDescription text is not rendered as a dialog description
|
||||||
|
// on mobile (the MachineEditor has its own hint labels, which is fine).
|
||||||
|
expect(
|
||||||
|
screen.queryByRole("heading", { name: "Create machine" }),
|
||||||
|
).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("saves a machine via the SheetForm on mobile", async () => {
|
||||||
|
machines = [localMachine()];
|
||||||
|
render(<Settings />);
|
||||||
|
|
||||||
|
const detailEdit = screen
|
||||||
|
.getAllByRole("button", { name: "Edit" })
|
||||||
|
.find((button) => button.textContent === "Edit") as HTMLButtonElement;
|
||||||
|
await userEvent.click(detailEdit);
|
||||||
|
|
||||||
|
const nameInput = screen.getByLabelText("Name");
|
||||||
|
await userEvent.clear(nameInput);
|
||||||
|
await userEvent.type(nameInput, "Renamed node");
|
||||||
|
|
||||||
|
await userEvent.click(screen.getByRole("button", { name: "Save machine" }));
|
||||||
|
|
||||||
|
expect(saveMachineMutate).toHaveBeenCalledTimes(1);
|
||||||
|
const saved = saveMachineMutate.mock.calls[0][0];
|
||||||
|
expect(saved.name).toBe("Renamed node");
|
||||||
|
expect(saved.mode).toBe("local");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("cancel closes the SheetForm on mobile", async () => {
|
||||||
|
machines = [localMachine()];
|
||||||
|
render(<Settings />);
|
||||||
|
|
||||||
|
const detailEdit = screen
|
||||||
|
.getAllByRole("button", { name: "Edit" })
|
||||||
|
.find((button) => button.textContent === "Edit") as HTMLButtonElement;
|
||||||
|
await userEvent.click(detailEdit);
|
||||||
|
|
||||||
|
expect(screen.getByRole("dialog")).toBeInTheDocument();
|
||||||
|
|
||||||
|
await userEvent.click(screen.getByRole("button", { name: "Cancel" }));
|
||||||
|
// The sheet is now closed — the dialog role should no longer be present.
|
||||||
|
// (The page content itself is still rendered; only the sheet unmounts.)
|
||||||
|
expect(screen.queryByText("Edit machine")).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("prompts before discarding unsaved machine edits (R4.5)", async () => {
|
||||||
|
machines = [localMachine()];
|
||||||
|
render(<Settings />);
|
||||||
|
|
||||||
|
const detailEdit = screen
|
||||||
|
.getAllByRole("button", { name: "Edit" })
|
||||||
|
.find((button) => button.textContent === "Edit") as HTMLButtonElement;
|
||||||
|
await userEvent.click(detailEdit);
|
||||||
|
|
||||||
|
// Edit the name to make the form dirty.
|
||||||
|
const nameInput = screen.getByLabelText("Name");
|
||||||
|
await userEvent.clear(nameInput);
|
||||||
|
await userEvent.type(nameInput, "Dirty name");
|
||||||
|
|
||||||
|
// Cancel should NOT immediately close — the discard confirm appears.
|
||||||
|
await userEvent.click(screen.getByRole("button", { name: "Cancel" }));
|
||||||
|
expect(
|
||||||
|
screen.getByRole("heading", { name: "Discard changes?" }),
|
||||||
|
).toBeInTheDocument();
|
||||||
|
// The editor is still open.
|
||||||
|
expect(screen.getByText("Edit machine")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -286,7 +286,7 @@ describe("UsersPage (slice 6b — compose dialog formatting actions)", () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe("UsersPage (mobile card layout — slice 5)", () => {
|
describe("UsersPage (mobile card layout — slice 5)", () => {
|
||||||
beforeEach(() => {
|
beforeEach(() => {
|
||||||
window.matchMedia = ((query: string) => ({
|
window.matchMedia = ((query: string) => ({
|
||||||
matches: query.includes("768"),
|
matches: query.includes("768"),
|
||||||
@@ -342,4 +342,66 @@ describe("UsersPage (slice 6b — compose dialog formatting actions)", () => {
|
|||||||
// drawer opens via a card-body tap, not via the checkbox.
|
// drawer opens via a card-body tap, not via the checkbox.
|
||||||
expect(screen.queryByTestId("session-panel-stub")).not.toBeInTheDocument();
|
expect(screen.queryByTestId("session-panel-stub")).not.toBeInTheDocument();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("renders compose in a SheetForm below md with send button", async () => {
|
||||||
|
users = [
|
||||||
|
userFixture({
|
||||||
|
jellyfin_id: "u1",
|
||||||
|
display_name: "Alice",
|
||||||
|
email: "alice@example.com",
|
||||||
|
}),
|
||||||
|
];
|
||||||
|
render(
|
||||||
|
<TooltipProvider>
|
||||||
|
<UsersPage />
|
||||||
|
</TooltipProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
// Select the deliverable user via the mobile card checkbox.
|
||||||
|
await userEvent.click(
|
||||||
|
screen.getByRole("checkbox", { name: /Select Alice/i }),
|
||||||
|
);
|
||||||
|
await userEvent.click(
|
||||||
|
screen.getByRole("button", { name: "Message selected" }),
|
||||||
|
);
|
||||||
|
|
||||||
|
// On mobile, compose opens in a SheetForm (not a Dialog). The SheetForm
|
||||||
|
// header carries the title and the footer carries the Send button.
|
||||||
|
expect(screen.getByText("Message selected users")).toBeInTheDocument();
|
||||||
|
expect(
|
||||||
|
screen.getByRole("button", { name: "Send message" }),
|
||||||
|
).toBeInTheDocument();
|
||||||
|
expect(screen.getByLabelText("Subject")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("prompts before discarding unsaved compose edits (R4.5)", async () => {
|
||||||
|
users = [
|
||||||
|
userFixture({
|
||||||
|
jellyfin_id: "u1",
|
||||||
|
display_name: "Alice",
|
||||||
|
email: "alice@example.com",
|
||||||
|
}),
|
||||||
|
];
|
||||||
|
render(
|
||||||
|
<TooltipProvider>
|
||||||
|
<UsersPage />
|
||||||
|
</TooltipProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
await userEvent.click(
|
||||||
|
screen.getByRole("checkbox", { name: /Select Alice/i }),
|
||||||
|
);
|
||||||
|
await userEvent.click(
|
||||||
|
screen.getByRole("button", { name: "Message selected" }),
|
||||||
|
);
|
||||||
|
|
||||||
|
// Type a subject to make the compose form dirty.
|
||||||
|
await userEvent.type(screen.getByLabelText("Subject"), "Urgent update");
|
||||||
|
|
||||||
|
// Cancel should NOT immediately close — the discard confirm appears.
|
||||||
|
await userEvent.click(screen.getByRole("button", { name: "Cancel" }));
|
||||||
|
expect(
|
||||||
|
screen.getByRole("heading", { name: "Discard changes?" }),
|
||||||
|
).toBeInTheDocument();
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -0,0 +1,125 @@
|
|||||||
|
# Verify Report — Mobile responsive parity
|
||||||
|
|
||||||
|
**Change:** `mobile-responsive-parity`
|
||||||
|
**Phase:** verify
|
||||||
|
**Date:** 2026-06-26
|
||||||
|
|
||||||
|
## Summary
|
||||||
|
|
||||||
|
All 9 routes are fully operable in phone portrait (≥360px) at a single `md:`
|
||||||
|
(768px) breakpoint. Desktop layout (≥768px) is unchanged. No backend changes.
|
||||||
|
No new product features.
|
||||||
|
|
||||||
|
## Acceptance criteria
|
||||||
|
|
||||||
|
### AC1 — Every route fully operable at 375px ✅
|
||||||
|
|
||||||
|
All 9 routes (Dashboard, Observability, Media, Files, Backups, Users, Actions,
|
||||||
|
Services, Settings) render and operate at phone-portrait width:
|
||||||
|
|
||||||
|
- **Dashboard**: single-column widget stack + section anchor bar (Slice 2).
|
||||||
|
- **Observability**: existing responsive layout + touch-target audit (Slice 9).
|
||||||
|
- **Media**: card layout with mobile pagination, card-tap navigation (Slice 3).
|
||||||
|
- **Files**: card layout with directory navigation, preserved ffprobe/jobs (Slice 4).
|
||||||
|
- **Backups**: card layouts for alerts/jobs/runs tables (Slice 5).
|
||||||
|
- **Users**: card layout with selection checkboxes + drawer navigation (Slice 5).
|
||||||
|
- **Actions**: existing responsive layout + touch-target audit (Slice 9).
|
||||||
|
- **Services**: list renders stacked; service edit via SheetForm (Slices 6, 9).
|
||||||
|
- **Settings**: machine editor via SheetForm; existing inline panels stack (Slice 7, 9).
|
||||||
|
|
||||||
|
### AC2 — Four wide tables show cards at 375px and tables at 1280px ✅
|
||||||
|
|
||||||
|
Media, FileBrowser, UsersPage, and the three Backups tables each render
|
||||||
|
`MobileCardRow` cards below `md` and `<DataTable>` tables at/above `md`. Each
|
||||||
|
card shows a primary title + 3–5 fields chosen per-table. Tested in Vitest
|
||||||
|
with mocked `matchMedia` at both breakpoints.
|
||||||
|
|
||||||
|
### AC3 — Four edit forms open in Sheet at 375px and Dialog at 1280px ✅
|
||||||
|
|
||||||
|
ServicePage, Settings (machine editor), message compose, and WidgetConfigDialog
|
||||||
|
each branch on `useIsMobile()` to render `SheetForm` (side=bottom, full-height)
|
||||||
|
below `md` and the existing `Dialog` at/above `md`. Tested in Vitest.
|
||||||
|
|
||||||
|
### AC4 — HoverEditButton always visible at 375px, hover-revealed at 1280px ✅
|
||||||
|
|
||||||
|
`HoverEditButton` defaults to `mobile="always"` (always visible below `md`,
|
||||||
|
hover-revealed at `md:`+). Tested in HoverEditButton.test.tsx with class-
|
||||||
|
composition assertions.
|
||||||
|
|
||||||
|
### AC5 — 44px minimum touch-target audit ✅
|
||||||
|
|
||||||
|
40 interactive elements across 12 files now carry the `mobile-touch-target`
|
||||||
|
class (applies `min-height: 44px; min-width: 44px` only below 768px). Covers
|
||||||
|
icon buttons, checkboxes, switches, and small text buttons. Default-size text
|
||||||
|
buttons (32px) were deliberately skipped to stay surgical — flagged as a
|
||||||
|
residual risk if strict WCAG 2.5.5 on ALL elements is required.
|
||||||
|
|
||||||
|
### AC6 — Dashboard single column + anchors at 375px, grid at 1280px ✅
|
||||||
|
|
||||||
|
Tested in Dashboard.test.tsx: mobile test asserts single column + section
|
||||||
|
labels + anchor pills; desktop test asserts no anchor bar + widgets present.
|
||||||
|
|
||||||
|
### AC7 — lint/build/test green ✅
|
||||||
|
|
||||||
|
```
|
||||||
|
cd frontend && npm run lint → 0 errors (2 pre-existing warnings)
|
||||||
|
cd frontend && npm run build → ✓ built (tsc -b + vite)
|
||||||
|
cd frontend && npm run test → 28 files / 116 tests passed
|
||||||
|
```
|
||||||
|
|
||||||
|
### AC8 — Vitest test per touched page at <768px and ≥768px ✅
|
||||||
|
|
||||||
|
Each touched page has at least one mobile and one desktop test:
|
||||||
|
|
||||||
|
| Page/Component | Mobile tests | Desktop tests |
|
||||||
|
|----------------|-------------|---------------|
|
||||||
|
| Dashboard | 3 | 3 (existing) |
|
||||||
|
| Media | 5 | existing |
|
||||||
|
| FileBrowser | 4 | existing |
|
||||||
|
| UsersPage | 2 | existing |
|
||||||
|
| Backups (Alerts/Runs) | 3 | existing |
|
||||||
|
| BackupJobs | 2 (new file) | — |
|
||||||
|
| ServicePage | 3 | 2 (new file) |
|
||||||
|
| Settings | 3 | existing |
|
||||||
|
| WidgetConfigDialog | 1 | 1 (new file) |
|
||||||
|
| MobileCardRow | 7 | — (primitive) |
|
||||||
|
| SheetForm | 5 | — (primitive) |
|
||||||
|
| HoverEditButton | 2 | 2 |
|
||||||
|
|
||||||
|
## Non-goals confirmed
|
||||||
|
|
||||||
|
- No tablet/landscape/sm: intermediate layout.
|
||||||
|
- No PWA, manifest, service worker.
|
||||||
|
- No polling-interval changes.
|
||||||
|
- No backend changes.
|
||||||
|
- No new data-table library.
|
||||||
|
|
||||||
|
## Residual risks / known gaps
|
||||||
|
|
||||||
|
1. **R4.5 dirty-state outside-click confirm** — RESOLVED. `SheetForm` gained an
|
||||||
|
`isDirty` prop; when true, any close path (Cancel, header X, Radix overlay
|
||||||
|
click, Escape) opens a "Discard changes?" confirm. All four form consumers
|
||||||
|
(ServicePage, Settings machine editor, message compose, WidgetConfigDialog)
|
||||||
|
compute and pass `isDirty`.
|
||||||
|
|
||||||
|
2. **Default-size text buttons (32px)** — RESOLVED. A second touch-target pass
|
||||||
|
applied `.mobile-touch-target` to 32 default-size buttons across 9 files
|
||||||
|
(Save, Cancel, Delete, Validate SSH, Run job, etc.) plus the shared
|
||||||
|
`DialogFooter`. Combined with Slice 9, all interactive elements below `md`
|
||||||
|
now meet the 44px minimum.
|
||||||
|
|
||||||
|
3. **Polling on battery** (D8 risk) — RESOLVED. `refetchIntervalInBackground:
|
||||||
|
false` is now a `QueryClient` default, so all interval polls (widgets ~30s,
|
||||||
|
queue status 5s, media build progress 1s) pause when the tab is hidden. The
|
||||||
|
`useMedia` build-progress poll no longer overrides this. Build progress
|
||||||
|
resumes and catches up on return.
|
||||||
|
|
||||||
|
4. **iOS Safari manual verification** not performed in CI. `h-[100dvh]` on
|
||||||
|
SheetForm, `position: sticky` behavior, and attachment upload from Files
|
||||||
|
need real-device testing. The flex-column layout (not `position: sticky`)
|
||||||
|
avoids the known sticky-inside-transform pitfall. UNRESOLVED — requires a
|
||||||
|
physical device pass.
|
||||||
|
|
||||||
|
5. **Pagination duplication** — RESOLVED. Extracted a shared `TablePagination`
|
||||||
|
component consumed by both the desktop `DataTable` and the Media mobile
|
||||||
|
card list. Removes ~90 lines of duplication.
|
||||||
Reference in New Issue
Block a user