Files

T

Developer 6919158012 docs: complete Jellyfin migration, archive jellyfin-service-registry

Slice 3 (final) of jellyfin-service-registry. Documents the completed
migration and archives the SDD change.

- docs/REQUIREMENTS.md: marked the machine-level Jellyfin follow-up
  resolved; added a decision-log entry (Jellyfin no longer a machine
  service, dead media_root/path_prefix removed; global config +
  path_utils retained for Jellyfin->SSH path resolution).
- CHANGELOG.md: struck through the old follow-up note; added a
  Follow-up #2 section describing the machine field + service removal.
- Archived openspec/changes/jellyfin-service-registry (no active SDD
  changes remain).

Backend ruff clean / 239 tests pass; frontend 0 lint errors / build
clean / 72 tests pass.

2026-06-24 14:56:25 +00:00

2.4 KiB

Raw Permalink Blame History

Proposal — Jellyfin service-registry migration (completion)

Change: jellyfin-service-registry Phase: proposal Date: 2026-06-23

Problem

The service-registry foundation already moved Jellyfin/Jellyseerr resolution into dependencies.py (get_jellyfin_client, get_jellyseerr_client, get_user_id) using jellyfin_service_id. The frontend Applications, Media, and Users pages already consume useServiceInstances("jellyfin").

However, the machine-level config still carries legacy Jellyfin DNA that is now dead or misleading:

DEFAULT_SERVICES = ["monitoring", "files", "jellyfin"] in settings_store.py auto-tags every local machine as a Jellyfin source.
The Settings machine editor still exposes services multi-select that can include jellyfin, even though Jellyfin is selected via the Services page, not via a machine.
MonitoringMachine types still carry media_root and path_prefix fields whose original purpose was Jellyfin→SSH path mapping, but the path-mapping logic in path_utils.py now operates independently and those fields are no longer read by the media/file flows.
Documentation still describes machine-level Jellyfin fields in places.

This creates UI confusion (two places to think about Jellyfin) and stale surface area.

Goal

Cleanly complete the Jellyfin migration onto the service registry:

Remove Jellyfin from the machine services taxonomy entirely.
Remove dead media_root / path_prefix machine fields from backend, frontend types, Settings form, and tests.
Update path-resolution helpers to rely only on the Jellyfin service config (or explicit path-prefix settings on the service record if needed), not on machine fields.
Update docs and changelog.

Non-goals

Do NOT change how Jellyfin/Jellyseerr clients are resolved in dependencies.py — that is already correct.
Do NOT remove the jellyfin / jellyseerr service definitions.
Do NOT add new service types or widgets in this change.

Acceptance

grep -R "media_root\|path_prefix" backend/src frontend/src returns only path_utils.py and its tests (if those helpers remain) or nothing (if the helpers are removed).
jellyfin no longer appears in machine services options in the Settings UI.
DEFAULT_SERVICES no longer includes jellyfin.
Backend and frontend test suites remain green.
Docs/CHANGELOG explain the final migration.

2.4 KiB Raw Permalink Blame History