fix: unify session loading states across pages

- Add per-item busy overlay to SessionCard component
- Remove full-screen loading overlay from sessions page
- Remove loadingAction state, use per-item busy state only
- Add handleStart to sessions page for consistency
- Add session-card CSS for busy overlay positioning
- Both home and sessions pages now use same per-item loading pattern
This commit is contained in:
2026-05-24 19:33:38 +00:00
parent edd8882fa0
commit d8f220d825
3 changed files with 40 additions and 19 deletions
+6 -1
View File
@@ -75,7 +75,12 @@ export function SessionCard({
const isActive = ["running", "building", "starting", "probing", "pending", "unhealthy"].includes(session.status);
return (
<article className="card session-card">
<article className={`card session-card ${isBusy ? "busy" : ""}`}>
{isBusy && (
<div className="session-busy-overlay">
<Icon name="loading" size="md" />
</div>
)}
<div className="session-card-content">
<div className="session-card-header">
<div className="session-card-title">
+15 -18
View File
@@ -9,6 +9,7 @@ import {
type Session,
deleteInstance,
stopInstance,
startInstance,
checkInstanceHealth,
recreateInstanceTunnel,
} from "../api/sessions";
@@ -38,7 +39,6 @@ export const SessionsPage = () => {
const [tunnelHealth, setTunnelHealth] = useState<Record<string, InstanceHealth>>({});
const [loadingSessionId, setLoadingSessionId] = useState<string | null>(null);
const [loadingAction, setLoadingAction] = useState<string>("");
const loadSessions = useCallback(async () => {
setStatus("loading");
@@ -156,7 +156,6 @@ export const SessionsPage = () => {
const handleStop = async (session: Session) => {
setLoadingSessionId(session.id);
setLoadingAction("Stopping...");
try {
await stopInstance(session.project_id, session.repository_id, session.id);
await loadSessions();
@@ -164,13 +163,11 @@ export const SessionsPage = () => {
// ignore
} finally {
setLoadingSessionId(null);
setLoadingAction("");
}
};
const handleDelete = async (session: Session) => {
setLoadingSessionId(session.id);
setLoadingAction("Deleting...");
try {
await deleteInstance(session.project_id, session.repository_id, session.id);
setDirtyDeleteSession(null);
@@ -189,13 +186,11 @@ export const SessionsPage = () => {
}
} finally {
setLoadingSessionId(null);
setLoadingAction("");
}
};
const handleForceDelete = async (session: Session) => {
setLoadingSessionId(session.id);
setLoadingAction("Force deleting...");
try {
await deleteInstance(session.project_id, session.repository_id, session.id, true);
setDirtyDeleteSession(null);
@@ -205,13 +200,11 @@ export const SessionsPage = () => {
// ignore
} finally {
setLoadingSessionId(null);
setLoadingAction("");
}
};
const handleRecreateTunnel = async (session: Session) => {
setLoadingSessionId(session.id);
setLoadingAction("Recreating tunnel...");
try {
await recreateInstanceTunnel(
session.project_id,
@@ -224,7 +217,18 @@ export const SessionsPage = () => {
// ignore
} finally {
setLoadingSessionId(null);
setLoadingAction("");
}
};
const handleStart = async (session: Session) => {
setLoadingSessionId(session.id);
try {
await startInstance(session.project_id, session.repository_id, session.id);
await loadSessions();
} catch {
// ignore
} finally {
setLoadingSessionId(null);
}
};
@@ -273,18 +277,11 @@ export const SessionsPage = () => {
)}
{/* Session List */}
<div className={`sessions-list-wrapper ${loadingSessionId ? "dimmed" : ""}`}>
{loadingSessionId && (
<div className="loading-overlay">
<div className="loading-content">
<Icon name="loading" size="lg" />
<p>{loadingAction}</p>
</div>
</div>
)}
<div className="sessions-list-wrapper">
<SessionList
sessions={sessions}
onOpen={handleOpen}
onStart={handleStart}
onStop={handleStop}
onDelete={handleDelete}
onRecreateTunnel={handleRecreateTunnel}
+19
View File
@@ -2500,6 +2500,25 @@ a.nav-item,
color: var(--muted);
}
.session-card {
position: relative;
}
.session-card.busy {
opacity: 0.7;
}
.session-busy-overlay {
position: absolute;
inset: 0;
display: flex;
align-items: center;
justify-content: center;
background: rgba(var(--bg-rgb, 255, 255, 255), 0.8);
border-radius: var(--space-2);
z-index: 1;
}
/* ============================================
Terminal Styles
============================================ */